Refactor option handling in WebKitTestRunner.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 16 Dec 2013 04:58:10 +0000 (04:58 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 16 Dec 2013 04:58:10 +0000 (04:58 +0000)
https://bugs.webkit.org/show_bug.cgi?id=123185

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-15
Reviewed by Darin Adler.

Option handling is refactored (according to the FIXME) that allows
to automatically generate the help message.

* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/GNUmakefile.am:
* WebKitTestRunner/Options.cpp: Added.
(WTR::Options::Options):
(WTR::handleOptionTimeout):
(WTR::handleOptionNoTimeout):
(WTR::handleOptionNoTimeoutAtAll):
(WTR::handleOptionVerbose):
(WTR::handleOptionGcBetweenTests):
(WTR::handleOptionPixelTests):
(WTR::handleOptionPrintSupportedFeatures):
(WTR::handleOptionComplexText):
(WTR::handleOptionAcceleratedDrawing):
(WTR::handleOptionRemoteLayerTree):
(WTR::handleOptionUnmatched):
(WTR::OptionsHandler::OptionsHandler):
(WTR::Option::Option):
(WTR::Option::matches):
(WTR::OptionsHandler::parse):
(WTR::OptionsHandler::printHelp):
* WebKitTestRunner/Options.h: Added.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@160627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/WebKitTestRunner/CMakeLists.txt
Tools/WebKitTestRunner/GNUmakefile.am
Tools/WebKitTestRunner/Options.cpp [new file with mode: 0644]
Tools/WebKitTestRunner/Options.h [new file with mode: 0644]
Tools/WebKitTestRunner/TestController.cpp
Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj

index d9b8ced..58b27fa 100644 (file)
@@ -1,3 +1,38 @@
+2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
+
+        Refactor option handling in WebKitTestRunner.
+        https://bugs.webkit.org/show_bug.cgi?id=123185
+
+        Reviewed by Darin Adler.
+
+        Option handling is refactored (according to the FIXME) that allows
+        to automatically generate the help message.
+
+        * WebKitTestRunner/CMakeLists.txt:
+        * WebKitTestRunner/GNUmakefile.am:
+        * WebKitTestRunner/Options.cpp: Added.
+        (WTR::Options::Options):
+        (WTR::handleOptionTimeout):
+        (WTR::handleOptionNoTimeout):
+        (WTR::handleOptionNoTimeoutAtAll):
+        (WTR::handleOptionVerbose):
+        (WTR::handleOptionGcBetweenTests):
+        (WTR::handleOptionPixelTests):
+        (WTR::handleOptionPrintSupportedFeatures):
+        (WTR::handleOptionComplexText):
+        (WTR::handleOptionAcceleratedDrawing):
+        (WTR::handleOptionRemoteLayerTree):
+        (WTR::handleOptionUnmatched):
+        (WTR::OptionsHandler::OptionsHandler):
+        (WTR::Option::Option):
+        (WTR::Option::matches):
+        (WTR::OptionsHandler::parse):
+        (WTR::OptionsHandler::printHelp):
+        * WebKitTestRunner/Options.h: Added.
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::initialize):
+        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+
 2013-12-15  Dan Bernstein  <mitz@apple.com>
 
         32-bit build fix.
index f608131..9b0f0b1 100644 (file)
@@ -6,6 +6,7 @@ file(MAKE_DIRECTORY ${DERIVED_SOURCES_DIR}/InjectedBundle)
 set(WebKitTestRunner_SOURCES
     ${WEBKIT_TESTRUNNER_DIR}/CyclicRedundancyCheck.cpp
     ${WEBKIT_TESTRUNNER_DIR}/GeolocationProviderMock.cpp
+    ${WEBKIT_TESTRUNNER_DIR}/Options.cpp
     ${WEBKIT_TESTRUNNER_DIR}/PixelDumpSupport.cpp
     ${WEBKIT_TESTRUNNER_DIR}/TestController.cpp
     ${WEBKIT_TESTRUNNER_DIR}/TestInvocation.cpp
index b004358..173286b 100644 (file)
@@ -21,6 +21,8 @@ Programs_WebKitTestRunner_SOURCES = \
        Tools/WebKitTestRunner/CyclicRedundancyCheck.h \
        Tools/WebKitTestRunner/GeolocationProviderMock.cpp \
        Tools/WebKitTestRunner/GeolocationProviderMock.h \
+       Tools/WebKitTestRunner/Options.cpp \
+       Tools/WebKitTestRunner/Options.h \
        Tools/WebKitTestRunner/PixelDumpSupport.cpp \
        Tools/WebKitTestRunner/PixelDumpSupport.h \
        Tools/WebKitTestRunner/PlatformWebView.h \
diff --git a/Tools/WebKitTestRunner/Options.cpp b/Tools/WebKitTestRunner/Options.cpp
new file mode 100644 (file)
index 0000000..8fa6e6e
--- /dev/null
@@ -0,0 +1,195 @@
+/*
+ * Copyright (C) 2013 University of Szeged. All rights reserved.
+ * Copyright (C) 2013 Samsung Electronics. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY UNIVERSITY OF SZEGED ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL UNIVERSITY OF SZEGED OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "Options.h"
+
+#include <string.h>
+
+namespace WTR {
+
+Options::Options(double defaultLongTimeout, double defaultShortTimeout)
+    : longTimeout(defaultLongTimeout)
+    , shortTimeout(defaultShortTimeout)
+    , useWaitToDumpWatchdogTimer(true)
+    , forceNoTimeout(false)
+    , verbose(false)
+    , gcBetweenTests(false)
+    , shouldDumpPixelsForAllTests(false)
+    , printSupportedFeatures(false)
+    , forceComplexText(false)
+    , shouldUseAcceleratedDrawing(false)
+    , shouldUseRemoteLayerTree(false)
+    , defaultLongTimeout(defaultLongTimeout)
+    , defaultShortTimeout(defaultShortTimeout)
+{
+}
+
+bool handleOptionTimeout(Options& options, const char*, const char* argument)
+{
+    options.longTimeout = atoi(argument);
+    // Scale up the short timeout to match.
+    options.shortTimeout = options.defaultShortTimeout * options.longTimeout / options.defaultLongTimeout;
+    return true;
+}
+
+bool handleOptionNoTimeout(Options& options, const char*, const char*)
+{
+    options.useWaitToDumpWatchdogTimer = false;
+    return true;
+}
+
+bool handleOptionNoTimeoutAtAll(Options& options, const char*, const char*)
+{
+    options.useWaitToDumpWatchdogTimer = false;
+    options.forceNoTimeout = true;
+    return true;
+}
+
+bool handleOptionVerbose(Options& options, const char*, const char*)
+{
+    options.verbose = true;
+    return true;
+}
+
+bool handleOptionGcBetweenTests(Options& options, const char*, const char*)
+{
+    options.gcBetweenTests = true;
+    return true;
+}
+
+bool handleOptionPixelTests(Options& options, const char*, const char*)
+{
+    options.shouldDumpPixelsForAllTests = true;
+    return true;
+}
+
+bool handleOptionPrintSupportedFeatures(Options& options, const char*, const char*)
+{
+    options.printSupportedFeatures = true;
+    return true;
+}
+
+bool handleOptionComplexText(Options& options, const char*, const char*)
+{
+    options.forceComplexText = true;
+    return true;
+}
+
+bool handleOptionAcceleratedDrawing(Options& options, const char*, const char*)
+{
+    options.shouldUseAcceleratedDrawing = true;
+    return true;
+}
+
+bool handleOptionRemoteLayerTree(Options& options, const char*, const char*)
+{
+    options.shouldUseRemoteLayerTree = true;
+    return true;
+}
+
+bool handleOptionUnmatched(Options& options, const char* option, const char*)
+{
+    if (option[0] && option[1] && option[0] == '-' && option[1] == '-')
+        return true;
+    options.paths.push_back(option);
+    return true;
+}
+
+OptionsHandler::OptionsHandler(Options& o)
+    : options(o)
+{
+    optionList.append(Option("--timeout", "Sets long timeout to <param> and scales short timeout.", handleOptionTimeout, true));
+    optionList.append(Option("--no-timeout", "Disables timeout.", handleOptionNoTimeout));
+    optionList.append(Option("--no-timeout-at-all", "Disables all timeouts.", handleOptionNoTimeoutAtAll));
+    optionList.append(Option("--verbose", "Turns on messages.", handleOptionVerbose));
+    optionList.append(Option("--gc-between-tests", "Garbage collection between tests.", handleOptionGcBetweenTests));
+    optionList.append(Option("--pixel-tests", "Check pixels.", handleOptionPixelTests));
+    optionList.append(Option("-p", "Check pixels.", handleOptionPixelTests));
+    optionList.append(Option("--print-supported-features", "For DumpRenderTree compatibility.", handleOptionPrintSupportedFeatures));
+    optionList.append(Option("--complex-text", "Force complex tests.", handleOptionComplexText));
+    optionList.append(Option("--accelerated-drawing", "Use accelerated drawing.", handleOptionAcceleratedDrawing));
+    optionList.append(Option("--remote-layer-tree", "Use remote layer tree.", handleOptionRemoteLayerTree));
+    optionList.append(Option(0, 0, handleOptionUnmatched));
+}
+
+const char * OptionsHandler::usage = "Usage: WebKitTestRunner [options] filename [filename2..n]";
+const char * OptionsHandler::help = "Displays this help.";
+
+Option::Option(const char* name, const char* description, std::function<bool(Options&, const char*, const char*)> parameterHandler, bool hasArgument)
+    : name(name), description(description), parameterHandler(parameterHandler), hasArgument(hasArgument) { };
+
+bool Option::matches(const char* option)
+{
+    return !name || !strcmp(name, option);
+}
+
+bool OptionsHandler::parse(int argc, const char* argv[])
+{
+    bool status = true;
+    for (int argCounter = 1; argCounter < argc; ++argCounter) {
+        if (!strcmp(argv[argCounter], "--help") || !strcmp(argv[argCounter], "-h")) {
+            printHelp();
+            return false;
+        }
+        const char* currentOption = argv[argCounter];
+        for (Option& option : optionList) {
+            if (option.matches(currentOption)) {
+                if (!option.parameterHandler)
+                    status = false;
+                else if (option.hasArgument) {
+                    const char * currentArgument = argv[++argCounter];
+                    if (currentArgument)
+                        status &= option.parameterHandler(options, currentOption, currentArgument);
+                    else
+                        status = false;
+                } else
+                    status &= option.parameterHandler(options, currentOption, 0);
+                break;
+            }
+        }
+    }
+    return status;
+}
+
+void OptionsHandler::printHelp(FILE* channel)
+{
+    fputs(usage, channel);
+    fputs("\n\n    -h|--help\n\t", channel);
+    fputs(help, channel);
+    fputs("\n\n", channel);
+    for (Option& option : optionList) {
+        if (!option.name)
+            continue;
+        fputs("    ", channel);
+        fputs(option.name, channel);
+        fputs((option.hasArgument ? " <param>\n\t" : "\n\t"), channel);
+        fputs(option.description, channel);
+        fputs("\n\n", channel);
+    }
+}
+
+} // namespace WTR
diff --git a/Tools/WebKitTestRunner/Options.h b/Tools/WebKitTestRunner/Options.h
new file mode 100644 (file)
index 0000000..a89d25c
--- /dev/null
@@ -0,0 +1,80 @@
+/*
+ * Copyright (C) 2013 University of Szeged. All rights reserved.
+ * Copyright (C) 2013 Samsung Electronics. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY UNIVERSITY OF SZEGED ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL UNIVERSITY OF SZEGED OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef Options_h
+#define Options_h
+
+#include <functional>
+#include <stdio.h>
+#include <string>
+#include <vector>
+#include <wtf/Vector.h>
+
+namespace WTR {
+
+struct Options {
+    Options(double, double);
+    double longTimeout;
+    double shortTimeout;
+    bool useWaitToDumpWatchdogTimer;
+    bool forceNoTimeout;
+    bool verbose;
+    bool gcBetweenTests;
+    bool shouldDumpPixelsForAllTests;
+    bool printSupportedFeatures;
+    bool forceComplexText;
+    bool shouldUseAcceleratedDrawing;
+    bool shouldUseRemoteLayerTree;
+    std::vector<std::string> paths;
+    double defaultLongTimeout;
+    double defaultShortTimeout;
+};
+
+class Option {
+public:
+    Option(const char* name, const char* description, std::function<bool(Options&, const char*, const char*)> parameterHandler, bool hasArgument = false);
+    bool matches(const char*);
+    const char* name;
+    const char* description;
+    std::function<bool(Options&, const char*, const char*)> parameterHandler;
+    bool hasArgument;
+};
+
+class OptionsHandler {
+public:
+    explicit OptionsHandler(Options&);
+    bool parse(int argc, const char* argv[]);
+    void printHelp(FILE* channel = stderr);
+private:
+    Vector<Option> optionList;
+    Options& options;
+    static const char* usage;
+    static const char* help;
+};
+
+} // namespace WTR
+
+#endif // Options_h
index 21c0036..0634462 100644 (file)
@@ -27,6 +27,7 @@
 #include "TestController.h"
 
 #include "EventSenderProxy.h"
+#include "Options.h"
 #include "PlatformWebView.h"
 #include "StringFunctions.h"
 #include "TestInvocation.h"
@@ -266,74 +267,29 @@ void TestController::initialize(int argc, const char* argv[])
 {
     platformInitialize();
 
+    Options options(defaultLongTimeout, defaultShortTimeout);
+    OptionsHandler optionsHandler(options);
+
     if (argc < 2) {
-        fputs("Usage: WebKitTestRunner [options] filename [filename2..n]\n", stderr);
-        // FIXME: Refactor option parsing to allow us to print
-        // an auto-generated list of options.
+        optionsHandler.printHelp();
         exit(1);
     }
+    if (!optionsHandler.parse(argc, argv))
+        exit(1);
 
-    bool printSupportedFeatures = false;
-
-    for (int i = 1; i < argc; ++i) {
-        std::string argument(argv[i]);
-
-        if (argument == "--timeout" && i + 1 < argc) {
-            m_longTimeout = atoi(argv[++i]);
-            // Scale up the short timeout to match.
-            m_shortTimeout = defaultShortTimeout * m_longTimeout / defaultLongTimeout;
-            continue;
-        }
-
-        if (argument == "--no-timeout") {
-            m_useWaitToDumpWatchdogTimer = false;
-            continue;
-        }
-
-        if (argument == "--no-timeout-at-all") {
-            m_useWaitToDumpWatchdogTimer = false;
-            m_forceNoTimeout = true;
-            continue;
-        }
-
-        if (argument == "--verbose") {
-            m_verbose = true;
-            continue;
-        }
-        if (argument == "--gc-between-tests") {
-            m_gcBetweenTests = true;
-            continue;
-        }
-        if (argument == "--pixel-tests" || argument == "-p") {
-            m_shouldDumpPixelsForAllTests = true;
-            continue;
-        }
-        if (argument == "--print-supported-features") {
-            printSupportedFeatures = true;
-            break;
-        }
-        if (argument == "--complex-text") {
-            m_forceComplexText = true;
-            continue;
-        }
-        if (argument == "--accelerated-drawing") {
-            m_shouldUseAcceleratedDrawing = true;
-            continue;
-        }
-        if (argument == "--remote-layer-tree") {
-            m_shouldUseRemoteLayerTree = true;
-            continue;
-        }
-
-
-        // Skip any other arguments that begin with '--'.
-        if (argument.length() >= 2 && argument[0] == '-' && argument[1] == '-')
-            continue;
-
-        m_paths.push_back(argument);
-    }
-
-    if (printSupportedFeatures) {
+    m_longTimeout = options.longTimeout;
+    m_shortTimeout = options.shortTimeout;
+    m_useWaitToDumpWatchdogTimer = options.useWaitToDumpWatchdogTimer;
+    m_forceNoTimeout = options.forceNoTimeout;
+    m_verbose = options.verbose;
+    m_gcBetweenTests = options.gcBetweenTests;
+    m_shouldDumpPixelsForAllTests = options.shouldDumpPixelsForAllTests;
+    m_forceComplexText = options.forceComplexText;
+    m_shouldUseAcceleratedDrawing = options.shouldUseAcceleratedDrawing;
+    m_shouldUseRemoteLayerTree = options.shouldUseRemoteLayerTree;
+    m_paths = options.paths;
+
+    if (options.printSupportedFeatures) {
         // FIXME: On Windows, DumpRenderTree uses this to expose whether it supports 3d
         // transforms and accelerated compositing. When we support those features, we
         // should match DRT's behavior.
index 0df9921..9b37fec 100644 (file)
@@ -59,6 +59,7 @@
                65EB85A011EC67CC0034D300 /* ActivateFonts.mm in Sources */ = {isa = PBXBuildFile; fileRef = 65EB859F11EC67CC0034D300 /* ActivateFonts.mm */; };
                8034C6621487636400AC32E9 /* AccessibilityControllerMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 8034C6611487636400AC32E9 /* AccessibilityControllerMac.mm */; };
                8097338A14874A5A008156D9 /* AccessibilityNotificationHandler.mm in Sources */ = {isa = PBXBuildFile; fileRef = 8097338914874A5A008156D9 /* AccessibilityNotificationHandler.mm */; };
+               841CC00F181185BF0042E9B6 /* Options.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 841CC00D181185BF0042E9B6 /* Options.cpp */; };
                8CCDA823151A570B0003F937 /* SampleFont.sfont in Resources */ = {isa = PBXBuildFile; fileRef = 8CCDA822151A570B0003F937 /* SampleFont.sfont */; };
                A664BC7613A5F3A9009A7B25 /* libWebCoreTestSupport.dylib in Frameworks */ = {isa = PBXBuildFile; fileRef = 41230E16138C78BF00BCCFCA /* libWebCoreTestSupport.dylib */; };
                BC14E4DB120E02D000826C0C /* GCController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC14E4D9120E02D000826C0C /* GCController.cpp */; };
                8034C6611487636400AC32E9 /* AccessibilityControllerMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = AccessibilityControllerMac.mm; path = mac/AccessibilityControllerMac.mm; sourceTree = "<group>"; };
                8097338814874A5A008156D9 /* AccessibilityNotificationHandler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AccessibilityNotificationHandler.h; path = mac/AccessibilityNotificationHandler.h; sourceTree = "<group>"; };
                8097338914874A5A008156D9 /* AccessibilityNotificationHandler.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = AccessibilityNotificationHandler.mm; path = mac/AccessibilityNotificationHandler.mm; sourceTree = "<group>"; };
+               841CC00D181185BF0042E9B6 /* Options.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Options.cpp; sourceTree = "<group>"; };
+               841CC00E181185BF0042E9B6 /* Options.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Options.h; sourceTree = "<group>"; };
                8CCDA822151A570B0003F937 /* SampleFont.sfont */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xml; name = SampleFont.sfont; path = fonts/SampleFont.sfont; sourceTree = "<group>"; };
                8DD76FA10486AA7600D96B5E /* WebKitTestRunner */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path = WebKitTestRunner; sourceTree = BUILT_PRODUCTS_DIR; };
                BC14E4D8120E02D000826C0C /* GCController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GCController.h; sourceTree = "<group>"; };
                08FB7795FE84155DC02AAC07 /* TestRunner */ = {
                        isa = PBXGroup;
                        children = (
+                               841CC00D181185BF0042E9B6 /* Options.cpp */,
+                               841CC00E181185BF0042E9B6 /* Options.h */,
                                BC9192021333E4CD003011DC /* cg */,
                                BC7933FE118F7C74005EA8E2 /* mac */,
                                5322FB4113FDA0CD0041ABCC /* CyclicRedundancyCheck.cpp */,
                                E132AA3A17CD5F1000611DF0 /* WebKitTestRunnerDraggingInfo.mm in Sources */,
                                3164C8F015D1ADA100EF1FE0 /* WebNotificationProvider.cpp in Sources */,
                                4429FC5F1627089600F66D8B /* WorkQueueManager.cpp in Sources */,
+                               841CC00F181185BF0042E9B6 /* Options.cpp in Sources */,
                        );
                        runOnlyForDeploymentPostprocessing = 0;
                };