WebDriver: test imported/selenium/py/test/selenium/webdriver/common/api_example_tests...
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 23 Jan 2018 09:43:46 +0000 (09:43 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 23 Jan 2018 09:43:46 +0000 (09:43 +0000)
https://bugs.webkit.org/show_bug.cgi?id=181728

Reviewed by Sergio Villar Senin.

Source/WebDriver:

Due to a copy-paste error we are getting the window height using the width variable.

Fixes: imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize
       imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py::testShouldScrollPageAndGetCoordinatesOfAnElementThatIsOutOfViewPort
       imported/w3c/webdriver/tests/get_window_rect.py::test_payload
       imported/w3c/webdriver/tests/set_window_rect.py::test_width_height_floats
       imported/w3c/webdriver/tests/set_window_rect.py::test_height_width
       imported/w3c/webdriver/tests/set_window_rect.py::test_height_width_larger_than_max
       imported/w3c/webdriver/tests/contexts/resizing_and_positioning.py::test_window_resize

* Session.cpp:
(WebDriver::Session::getToplevelBrowsingContextRect):

WebDriverTests:

Remove expectations for tests that are now passing.

* TestExpectations.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@227408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebDriver/ChangeLog
Source/WebDriver/Session.cpp
WebDriverTests/ChangeLog
WebDriverTests/TestExpectations.json

index 350fd81..6818cc4 100644 (file)
@@ -1,3 +1,23 @@
+2018-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        WebDriver: test imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize fails
+        https://bugs.webkit.org/show_bug.cgi?id=181728
+
+        Reviewed by Sergio Villar Senin.
+
+        Due to a copy-paste error we are getting the window height using the width variable.
+
+        Fixes: imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize
+               imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py::testShouldScrollPageAndGetCoordinatesOfAnElementThatIsOutOfViewPort
+               imported/w3c/webdriver/tests/get_window_rect.py::test_payload
+               imported/w3c/webdriver/tests/set_window_rect.py::test_width_height_floats
+               imported/w3c/webdriver/tests/set_window_rect.py::test_height_width
+               imported/w3c/webdriver/tests/set_window_rect.py::test_height_width_larger_than_max
+               imported/w3c/webdriver/tests/contexts/resizing_and_positioning.py::test_window_resize
+
+        * Session.cpp:
+        (WebDriver::Session::getToplevelBrowsingContextRect):
+
 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         WebDriver: implement get element CSS value command
index 1a4240a..6a1abc4 100644 (file)
@@ -698,7 +698,7 @@ void Session::getToplevelBrowsingContextRect(Function<void (CommandResult&&)>&&
         double width, height;
         if (!browsingContext->getObject(ASCIILiteral("windowSize"), windowSize)
             || !windowSize->getDouble(ASCIILiteral("width"), width)
-            || !windowSize->getDouble(ASCIILiteral("height"), width)) {
+            || !windowSize->getDouble(ASCIILiteral("height"), height)) {
             completionHandler(CommandResult::fail(CommandResult::ErrorCode::UnknownError));
             return;
         }
index 0fb5dec..3a076b2 100644 (file)
@@ -1,3 +1,14 @@
+2018-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        WebDriver: test imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize fails
+        https://bugs.webkit.org/show_bug.cgi?id=181728
+
+        Reviewed by Sergio Villar Senin.
+
+        Remove expectations for tests that are now passing.
+
+        * TestExpectations.json:
+
 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         WebDriver: implement get element CSS value command
index acb079b..bd17506 100644 (file)
@@ -11,9 +11,6 @@
     },
     "imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py": {
         "subtests": {
-            "testChangeWindowSize": {
-                "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/181728"}}
-            },
             "testGetLogTypes": {
                 "expected": {"all": {"status": ["SKIP"]}}
             },
@@ -75,9 +72,6 @@
     },
     "imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py": {
         "subtests": {
-            "testShouldScrollPageAndGetCoordinatesOfAnElementThatIsOutOfViewPort": {
-                "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/181734"}}
-            },
             "testShouldGetCoordinatesOfAnElementInAFrame": {
                 "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/181735"}}
             },
     "imported/w3c/webdriver/tests/actions/special_keys.py": {
         "expected": {"all": {"status": ["SKIP"], "bug": "webkit.org/b/174616"}}
     },
-    "imported/w3c/webdriver/tests/contexts/resizing_and_positioning.py": {
-        "subtests": {
-            "test_window_resize": {
-                "expected": {"gtk": {"status": ["FAIL"]}}
-            }
-        }
-    },
     "imported/w3c/webdriver/tests/contexts/maximize_window.py": {
         "subtests": {
             "test_no_browsing_context": {
     },
     "imported/w3c/webdriver/tests/set_window_rect.py": {
         "subtests": {
-            "test_width_height_floats": {
-                "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180416"}}
-            },
             "test_fully_exit_fullscreen": {
                 "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180398"}}
             },
             "test_restore_from_maximized": {
                 "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180398"}}
             },
-            "test_height_width": {
-                "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180417"}}
-            },
-            "test_height_width_larger_than_max": {
-                "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180419"}}
-            },
             "test_negative_x_y": {
                 "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180418"}}
             }