[GTK] Enable IndexedDB
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 May 2015 07:05:03 +0000 (07:05 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 May 2015 07:05:03 +0000 (07:05 +0000)
https://bugs.webkit.org/show_bug.cgi?id=98932

Reviewed by Žan Doberšek.

.:

* Source/cmake/OptionsGTK.cmake: Enable DATABASE_PROCESS and INDEXED_DATABASE.
* Source/cmake/WebKitFeatures.cmake: Add ENABLE_DATABASE_PROCESS.

Tools:

* Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.

LayoutTests:

* platform/gtk/TestExpectations: Update IndexedDB test expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@184850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
Source/cmake/OptionsGTK.cmake
Source/cmake/WebKitFeatures.cmake
Tools/ChangeLog
Tools/Scripts/webkitperl/FeatureList.pm

index 956c5c7..45cd252 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Enable IndexedDB
+        https://bugs.webkit.org/show_bug.cgi?id=98932
+
+        Reviewed by Žan Doberšek.
+
+        * Source/cmake/OptionsGTK.cmake: Enable DATABASE_PROCESS and INDEXED_DATABASE.
+        * Source/cmake/WebKitFeatures.cmake: Add ENABLE_DATABASE_PROCESS.
+
 2015-05-24  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GTK] Bump GCC requirements to 4.9.0
index db6f762..fcb5112 100644 (file)
@@ -1,3 +1,12 @@
+2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Enable IndexedDB
+        https://bugs.webkit.org/show_bug.cgi?id=98932
+
+        Reviewed by Žan Doberšek.
+
+        * platform/gtk/TestExpectations: Update IndexedDB test expectations.
+
 2015-05-24  Jordan Harband  <ljharb@gmail.com>
 
         Array#findIndex/find should not skip holes
index af5dac5..2564de0 100644 (file)
@@ -2033,16 +2033,105 @@ webkit.org/b/107825 media/audio-delete-while-step-button-clicked.html [ Failure
 webkit.org/b/107825 media/nodesFromRect-shadowContent.html [ Failure ]
 webkit.org/b/107825 media/video-controls-fullscreen-volume.html [ Failure ]
 
-# IndexedDB code is going through refactoring/refreshing, so the tests are quite unstable at this point.
-webkit.org/b/107194 storage/indexeddb [ Skip ]
-webkit.org/b/107194 http/tests/security/cross-origin-indexeddb-allowed.html [ Skip ]
-webkit.org/b/107194 http/tests/security/cross-origin-indexeddb.html [ Skip ]
-webkit.org/b/107194 http/tests/security/cross-origin-worker-indexeddb-allowed.html [ Skip ]
-webkit.org/b/107194 http/tests/security/cross-origin-worker-indexeddb.html [ Skip ]
-webkit.org/b/107194 http/tests/security/no-indexeddb-from-sandbox.html [ Skip ]
+## IndexedDB related failures
+
+# Blink tests with unexplained timeouts
+storage/indexeddb/database-deletepending-flag.html [ Skip ]
+storage/indexeddb/exceptions.html [ Skip ]
+storage/indexeddb/intversion-gated-on-delete.html [ Skip ]
+storage/indexeddb/intversion-long-queue.html [ Skip ]
+storage/indexeddb/open-ordering.html [ Skip ]
+storage/indexeddb/transaction-basics.html [ Skip ]
+storage/indexeddb/transaction-coordination-within-database.html [ Skip ]
+
+# Blink tests with non-trivial text failures.
+storage/indexeddb/createIndex-after-failure.html [ Skip ]
+storage/indexeddb/create-object-store-options.html [ Skip ]
+storage/indexeddb/cursor-advance.html [ Skip ]
+storage/indexeddb/cursor-basics.html [ Skip ]
+storage/indexeddb/cursor-continue.html [ Skip ]
+storage/indexeddb/cursor-continue-validity.html [ Skip ]
+storage/indexeddb/cursor-continueprimarykey.html [ Skip ]
+storage/indexeddb/cursor-index-delete.html [ Skip ]
+storage/indexeddb/cursor-key-order.html [ Skip ]
+storage/indexeddb/cursor-leak.html [ Skip ] # Missing needed WKTR feature?
+storage/indexeddb/cursor-overloads.html [ Skip ]
+storage/indexeddb/cursor-primary-key-order.html [ Skip ]
+storage/indexeddb/cursor-request-cycle.html [ Skip ] # Missing needed WKTR feature?
+storage/indexeddb/cursor-update.html [ Skip ]
+storage/indexeddb/data-corruption.html [ Skip ]
+storage/indexeddb/database-close.html [ Skip ]
+storage/indexeddb/database-closepending-flag.html [ Skip ]
+storage/indexeddb/database-quota.html [ Skip ]
+storage/indexeddb/deleteIndex.html [ Skip ]
+storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html [ Skip ]
+storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange.html [ Skip ]
+storage/indexeddb/deletedatabase-blocked.html [ Skip ]
+storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html [ Skip ]
+storage/indexeddb/deletedatabase-delayed-by-versionchange.html [ Skip ]
+storage/indexeddb/deletedatabase-not-blocked.html [ Skip ]
+storage/indexeddb/deleted-objects.html [ Skip ]
+storage/indexeddb/duplicates.html [ Skip ] # Difference between null + undefined
+storage/indexeddb/events.html [ Skip ]
+storage/indexeddb/factory-basics.html [ Skip ] # indexedDB.webkitGetDatabaseNames is missing)
+storage/indexeddb/factory-cmp.html [ Skip ]
+storage/indexeddb/factory-deletedatabase.html [ Skip ]
+storage/indexeddb/get-keyrange.html [ Skip ]
+storage/indexeddb/index-basics.html [ Skip ] # Difference between null + undefined
+storage/indexeddb/index-duplicate-keypaths.html [ Skip ]
+storage/indexeddb/index-multientry.html [ Skip ]
+storage/indexeddb/index-population.html [ Skip ]
+storage/indexeddb/index-unique.html [ Skip ]
+storage/indexeddb/intversion-blocked.html [ Skip ]
+storage/indexeddb/intversion-close-between-events.html [ Skip ]
+storage/indexeddb/intversion-open-in-upgradeneeded.html [ Skip ]
+storage/indexeddb/intversion-open-with-version.html [ Skip ] # INTMAX exposed to script as database version
+storage/indexeddb/intversion-pending-version-changes-ascending.html [ Skip ]
+storage/indexeddb/intversion-pending-version-changes-descending.html [ Skip ]
+storage/indexeddb/intversion-pending-version-changes-same.html [ Skip ]
+storage/indexeddb/intversion-two-opens-no-versions.html [ Skip ] # INTMAX exposed to script as database version
+storage/indexeddb/intversion-upgrades.html [ Skip ]
+storage/indexeddb/key-generator.html [ Skip ]
+storage/indexeddb/key-type-binary.html [ Skip ]
+storage/indexeddb/lazy-index-population.html [ Skip ]
+storage/indexeddb/metadata.html [ Skip ]
+storage/indexeddb/noblobs.html [ Skip ] # Missing DRT file/blob support
+storage/indexeddb/objectstore-autoincrement.html [ Skip ]
+storage/indexeddb/objectstore-basics.html [ Skip ]
+storage/indexeddb/objectstore-keycursor.html [ Skip ]
+storage/indexeddb/odd-strings.html [ Skip ]
+storage/indexeddb/optional-arguments.html [ Skip ]
+storage/indexeddb/persistence.html [ Skip ]
+storage/indexeddb/request-leak.html [ Skip ] # Missing WKTR support? GC?
+storage/indexeddb/setversion-blocked-by-versionchange-close.html [ Skip ]
+storage/indexeddb/setversion-not-blocked.html [ Skip ]
+storage/indexeddb/structured-clone.html [ Skip ] # Missing DRT file/blob support
+storage/indexeddb/transaction-and-objectstore-calls.html [ Skip ]
+storage/indexeddb/transaction-error.html [ Skip ]
+storage/indexeddb/transaction-scope-sequencing.html [ Skip ]
+
+# Blink tests that crash the WebProcess.
+storage/indexeddb/cursor-cast.html [ Skip ]
+
+# We don't currently support indexeddb in workers
+storage/indexeddb/basics-workers.html [ Skip ]
+storage/indexeddb/cursor-advance-workers.html [ Skip ]
+storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers.html [ Skip ]
+storage/indexeddb/dont-commit-on-blocked.html [ Skip ]
+storage/indexeddb/factory-basics-workers.html [ Skip ]
+storage/indexeddb/index-basics-workers.html [ Skip ]
+storage/indexeddb/objectstore-basics-workers.html [ Skip ]
+storage/indexeddb/open-twice-workers.html [ Skip ]
+storage/indexeddb/pending-activity-workers.html [ Skip ]
+storage/indexeddb/pending-version-change-on-exit.html [ Skip ]
+storage/indexeddb/pending-version-change-stuck-works-with-terminate.html [ Skip ]
+storage/indexeddb/pending-version-change-stuck.html [ Skip ]
+storage/indexeddb/transaction-complete-workers.html [ Skip ]
+storage/indexeddb/unprefix-workers.html [ Skip ]
+http/tests/security/cross-origin-worker-indexeddb-allowed.html [ Skip ]
+http/tests/security/cross-origin-worker-indexeddb.html [ Skip ]
+
 webkit.org/b/107194 crypto/subtle/rsa-indexeddb.html [ Skip ]
-webkit.org/b/107194 fast/history/page-cache-indexed-closed-db.html [ Skip ]
-webkit.org/b/107194 fast/history/page-cache-indexed-opened-db.html [ Skip ]
 
 # Test marked in TestExpectations as failing on non-retina displays, passing on GTK port
 webkit.org/b/129113 fast/multicol/newmulticol/clipping.html [ Pass ]
index 1820ed2..d30d053 100644 (file)
@@ -153,6 +153,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CUSTOM_SCHEME_HANDLER PRIVATE OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATABASE_PROCESS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATALIST_ELEMENT PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOWNLOAD_ATTRIBUTE PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA PRIVATE OFF)
@@ -162,7 +163,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD_DEPRECATED PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE PRIVATE OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE_IN_WORKERS PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LEGACY_WEB_AUDIO PRIVATE OFF)
index ee9ecac..80d48a9 100644 (file)
@@ -60,6 +60,7 @@ macro(WEBKIT_OPTION_BEGIN)
     WEBKIT_OPTION_DEFINE(ENABLE_CURSOR_VISIBILITY "Toggle cursor visibility support" PRIVATE OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_CUSTOM_SCHEME_HANDLER "Toggle Custom Scheme Handler support" PRIVATE OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_DASHBOARD_SUPPORT "Toggle dashboard support" PRIVATE OFF)
+    WEBKIT_OPTION_DEFINE(ENABLE_DATABASE_PROCESS "Toggle database process support in WebKit2" PRIVATE OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_DATACUE_VALUE "Toggle datacue value support" PRIVATE OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_DATALIST_ELEMENT "Toggle HTML5 datalist support" PRIVATE OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_DATA_TRANSFER_ITEMS "Toggle HTML5 data transfer items support" PRIVATE OFF)
index c9c1da7..c93a522 100644 (file)
@@ -1,3 +1,12 @@
+2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Enable IndexedDB
+        https://bugs.webkit.org/show_bug.cgi?id=98932
+
+        Reviewed by Žan Doberšek.
+
+        * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
+
 2015-05-24  Sam Weinig  <sam@webkit.org>
 
         Crash when using a removed ScriptMessageHandler
index fb94f95..968ed67 100644 (file)
@@ -262,7 +262,7 @@ my @features = (
       define => "ENABLE_ICONDATABASE", default => !isIOSWebKit(), value => \$icondatabaseSupport },
 
     { option => "indexed-database", desc => "Toggle Indexed Database support",
-      define => "ENABLE_INDEXED_DATABASE", default => 0, value => \$indexedDatabaseSupport },
+      define => "ENABLE_INDEXED_DATABASE", default => isGtk(), value => \$indexedDatabaseSupport },
 
     { option => "input-speech", desc => "Toggle Input Speech support",
       define => "ENABLE_INPUT_SPEECH", default => 0, value => \$inputSpeechSupport },