webkit-queues PatchLog is incorrect for patches that took less than a second
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Oct 2014 19:09:55 +0000 (19:09 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Oct 2014 19:09:55 +0000 (19:09 +0000)
https://bugs.webkit.org/show_bug.cgi?id=137453

Reviewed by Tim Horton.

* QueueStatusServer/app.yaml: Updated app version.

* QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
Don't bail out for patches that took 0 seconds to process (as frequently happens
when a patch is obsolete).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/QueueStatusServer/app.yaml
Tools/QueueStatusServer/loggers/recordpatchevent.py

index 82491c1..b928168 100644 (file)
@@ -1,3 +1,16 @@
+2014-10-06  Alexey Proskuryakov  <ap@apple.com>
+
+        webkit-queues PatchLog is incorrect for patches that took less than a second
+        https://bugs.webkit.org/show_bug.cgi?id=137453
+
+        Reviewed by Tim Horton.
+
+        * QueueStatusServer/app.yaml: Updated app version.
+
+        * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
+        Don't bail out for patches that took 0 seconds to process (as frequently happens
+        when a patch is obsolete).
+
 2014-10-06  Csaba Osztrogon√°c  <ossy@webkit.org>
 
         EWS bubble hover shows wrong timestamps
index 31645d9..3a5b866 100644 (file)
@@ -1,5 +1,5 @@
 application: webkit-queues
-version: 174304 # Bugzilla bug ID of last major change
+version: 174357 # SVN revision of last major change
 runtime: python
 api_version: 1
 
index b76cd58..b6f0f3b 100644 (file)
@@ -75,7 +75,7 @@ class RecordPatchEvent(object):
             WarningLog.record("patchlog missing", "In stopped event.", attachment_id, queue_name, bot_id)
             return
 
-        if not patch_log.wait_duration:
+        if patch_log.wait_duration is None:
             WarningLog.record("patchlog wait duration missing", "In stopped event.", attachment_id, queue_name, bot_id)
             return