[GTK] Enable some of the unstable CSS features
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 26 Sep 2012 07:38:12 +0000 (07:38 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 26 Sep 2012 07:38:12 +0000 (07:38 +0000)
https://bugs.webkit.org/show_bug.cgi?id=97572

Reviewed by Martin Robinson.

.:

Export the required RuntimeEnabledFeatures symbol.

* Source/autotools/symbols.filter:

Source/WebCore:

Enable the CSS sticky position, CSS3 text decoration and <style scoped>
features by default but disable them if unstable features are not meant
to be enabled.

No new tests - the related tests are being unskipped or are having failure
expectations removed.

* GNUmakefile.am:
* GNUmakefile.features.am:

Source/WebKit/gtk:

Add a helper DumpRenderTreeSupportGtk method for enabling
the <style scoped> support in WebCore. This is used in DumpRenderTree.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setShadowDOMEnabled): Add missing
ENABLE(SHADOW_DOM) compilation guards.
(DumpRenderTreeSupportGtk::setStyleScopedEnabled):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk): Remove the 'enabled' parameter name from both
setShadowDOMEnabled and setStyleScopedEnabled method declarations as it adds
no information and is causing style warnings.

Tools:

Enable the <style scoped> support via DumpRenderTreeSupportGtk method
whenever resetting defualts to consistent values.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):

LayoutTests:

Remove expectations for the features being enabled and
add more specific failure expectations for tests that are
still failing.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 files changed:
ChangeLog
LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/GNUmakefile.am
Source/WebCore/GNUmakefile.features.am
Source/WebKit/gtk/ChangeLog
Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp
Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h
Source/autotools/symbols.filter
Tools/ChangeLog
Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

index 9f9624d..62b0cd5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2012-09-26  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Enable some of the unstable CSS features
+        https://bugs.webkit.org/show_bug.cgi?id=97572
+
+        Reviewed by Martin Robinson.
+
+        Export the required RuntimeEnabledFeatures symbol.
+
+        * Source/autotools/symbols.filter:
+
 2012-09-25  Cosmin Truta  <ctruta@rim.com>
 
         [BlackBerry] Enable LLInt
index db15587..a9e82ba 100644 (file)
@@ -1,3 +1,16 @@
+2012-09-26  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Enable some of the unstable CSS features
+        https://bugs.webkit.org/show_bug.cgi?id=97572
+
+        Reviewed by Martin Robinson.
+
+        Remove expectations for the features being enabled and
+        add more specific failure expectations for tests that are
+        still failing.
+
+        * platform/gtk/TestExpectations:
+
 2012-09-26  Gavin Barraclough  <barraclough@apple.com>
 
         String.localeCompare should normalize input
index 7cc452b..2588642 100644 (file)
@@ -299,15 +299,6 @@ Bug(GTK) http/tests/security/webgl-remote-read-remote-image-allowed.html [ Skip
 Bug(GTK) http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html [ Skip ]
 Bug(GTK) http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html [ Skip ]
 
-# <style scoped> is not yet enabled.
-webkit.org/b/49142 fast/css/style-scoped [ Failure ]
-
-# CSS Regions tests for region styling and scoped styles
-Bug(GTK) fast/regions/style-scoped-in-flow-override-container-style.html [ ImageOnlyFailure ]
-Bug(GTK) fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html [ ImageOnlyFailure ]
-Bug(GTK) fast/regions/style-scoped-in-flow-override-region-styling.html [ ImageOnlyFailure ]
-Bug(GTK) fast/regions/style-scoped-in-flow.html [ ImageOnlyFailure ]
-
 # CSS Filters is disabled
 Bug(GTK) css3/filters [ Skip ]
 
@@ -319,9 +310,6 @@ Bug(GTK) fast/css/image-set-parsing.html [ Skip ]
 Bug(GTK) fast/css/image-set-parsing-invalid.html [ Skip ]
 Bug(GTK) fast/css/image-set-setting.html [ Skip ]
 
-# CSS Sticky Position is not yet enabled
-Bug(GTK) fast/css/sticky [ Skip ]
-
 # For now, Web Audio API is disabled
 Bug(GTK) webaudio [ Skip ]
 
@@ -402,9 +390,6 @@ webkit.org/b/85262 fast/css/image-resolution [ Skip ]
 # CSS image-orientation is not yet enabled.
 webkit.org/b/89052 fast/css/image-orientation
 
-# CSS3 Text Decoration support is not yet enabled (needs ENABLE_CSS3_TEXT_DECORATION).
-webkit.org/b/58491 fast/css3-text-decoration
-
 # No CORS support for media elements is implemented yet.
 Bug(GTK) http/tests/security/video-cross-origin-readback.html [ Skip ]
 
@@ -1210,6 +1195,8 @@ webkit.org/b/84694 fast/events/selectstart-by-double-triple-clicks.html [ Failur
 webkit.org/b/84692 fast/events/attempt-scroll-with-no-scrollbars.html [ Failure ]
 
 webkit.org/b/84701 fast/block/line-layout/selection-highlight-overlap.html [ ImageOnlyFailure ]
+webkit.org/b/84701 fast/css/sticky/inline-sticky-abspos-child.html [ ImageOnlyFailure ]
+webkit.org/b/84701 fast/css/sticky/inline-sticky.html [ ImageOnlyFailure ]
 
 webkit.org/b/85376 fullscreen/video-controls-drag.html [ Failure ]
 
@@ -1304,9 +1291,6 @@ webkit.org/b/88684 fast/text/descent-clip-in-scaled-page.html [ ImageOnlyFailure
 # This failure appears to be GTK-specific
 webkit.org/b/91319 css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ]
 
-# Failing after r123379 on EFL and GTK.
-webkit.org/b/92063 fast/css/sticky/parsing-position-sticky.html [ Failure ]
-
 webkit.org/b/92100 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
 
 # These tests depend on subpixel layout.
@@ -1371,6 +1355,8 @@ webkit.org/b/91489 fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html [ Ima
 
 webkit.org/b/97529 http/tests/security/xss-eval.html [ Failure ]
 
+webkit.org/b/49142 fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html [ ImageOnlyFailure ]
+
 #////////////////////////////////////////////////////////////////////////////////////////
 # End of Tests failing
 #////////////////////////////////////////////////////////////////////////////////////////
index c26b08f..3a79c80 100644 (file)
@@ -1,3 +1,20 @@
+2012-09-26  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Enable some of the unstable CSS features
+        https://bugs.webkit.org/show_bug.cgi?id=97572
+
+        Reviewed by Martin Robinson.
+
+        Enable the CSS sticky position, CSS3 text decoration and <style scoped>
+        features by default but disable them if unstable features are not meant
+        to be enabled.
+
+        No new tests - the related tests are being unskipped or are having failure
+        expectations removed.
+
+        * GNUmakefile.am:
+        * GNUmakefile.features.am:
+
 2012-09-26  Dongwoo Joshua Im  <dw.im@samsung.com>
 
         Fix potential build error on LocalFileSystem::deleteFileSystem
index cfd3f8f..f05669d 100644 (file)
@@ -348,8 +348,11 @@ endif  # END ENABLE_SPELLCHECK
 # ---
 if !ENABLE_UNSTABLE_FEATURES
 feature_defines_unstable += \
-       ENABLE_MUTATION_OBSERVERS=0 \
+       ENABLE_CSS3_TEXT_DECORATION=0 \
+       ENABLE_CSS_STICKY_POSITION=0 \
        ENABLE_LINK_PREFETCH=0 \
+       ENABLE_MUTATION_OBSERVERS=0 \
+       ENABLE_STYLE_SCOPED=0 \
        ENABLE_VIDEO_TRACK=0 \
        ENABLE_WEB_TIMING=0
 endif
index 75aea95..89555bf 100644 (file)
@@ -6,6 +6,7 @@ feature_defines_defaults += \
        ENABLE_BLOB=1 \
        ENABLE_CHANNEL_MESSAGING=1 \
        ENABLE_CSP_NEXT=0 \
+       ENABLE_CSS3_TEXT_DECORATION=1 \
        ENABLE_CSS_BOX_DECORATION_BREAK=1 \
        ENABLE_CSS_COMPOSITING=0 \
        ENABLE_CSS_EXCLUSIONS=1 \
@@ -15,6 +16,7 @@ feature_defines_defaults += \
        ENABLE_CSS_IMAGE_RESOLUTION=0 \
        ENABLE_CSS_REGIONS=1 \
        ENABLE_CSS_SHADERS=0 \
+       ENABLE_CSS_STICKY_POSITION=1 \
        ENABLE_CSS_VARIABLES=0 \
        ENABLE_CUSTOM_SCHEME_HANDLER=0 \
        ENABLE_DASHBOARD_SUPPORT=0 \
@@ -76,7 +78,7 @@ feature_defines_defaults += \
        ENABLE_SMOOTH_SCROLLING=1 \
        ENABLE_SPELLCHECK=1 \
        ENABLE_SQL_DATABASE=1 \
-       ENABLE_STYLE_SCOPED=0 \
+       ENABLE_STYLE_SCOPED=1 \
        ENABLE_SVG=1 \
        ENABLE_SVG_DOM_OBJC_BINDINGS=0 \
        ENABLE_SVG_FONTS=1 \
index 8d5fe7a..cef16d1 100644 (file)
@@ -1,3 +1,22 @@
+2012-09-26  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Enable some of the unstable CSS features
+        https://bugs.webkit.org/show_bug.cgi?id=97572
+
+        Reviewed by Martin Robinson.
+
+        Add a helper DumpRenderTreeSupportGtk method for enabling
+        the <style scoped> support in WebCore. This is used in DumpRenderTree.
+
+        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+        (DumpRenderTreeSupportGtk::setShadowDOMEnabled): Add missing
+        ENABLE(SHADOW_DOM) compilation guards.
+        (DumpRenderTreeSupportGtk::setStyleScopedEnabled):
+        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
+        (DumpRenderTreeSupportGtk): Remove the 'enabled' parameter name from both
+        setShadowDOMEnabled and setStyleScopedEnabled method declarations as it adds
+        no information and is causing style warnings.
+
 2012-09-25  Beth Dakin  <bdakin@apple.com>
 
         https://bugs.webkit.org/show_bug.cgi?id=95397
index b39d5ae..ba50534 100644 (file)
@@ -693,7 +693,16 @@ void DumpRenderTreeSupportGtk::setCSSRegionsEnabled(WebKitWebView* webView, bool
 
 void DumpRenderTreeSupportGtk::setShadowDOMEnabled(bool enabled)
 {
+#if ENABLE(SHADOW_DOM)
     RuntimeEnabledFeatures::setShadowDOMEnabled(enabled);
+#endif
+}
+
+void DumpRenderTreeSupportGtk::setStyleScopedEnabled(bool enabled)
+{
+#if ENABLE(STYLE_SCOPED)
+    RuntimeEnabledFeatures::setStyleScopedEnabled(enabled);
+#endif
 }
 
 bool DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId(WebKitWebFrame* frame, JSStringRef id)
index 44ac783..3f7087c 100644 (file)
@@ -118,7 +118,8 @@ public:
     static void setPageCacheSupportsPlugins(WebKitWebView*, bool enabled);
     static void setCSSGridLayoutEnabled(WebKitWebView*, bool enabled);
     static void setCSSRegionsEnabled(WebKitWebView*, bool enabled);
-    static void setShadowDOMEnabled(bool enabled);
+    static void setShadowDOMEnabled(bool);
+    static void setStyleScopedEnabled(bool);
 
     static void deliverAllMutationsIfNecessary();
     static void setDomainRelaxationForbiddenForURLScheme(bool forbidden, const char* urlScheme);
index 49676cf..08df6c8 100644 (file)
@@ -184,6 +184,7 @@ _ZN7WebCore22RuntimeEnabledFeatures22isCSSExclusionsEnabledE;
 _ZN7WebCore22RuntimeEnabledFeatures40isLangAttributeAwareFormControlUIEnabledE;
 _ZN7WebCore22RuntimeEnabledFeatures22isDialogElementEnabledE;
 _ZN7WebCore22RuntimeEnabledFeatures37isAuthorShadowDOMForAnyElementEnabledE;
+_ZN7WebCore22RuntimeEnabledFeatures20isStyleScopedEnabledE;
 _ZNK7WebCore8Document13nodesFromRectEiijjjjbb;
 _ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_8NodeListE;
 _ZNK7WebCore6Editor26selectionStartHasMarkerForENS_14DocumentMarker10MarkerTypeEii;
index fe52caf..59e2e2f 100644 (file)
@@ -1,5 +1,18 @@
 2012-09-26  Zan Dobersek  <zandobersek@gmail.com>
 
+        [GTK] Enable some of the unstable CSS features
+        https://bugs.webkit.org/show_bug.cgi?id=97572
+
+        Reviewed by Martin Robinson.
+
+        Enable the <style scoped> support via DumpRenderTreeSupportGtk method
+        whenever resetting defualts to consistent values.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (resetDefaultsToConsistentValues):
+
+2012-09-26  Zan Dobersek  <zandobersek@gmail.com>
+
         REGRESSION (r126189): No more mismatch-did-not-occur failures in reftests
         https://bugs.webkit.org/show_bug.cgi?id=97112
 
index d5d4f2e..1f96622 100644 (file)
@@ -517,6 +517,7 @@ static void resetDefaultsToConsistentValues()
     DumpRenderTreeSupportGtk::setCSSGridLayoutEnabled(webView, false);
     DumpRenderTreeSupportGtk::setCSSRegionsEnabled(webView, true);
     DumpRenderTreeSupportGtk::setShadowDOMEnabled(true);
+    DumpRenderTreeSupportGtk::setStyleScopedEnabled(true);
 }
 
 static bool useLongRunningServerMode(int argc, char *argv[])