Regression(r181257): WTF_WorkQueue.Simple is flaky
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 11 Mar 2015 02:52:21 +0000 (02:52 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 11 Mar 2015 02:52:21 +0000 (02:52 +0000)
https://bugs.webkit.org/show_bug.cgi?id=142560

Unreviewed attempt to improve test stability.

* TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
the WorkQueue a little later to redue flakiness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp

index d362ab4..85bffd2 100644 (file)
@@ -1,3 +1,13 @@
+2015-03-10  Brent Fulgham  <bfulgham@apple.com>
+
+        Regression(r181257): WTF_WorkQueue.Simple is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=142560
+
+        Unreviewed attempt to improve test stability.
+
+        * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
+        the WorkQueue a little later to redue flakiness.
+
 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
 
         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
index 4f52dba..6df58c2 100644 (file)
@@ -84,11 +84,10 @@ TEST(WTF_WorkQueue, Simple)
 
     m_testCompleted.wait(m_lock);
 
-    EXPECT_EQ(1, queue->refCount());
-
     EXPECT_TRUE(calledSimpleTest);
     EXPECT_TRUE(calledLongTest);
     EXPECT_TRUE(calledThirdTest);
+    EXPECT_EQ(1, queue->refCount());
 
     EXPECT_EQ(static_cast<size_t>(3), m_functionCallOrder.size());
     EXPECT_STREQ(simpleTestLabel, m_functionCallOrder[0].c_str());