[Cocoa] clang emits a warning when building WebKit after r238293
authorwenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 Nov 2018 04:00:31 +0000 (04:00 +0000)
committerwenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 Nov 2018 04:00:31 +0000 (04:00 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191917

Reviewed by Dan Bernstein.

Move the implementations of -setSafeBrowsingEnabled: and -isSafeBrowsingEnabled to the main implementation of
WKPreferences to fix the warning.

* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences setSafeBrowsingEnabled:]):
(-[WKPreferences isSafeBrowsingEnabled]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm

index e6fe8c1..5ca4e29 100644 (file)
@@ -1,5 +1,19 @@
 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
 
+        [Cocoa] clang emits a warning when building WebKit after r238293
+        https://bugs.webkit.org/show_bug.cgi?id=191917
+
+        Reviewed by Dan Bernstein.
+
+        Move the implementations of -setSafeBrowsingEnabled: and -isSafeBrowsingEnabled to the main implementation of
+        WKPreferences to fix the warning.
+
+        * UIProcess/API/Cocoa/WKPreferences.mm:
+        (-[WKPreferences setSafeBrowsingEnabled:]):
+        (-[WKPreferences isSafeBrowsingEnabled]):
+
+2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
+
         Address post-review feedback after r238438
         https://bugs.webkit.org/show_bug.cgi?id=191913
 
index 6dbdca6..eda9c81 100644 (file)
     _preferences->setStorageAccessPromptsEnabled(enabled);
 }
 
+- (void)setSafeBrowsingEnabled:(BOOL)enabled
+{
+    _preferences->setSafeBrowsingEnabled(enabled);
+}
+
+- (BOOL)isSafeBrowsingEnabled
+{
+    return _preferences->safeBrowsingEnabled();
+}
+
 #pragma mark OS X-specific methods
 
 #if PLATFORM(MAC)
@@ -697,16 +707,6 @@ static _WKStorageBlockingPolicy toAPI(WebCore::SecurityOrigin::StorageBlockingPo
     _preferences->setICECandidateFilteringEnabled(enabled);
 }
 
-- (void)setSafeBrowsingEnabled:(BOOL)enabled
-{
-    _preferences->setSafeBrowsingEnabled(enabled);
-}
-
-- (BOOL)isSafeBrowsingEnabled
-{
-    return _preferences->safeBrowsingEnabled();
-}
-
 - (BOOL)_webRTCLegacyAPIEnabled
 {
     return NO;