Web Inspector: Network Tab - Export HAR Context Menu not working
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Jan 2018 20:20:35 +0000 (20:20 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Jan 2018 20:20:35 +0000 (20:20 +0000)
https://bugs.webkit.org/show_bug.cgi?id=181694
<rdar://problem/36479197>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2018-01-16
Reviewed by Brian Burg.

* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.tableCellContextMenuClicked):
Ensure `this` works in the handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js

index 3854d26..eabd2d0 100644 (file)
@@ -1,3 +1,15 @@
+2018-01-16  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Network Tab - Export HAR Context Menu not working
+        https://bugs.webkit.org/show_bug.cgi?id=181694
+        <rdar://problem/36479197>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/NetworkTableContentView.js:
+        (WI.NetworkTableContentView.prototype.tableCellContextMenuClicked):
+        Ensure `this` works in the handler.
+
 2018-01-15  Matt Baker  <mattbaker@apple.com>
 
         Web Inspector: TabBar redesign: add context menu to TabBar for toggling available tabs
index 877eb0b..b7de7b7 100644 (file)
@@ -344,7 +344,7 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
         WI.appendContextMenuItemsForSourceCode(contextMenu, entry.resource);
 
         contextMenu.appendSeparator();
-        contextMenu.appendItem(WI.UIString("Export HAR"), this._exportHAR);
+        contextMenu.appendItem(WI.UIString("Export HAR"), () => { this._exportHAR(); });
     }
 
     tableSelectedRowChanged(table, rowIndex)