REGRESSION(r214572): Update fast/text/variations/advances.html to understand normaliz...
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 27 Apr 2017 19:08:22 +0000 (19:08 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 27 Apr 2017 19:08:22 +0000 (19:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=171356
<rdar://problem/28670085>

Reviewed by Dean Jackson.

Unspecified 'wdth' axis values are being normalized because the font is a GX font. However, this
font assumes no normalization, which means one of the comparisons in the test is bogus.

* fast/text/variations/advances-expected.txt:
* fast/text/variations/advances.html:
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@215884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/text/variations/advances-expected.txt
LayoutTests/fast/text/variations/advances.html
LayoutTests/platform/ios/TestExpectations
LayoutTests/platform/mac/TestExpectations

index e95c6d6..13973e5 100644 (file)
@@ -1,3 +1,19 @@
+2017-04-27  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        REGRESSION(r214572): Update fast/text/variations/advances.html to understand normalized variation widths
+        https://bugs.webkit.org/show_bug.cgi?id=171356
+        <rdar://problem/28670085>
+
+        Reviewed by Dean Jackson.
+
+        Unspecified 'wdth' axis values are being normalized because the font is a GX font. However, this
+        font assumes no normalization, which means one of the comparisons in the test is bogus.
+
+        * fast/text/variations/advances-expected.txt:
+        * fast/text/variations/advances.html:
+        * platform/ios/TestExpectations:
+        * platform/mac/TestExpectations:
+
 2017-04-27  Antti Koivisto  <antti@apple.com>
 
         Skip css3/viewport-percentage-lengths/vh-auto-size.html on WK1.
index 187d7b2..b262679 100644 (file)
@@ -1,7 +1,6 @@
-PASS regular.offsetWidth is not wide.offsetWidth
-PASS regular.offsetWidth is not narrow.offsetWidth
+PASS specifiedregular.offsetWidth is not wide.offsetWidth
+PASS specifiedregular.offsetWidth is not narrow.offsetWidth
 PASS narrow.offsetWidth is not wide.offsetWidth
-PASS regular.offsetWidth is specifiedregular.offsetWidth
 PASS successfullyParsed is true
 
 TEST COMPLETE
index e0a2225..ca7f4a9 100644 (file)
@@ -29,14 +29,13 @@ Promise.all(promises).then(function() {
        var specifiedregular = document.getElementById("specifiedregular");
        var narrow = document.getElementById("narrow");
 
-       shouldNotBe("regular.offsetWidth", "wide.offsetWidth");
-       shouldNotBe("regular.offsetWidth", "narrow.offsetWidth");
+       shouldNotBe("specifiedregular.offsetWidth", "wide.offsetWidth");
+       shouldNotBe("specifiedregular.offsetWidth", "narrow.offsetWidth");
        shouldNotBe("narrow.offsetWidth", "wide.offsetWidth");
-       shouldBe("regular.offsetWidth", "specifiedregular.offsetWidth");
        finishJSTest();
 });
 
 </script>
 <script src="../../../resources/js-test-post.js"></script>
 </body>
-</html>
\ No newline at end of file
+</html>
index dc23f98..f420395 100644 (file)
@@ -2741,7 +2741,6 @@ fast/text/letterpress-different.html [ Pass ]
 webkit.org/b/162739 fast/images/gif-loop-count.html [ Pass ImageOnlyFailure ]
 
 # This variation font test requires Skia which isn't available on iOS.
-webkit.org/b/163093 fast/text/variations/advances.html [ Failure ]
 webkit.org/b/163093 fast/text/variations/outofbounds.html [ ImageOnlyFailure ]
 webkit.org/b/163093 fast/text/variations/default-value.html [ ImageOnlyFailure ]
 webkit.org/b/169518 fast/text/font-variations-feature-detection.html [ ImageOnlyFailure ]
index 28435ae..cf2c694 100644 (file)
@@ -1521,8 +1521,6 @@ media/encrypted-media/mock-MediaKeySession-update.html [ Skip ]
 
 webkit.org/b/166025 http/tests/fetch/fetching-same-resource-with-diffferent-options.html [ Pass Failure ]
 
-webkit.org/b/166672 [ Sierra+ ] fast/text/variations/advances.html [ Failure ]
-
 webkit.org/b/162507 http/tests/media/hls/hls-video-resize.html [ Pass Failure ]
 
 webkit.org/b/167642 imported/w3c/web-platform-tests/shadow-dom/slotchange.html [ Pass Failure ]