Allow zero values as results from the runFunction.
authordominicc@chromium.org <dominicc@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 15 Jan 2013 09:42:25 +0000 (09:42 +0000)
committerdominicc@chromium.org <dominicc@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 15 Jan 2013 09:42:25 +0000 (09:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=102500

Reviewed by Kentaro Hara.

DOM/DOMWalk.js fails on the Chromium Win perf bot because one or
more parts of the test usually return zero at some point.

* resources/runner.js: Accept merely non-negative results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

PerformanceTests/ChangeLog
PerformanceTests/resources/runner.js

index d0d753b..1881875 100644 (file)
@@ -1,3 +1,15 @@
+2013-01-15  Dominic Cooney  <dominicc@chromium.org>
+
+        Allow zero values as results from the runFunction.
+        https://bugs.webkit.org/show_bug.cgi?id=102500
+
+        Reviewed by Kentaro Hara.
+
+        DOM/DOMWalk.js fails on the Chromium Win perf bot because one or
+        more parts of the test usually return zero at some point.
+
+        * resources/runner.js: Accept merely non-negative results.
+
 2012-12-28  Yury Semikhatsky  <yurys@chromium.org>
 
         Web Inspector: rename distanceToWindow to distance
index 0cb6e07..36ae561 100755 (executable)
@@ -257,8 +257,8 @@ if (window.testRunner) {
         var end = PerfTestRunner.now();
 
         if (returnValue - 0 === returnValue) {
-            if (returnValue <= 0)
-                PerfTestRunner.log("runFunction returned a non-positive value: " + returnValue);
+            if (returnValue < 0)
+                PerfTestRunner.log("runFunction returned a negative value: " + returnValue);
             return returnValue;
         }