Remove unused QTKit preference
authorachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 24 Jan 2018 19:33:19 +0000 (19:33 +0000)
committerachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 24 Jan 2018 19:33:19 +0000 (19:33 +0000)
https://bugs.webkit.org/show_bug.cgi?id=181968

Reviewed by Alexey Proskuryakov.

Source/WebCore:

They weren't used and didn't do anything.

* page/DeprecatedGlobalSettings.cpp:
(WebCore::DeprecatedGlobalSettings::setQTKitEnabled): Deleted.
* page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::isQTKitEnabled): Deleted.

Source/WebKit:

* Shared/API/c/WKDeprecatedFunctions.cpp:
(WKPreferencesSetQTKitEnabled):
(WKPreferencesGetQTKitEnabled):
* Shared/WebPreferences.yaml:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetQTKitEnabled): Deleted.
(WKPreferencesGetQTKitEnabled): Deleted.
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setQTKitEnabled:]): Deleted.
(-[WKPreferences _qtKitEnabled]): Deleted.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Source/WebKitLegacy/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setQTKitEnabled:]): Deleted.
(-[WebPreferences isQTKitEnabled]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@227535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 files changed:
Source/WebCore/ChangeLog
Source/WebCore/page/DeprecatedGlobalSettings.cpp
Source/WebCore/page/DeprecatedGlobalSettings.h
Source/WebKit/ChangeLog
Source/WebKit/Shared/API/c/WKDeprecatedFunctions.cpp
Source/WebKit/Shared/WebPreferences.yaml
Source/WebKit/UIProcess/API/C/WKPreferences.cpp
Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
Source/WebKitLegacy/mac/WebView/WebPreferences.mm
Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
Source/WebKitLegacy/mac/WebView/WebView.mm

index e9f2c42..86f36df 100644 (file)
@@ -1,3 +1,17 @@
+2018-01-24  Alex Christensen  <achristensen@webkit.org>
+
+        Remove unused QTKit preference
+        https://bugs.webkit.org/show_bug.cgi?id=181968
+
+        Reviewed by Alexey Proskuryakov.
+
+        They weren't used and didn't do anything.
+
+        * page/DeprecatedGlobalSettings.cpp:
+        (WebCore::DeprecatedGlobalSettings::setQTKitEnabled): Deleted.
+        * page/DeprecatedGlobalSettings.h:
+        (WebCore::DeprecatedGlobalSettings::isQTKitEnabled): Deleted.
+
 2018-01-24  Antoine Quint  <graouts@apple.com>
 
         [Web Animations] Compute the progress and currentIteration properties on getComputedTiming()
index 269d93b..fa92e2e 100644 (file)
@@ -46,10 +46,6 @@ bool DeprecatedGlobalSettings::gAVFoundationEnabled = true;
 bool DeprecatedGlobalSettings::gAVFoundationNSURLSessionEnabled = true;
 #endif
 
-#if PLATFORM(COCOA)
-bool DeprecatedGlobalSettings::gQTKitEnabled = false;
-#endif
-
 #if USE(GSTREAMER)
 bool DeprecatedGlobalSettings::gGStreamerEnabled = true;
 #endif
@@ -105,17 +101,6 @@ void DeprecatedGlobalSettings::setAVFoundationNSURLSessionEnabled(bool enabled)
 }
 #endif
 
-#if PLATFORM(COCOA)
-void DeprecatedGlobalSettings::setQTKitEnabled(bool enabled)
-{
-    if (gQTKitEnabled == enabled)
-        return;
-
-    gQTKitEnabled = enabled;
-    HTMLMediaElement::resetMediaEngines();
-}
-#endif
-
 #if USE(GSTREAMER)
 void DeprecatedGlobalSettings::setGStreamerEnabled(bool enabled)
 {
index 93ed97e..0d9ef9d 100644 (file)
@@ -55,13 +55,6 @@ public:
     static bool isAVFoundationNSURLSessionEnabled() { return gAVFoundationNSURLSessionEnabled; }
 #endif
 
-#if PLATFORM(COCOA)
-    WEBCORE_EXPORT static void setQTKitEnabled(bool flag);
-    static bool isQTKitEnabled() { return gQTKitEnabled; }
-#else
-    static bool isQTKitEnabled() { return false; }
-#endif
-
 #if USE(GSTREAMER)
     WEBCORE_EXPORT static void setGStreamerEnabled(bool flag);
     static bool isGStreamerEnabled() { return gGStreamerEnabled; }
@@ -126,10 +119,6 @@ private:
     WEBCORE_EXPORT static bool gAVFoundationNSURLSessionEnabled;
 #endif
 
-#if PLATFORM(COCOA)
-    WEBCORE_EXPORT static bool gQTKitEnabled;
-#endif
-
 #if USE(GSTREAMER)
     WEBCORE_EXPORT static bool gGStreamerEnabled;
 #endif
index a48ea02..1008c86 100644 (file)
@@ -1,3 +1,22 @@
+2018-01-24  Alex Christensen  <achristensen@webkit.org>
+
+        Remove unused QTKit preference
+        https://bugs.webkit.org/show_bug.cgi?id=181968
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Shared/API/c/WKDeprecatedFunctions.cpp:
+        (WKPreferencesSetQTKitEnabled):
+        (WKPreferencesGetQTKitEnabled):
+        * Shared/WebPreferences.yaml:
+        * UIProcess/API/C/WKPreferences.cpp:
+        (WKPreferencesSetQTKitEnabled): Deleted.
+        (WKPreferencesGetQTKitEnabled): Deleted.
+        * UIProcess/API/Cocoa/WKPreferences.mm:
+        (-[WKPreferences _setQTKitEnabled:]): Deleted.
+        (-[WKPreferences _qtKitEnabled]): Deleted.
+        * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+
 2018-01-24  Youenn Fablet  <youenn@apple.com>
 
         Fetch response should copy its url from the request if null
index c073c06..8c70dca 100644 (file)
@@ -51,3 +51,12 @@ void WKContextSetUsesNetworkProcess(WKContextRef, bool)
 void WKContextSetProcessModel(WKContextRef, WKProcessModel)
 {
 }
+
+void WKPreferencesSetQTKitEnabled(WKPreferencesRef, bool)
+{
+}
+
+bool WKPreferencesGetQTKitEnabled(WKPreferencesRef)
+{
+    return false;
+}
index 7ac2d46..d3187af 100644 (file)
@@ -415,13 +415,6 @@ TemporaryTileCohortRetentionEnabled:
   type: bool
   defaultValue: DEFAULT_TEMPORARY_TILE_COHORT_RETENTION_ENABLED
 
-QTKitEnabled:
-  type: bool
-  defaultValue: WebCore::DeprecatedGlobalSettings::isQTKitEnabled()
-  getter: isQTKitEnabled
-  webcoreBinding: DeprecatedGlobalSettings
-  condition: PLATFORM(COCOA)
-
 PageVisibilityBasedProcessSuppressionEnabled:
   type: bool
   defaultValue: true
index d02bb30..03b8e43 100644 (file)
@@ -1203,16 +1203,6 @@ bool WKPreferencesGetAggressiveTileRetentionEnabled(WKPreferencesRef preferences
     return toImpl(preferencesRef)->aggressiveTileRetentionEnabled();
 }
 
-void WKPreferencesSetQTKitEnabled(WKPreferencesRef preferencesRef, bool enabled)
-{
-    toImpl(preferencesRef)->setQTKitEnabled(enabled);
-}
-
-bool WKPreferencesGetQTKitEnabled(WKPreferencesRef preferencesRef)
-{
-    return toImpl(preferencesRef)->isQTKitEnabled();
-}
-
 void WKPreferencesSetLogsPageMessagesToSystemConsoleEnabled(WKPreferencesRef preferencesRef, bool enabled)
 {
     toImpl(preferencesRef)->setLogsPageMessagesToSystemConsoleEnabled(enabled);
index 6573c14..745568e 100644 (file)
@@ -932,16 +932,6 @@ static WebCore::EditableLinkBehavior toEditableLinkBehavior(_WKEditableLinkBehav
     return _preferences->plugInSnapshottingEnabled();
 }
 
-- (void)_setQTKitEnabled:(BOOL)enabled
-{
-    _preferences->setQTKitEnabled(enabled);
-}
-
-- (BOOL)_qtKitEnabled
-{
-    return _preferences->isQTKitEnabled();
-}
-
 - (void)_setSubpixelCSSOMElementMetricsEnabled:(BOOL)enabled
 {
     _preferences->setSubpixelCSSOMElementMetricsEnabled(enabled);
index 98ed6b2..72303b3 100644 (file)
@@ -154,7 +154,6 @@ typedef NS_ENUM(NSInteger, _WKEditableLinkBehavior) {
 @property (nonatomic, setter=_setArtificialPluginInitializationDelayEnabled:) BOOL _artificialPluginInitializationDelayEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 @property (nonatomic, setter=_setCookieEnabled:) BOOL _cookieEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 @property (nonatomic, setter=_setPlugInSnapshottingEnabled:) BOOL _plugInSnapshottingEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
-@property (nonatomic, setter=_setQTKitEnabled:) BOOL _qtKitEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 @property (nonatomic, setter=_setSubpixelCSSOMElementMetricsEnabled:) BOOL _subpixelCSSOMElementMetricsEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 @property (nonatomic, setter=_setMediaSourceEnabled:) BOOL _mediaSourceEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 @property (nonatomic, setter=_setViewGestureDebuggingEnabled:) BOOL _viewGestureDebuggingEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
index 23f9dfe..6b7192e 100644 (file)
@@ -1,3 +1,19 @@
+2018-01-24  Alex Christensen  <achristensen@webkit.org>
+
+        Remove unused QTKit preference
+        https://bugs.webkit.org/show_bug.cgi?id=181968
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebView/WebPreferenceKeysPrivate.h:
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]):
+        (-[WebPreferences setQTKitEnabled:]): Deleted.
+        (-[WebPreferences isQTKitEnabled]): Deleted.
+        * WebView/WebPreferencesPrivate.h:
+        * WebView/WebView.mm:
+        (-[WebView _preferencesChanged:]):
+
 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
index 6b050b9..75e71b5 100644 (file)
 #define WebKitDiagnosticLoggingEnabledKey @"WebKitDiagnosticLoggingEnabled"
 #define WebKitStorageBlockingPolicyKey @"WebKitStorageBlockingPolicy"
 #define WebKitPlugInSnapshottingEnabledPreferenceKey @"WebKitPlugInSnapshottingEnabled"
-#define WebKitQTKitEnabledPreferenceKey @"WebKitQTKitEnabled"
 #define WebKitHiddenPageDOMTimerThrottlingEnabledPreferenceKey @"WebKitHiddenPageDOMTimerThrottlingEnabled"
 #define WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey @"WebKitHiddenPageCSSAnimationSuspensionEnabled"
 #define WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey @"WebKitLowPowerVideoAudioBufferSizeEnabled"
index 001645b..a983c8c 100644 (file)
@@ -596,7 +596,6 @@ public:
 #endif
         [NSNumber numberWithLongLong:ApplicationCacheStorage::noQuota()], WebKitApplicationCacheTotalQuota,
         [NSNumber numberWithLongLong:ApplicationCacheStorage::noQuota()], WebKitApplicationCacheDefaultOriginQuota,
-        [NSNumber numberWithBool:DeprecatedGlobalSettings::isQTKitEnabled()], WebKitQTKitEnabledPreferenceKey,
         [NSNumber numberWithBool:NO], WebKitHiddenPageDOMTimerThrottlingEnabledPreferenceKey,
         [NSNumber numberWithBool:NO], WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey,
         [NSNumber numberWithBool:NO], WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey,
@@ -2264,16 +2263,6 @@ static NSString *classIBCreatorID = nil;
     return [self _boolValueForKey:WebKitAVFoundationNSURLSessionEnabledKey];
 }
 
-- (void)setQTKitEnabled:(BOOL)flag
-{
-    [self _setBoolValue:flag forKey:WebKitQTKitEnabledPreferenceKey];
-}
-
-- (BOOL)isQTKitEnabled
-{
-    return [self _boolValueForKey:WebKitQTKitEnabledPreferenceKey];
-}
-
 - (void)setVideoPluginProxyEnabled:(BOOL)flag
 {
     // No-op, left for SPI compatibility.
index eee06b5..2958b40 100644 (file)
@@ -423,9 +423,6 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification;
 - (void)setAVFoundationNSURLSessionEnabled:(BOOL)flag;
 - (BOOL)isAVFoundationNSURLSessionEnabled;
 
-- (void)setQTKitEnabled:(BOOL)flag;
-- (BOOL)isQTKitEnabled;
-
 // Deprecated, has no effect.
 - (void)setVideoPluginProxyEnabled:(BOOL)flag;
 - (BOOL)isVideoPluginProxyEnabled;
index 6fd0822..c7043d2 100644 (file)
@@ -2935,7 +2935,6 @@ static bool needsSelfRetainWhileLoadingQuirk()
     settings.setExperimentalNotificationsEnabled([preferences experimentalNotificationsEnabled]);
     settings.setShowsURLsInToolTips([preferences showsURLsInToolTips]);
     settings.setShowsToolTipOverTruncatedText([preferences showsToolTipOverTruncatedText]);
-    DeprecatedGlobalSettings::setQTKitEnabled([preferences isQTKitEnabled]);
 #endif // PLATFORM(MAC)
 
     DatabaseManager::singleton().setIsAvailable([preferences databasesEnabled]);