[LFC][BFC][MarginCollapsing] Remove quirk from MarginCollapse::marginsCollapseThrough
authorzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 29 Jan 2019 14:53:03 +0000 (14:53 +0000)
committerzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 29 Jan 2019 14:53:03 +0000 (14:53 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193948

Reviewed by Antti Koivisto.

This is now implemented in BlockFormattingContext::Quirks::stretchedInFlowHeight().

* layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp

index 8d0c430..f61060d 100644 (file)
@@ -1,5 +1,17 @@
 2019-01-29  Zalan Bujtas  <zalan@apple.com>
 
+        [LFC][BFC][MarginCollapsing] Remove quirk from MarginCollapse::marginsCollapseThrough
+        https://bugs.webkit.org/show_bug.cgi?id=193948
+
+        Reviewed by Antti Koivisto.
+
+        This is now implemented in BlockFormattingContext::Quirks::stretchedInFlowHeight().
+
+        * layout/blockformatting/BlockMarginCollapse.cpp:
+        (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):
+
+2019-01-29  Zalan Bujtas  <zalan@apple.com>
+
         [LFC][BFC][MarginCollapsing] Anonymous block container's margin before does not collapse with previous inflow sibling margin after.
         https://bugs.webkit.org/show_bug.cgi?id=193952
 
index 61576a3..4d50145 100644 (file)
@@ -398,9 +398,6 @@ bool BlockFormattingContext::MarginCollapse::marginsCollapseThrough(const Layout
     if (!downcast<Container>(layoutBox).hasInFlowChild())
         return !establishesBlockFormattingContext(layoutBox);
 
-    if (Quirks::needsStretching(layoutState, layoutBox))
-        return false;
-
     if (layoutBox.establishesFormattingContext()) {
         if (layoutBox.establishesInlineFormattingContext()) {
             // If we get here through margin estimation, we don't necessarily have an actual state for this layout box since