2010-10-09 Adam Barth <abarth@webkit.org>
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 10 Oct 2010 04:17:05 +0000 (04:17 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 10 Oct 2010 04:17:05 +0000 (04:17 +0000)
        Reviewed by Alexey Proskuryakov.

        Exception in committers-autocomplete in Firefox
        https://bugs.webkit.org/show_bug.cgi?id=47456

        Remove dependency on a WebKit-only quirk.  IMHO, this quirk is bad for
        the long-term health of the web, but that's a discussion for another
        patch.

        * committers-autocomplete.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

BugsSite/ChangeLog
BugsSite/committers-autocomplete.js

index c30095e..b69ea66 100644 (file)
@@ -1,3 +1,16 @@
+2010-10-09  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Exception in committers-autocomplete in Firefox
+        https://bugs.webkit.org/show_bug.cgi?id=47456
+
+        Remove dependency on a WebKit-only quirk.  IMHO, this quirk is bad for
+        the long-term health of the web, but that's a discussion for another
+        patch.
+
+        * committers-autocomplete.js:
+
 2010-10-08  Adam Barth  <abarth@webkit.org>
 
         Reviewed by Oliver Hunt.
index c9fd50d..5dba7f3 100644 (file)
@@ -277,12 +277,12 @@ WebKitCommitters = (function() {
             menu.addEventListener('mousedown', function(e) {
                 selectItem(getIndex(e.target));
                 e.preventDefault();
-            });
+            }, false);
 
             menu.addEventListener('mouseup', function(e) {
                 if (m_selectedIndex == getIndex(e.target))
                     insertSelectedItem();
-            });
+            }, false);
             
             m_menus[name] = menu;
         }
@@ -372,13 +372,13 @@ WebKitCommitters = (function() {
         if (!getMenu()) {
             createMenu(m_focusedInput.name);
             m_focusedInput.setAttribute('autocomplete', 'off');
-            m_focusedInput.addEventListener('keyup', handleKeyUp);
-            m_focusedInput.addEventListener('keydown', handleKeyDown);
+            m_focusedInput.addEventListener('keyup', handleKeyUp, false);
+            m_focusedInput.addEventListener('keydown', handleKeyDown, false);
             m_focusedInput.addEventListener('blur', function() {
                 showMenu(false);
                 m_prefix = null;
                 m_selectedIndex = 0;
-            });
+            }, false);
         }
         
         updateMenu();
@@ -391,7 +391,7 @@ WebKitCommitters = (function() {
                 break;
             }
         }
-    });
+    }, false);
 
     WebKitCommitters.getCommitters(function (committers) {
         m_committers = committers;