[EME] MediaKeySystemConfiguration distinctiveIdentifier and persistentState should...
authorcalvaris@igalia.com <calvaris@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Dec 2018 08:55:54 +0000 (08:55 +0000)
committercalvaris@igalia.com <calvaris@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Dec 2018 08:55:54 +0000 (08:55 +0000)
https://bugs.webkit.org/show_bug.cgi?id=192815

Reviewed by Jer Noble.

https://www.w3.org/TR/encrypted-media/#dom-mediakeysystemconfiguration
says that distinctiveIdentifier and persistentState default to
optional. Our implementation does not define a default leaving it
to the first option of the enum, which currently is Required.

* platform/encryptedmedia/CDMKeySystemConfiguration.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/encryptedmedia/CDMKeySystemConfiguration.h

index e9e7b80..af174d4 100644 (file)
@@ -1,3 +1,17 @@
+2018-12-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [EME] MediaKeySystemConfiguration distinctiveIdentifier and persistentState should default to optional
+        https://bugs.webkit.org/show_bug.cgi?id=192815
+
+        Reviewed by Jer Noble.
+
+        https://www.w3.org/TR/encrypted-media/#dom-mediakeysystemconfiguration
+        says that distinctiveIdentifier and persistentState default to
+        optional. Our implementation does not define a default leaving it
+        to the first option of the enum, which currently is Required.
+
+        * platform/encryptedmedia/CDMKeySystemConfiguration.h:
+
 2018-12-19  Rob Buis  <rbuis@igalia.com>
 
         Merge parseAccessControlExposeHeadersAllowList into parseAccessControlAllowList
index 3854921..612d645 100644 (file)
@@ -45,8 +45,8 @@ struct CDMKeySystemConfiguration {
     Vector<String> initDataTypes;
     Vector<CDMMediaCapability> audioCapabilities;
     Vector<CDMMediaCapability> videoCapabilities;
-    CDMRequirement distinctiveIdentifier;
-    CDMRequirement persistentState;
+    CDMRequirement distinctiveIdentifier { CDMRequirement::Optional };
+    CDMRequirement persistentState { CDMRequirement::Optional };
     Vector<CDMSessionType> sessionTypes;
 };