Dashboard bubbles sometimes show failure count instead of crash count
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Aug 2017 20:01:16 +0000 (20:01 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Aug 2017 20:01:16 +0000 (20:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=175157
<rdar://problem/33709009>

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
(BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js
Tools/ChangeLog

index f569e50..d560182 100644 (file)
@@ -75,10 +75,11 @@ BuildbotTestResults.prototype = {
 
         function resultSummarizer(matchString, sum, outputLine)
         {
-            var match = /^(\d+)\s/.exec(outputLine);
+            // Sample outputLine: "53 failures 37 new passes 1 crashes"
+            var regex = new RegExp("(\\d+)\\s" + matchString);
+            match = regex.exec(outputLine);
             if (!match) {
-                var regex = new RegExp("(\\d+)\\s" + matchString);
-                match = regex.exec(outputLine);
+                match = /^(\d+)\s/.exec(outputLine);
             }
             if (!match)
                 return sum;
index 4666041..abc3e46 100644 (file)
@@ -1,3 +1,14 @@
+2017-08-04  Aakash Jain  <aakash_jain@apple.com>
+
+        Dashboard bubbles sometimes show failure count instead of crash count
+        https://bugs.webkit.org/show_bug.cgi?id=175157
+        <rdar://problem/33709009>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
+        (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
+
 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
 
         Add tests for NeverDestroyed