Really enable the automatic checking and regenerations of .xcfilelists during builds
authorkrollin@apple.com <krollin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Feb 2019 22:54:54 +0000 (22:54 +0000)
committerkrollin@apple.com <krollin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Feb 2019 22:54:54 +0000 (22:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=194357
<rdar://problem/47861231>

Reviewed by Chris Dumez.

Bug 194124 was supposed to enable the automatic checking and
regenerating of .xcfilelist files during the build. While related
changes were included in that patch, the change to actually enable the
operation somehow was omitted. This patch actually enables the
operation. The check-xcfilelist.sh scripts now check
WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
from the checking.

Source/JavaScriptCore:

* Scripts/check-xcfilelists.sh:

Source/WebCore:

No new tests since there should be no observable behavior difference.

* Scripts/check-xcfilelists.sh:

Source/WebKit:

* Scripts/check-xcfilelists.sh:

Tools:

* DumpRenderTree/Scripts/check-xcfilelists.sh:
* WebKitTestRunner/Scripts/check-xcfilelists.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Scripts/check-xcfilelists.sh
Source/WebCore/ChangeLog
Source/WebCore/Scripts/check-xcfilelists.sh
Source/WebKit/ChangeLog
Source/WebKit/Scripts/check-xcfilelists.sh
Tools/ChangeLog
Tools/DumpRenderTree/Scripts/check-xcfilelists.sh
Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh

index 9477d74..ea2d819 100644 (file)
@@ -1,3 +1,21 @@
+2019-02-06  Keith Rollin  <krollin@apple.com>
+
+        Really enable the automatic checking and regenerations of .xcfilelists during builds
+        https://bugs.webkit.org/show_bug.cgi?id=194357
+        <rdar://problem/47861231>
+
+        Reviewed by Chris Dumez.
+
+        Bug 194124 was supposed to enable the automatic checking and
+        regenerating of .xcfilelist files during the build. While related
+        changes were included in that patch, the change to actually enable the
+        operation somehow was omitted. This patch actually enables the
+        operation. The check-xcfilelist.sh scripts now check
+        WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
+        from the checking.
+
+        * Scripts/check-xcfilelists.sh:
+
 2019-02-06  Yusuke Suzuki  <ysuzuki@apple.com>
 
         [JSC] Unify indirectEvalExecutableSpace and directEvalExecutableSpace
index 953dae2..efb4ab1 100755 (executable)
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
 [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
 [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
 
index 20840c6..813a22f 100644 (file)
@@ -1,3 +1,23 @@
+2019-02-06  Keith Rollin  <krollin@apple.com>
+
+        Really enable the automatic checking and regenerations of .xcfilelists during builds
+        https://bugs.webkit.org/show_bug.cgi?id=194357
+        <rdar://problem/47861231>
+
+        Reviewed by Chris Dumez.
+
+        Bug 194124 was supposed to enable the automatic checking and
+        regenerating of .xcfilelist files during the build. While related
+        changes were included in that patch, the change to actually enable the
+        operation somehow was omitted. This patch actually enables the
+        operation. The check-xcfilelist.sh scripts now check
+        WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
+        from the checking.
+
+        No new tests since there should be no observable behavior difference.
+
+        * Scripts/check-xcfilelists.sh:
+
 2019-02-06  John Wilander  <wilander@apple.com>
 
         Forward Ad Click Attribution data from HTMLAnchorElement::handleClick() to WebKit::NavigationActionData
index c669a7d..585b950 100755 (executable)
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
 [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
 [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
 
index 8ea92d1..7b02752 100644 (file)
@@ -1,3 +1,21 @@
+2019-02-06  Keith Rollin  <krollin@apple.com>
+
+        Really enable the automatic checking and regenerations of .xcfilelists during builds
+        https://bugs.webkit.org/show_bug.cgi?id=194357
+        <rdar://problem/47861231>
+
+        Reviewed by Chris Dumez.
+
+        Bug 194124 was supposed to enable the automatic checking and
+        regenerating of .xcfilelist files during the build. While related
+        changes were included in that patch, the change to actually enable the
+        operation somehow was omitted. This patch actually enables the
+        operation. The check-xcfilelist.sh scripts now check
+        WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
+        from the checking.
+
+        * Scripts/check-xcfilelists.sh:
+
 2019-02-06  John Wilander  <wilander@apple.com>
 
         Forward Ad Click Attribution data from HTMLAnchorElement::handleClick() to WebKit::NavigationActionData
index 8e836f1..1150a4f 100755 (executable)
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
 [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
 [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
 
index bacdf01..274d339 100644 (file)
@@ -1,3 +1,22 @@
+2019-02-06  Keith Rollin  <krollin@apple.com>
+
+        Really enable the automatic checking and regenerations of .xcfilelists during builds
+        https://bugs.webkit.org/show_bug.cgi?id=194357
+        <rdar://problem/47861231>
+
+        Reviewed by Chris Dumez.
+
+        Bug 194124 was supposed to enable the automatic checking and
+        regenerating of .xcfilelist files during the build. While related
+        changes were included in that patch, the change to actually enable the
+        operation somehow was omitted. This patch actually enables the
+        operation. The check-xcfilelist.sh scripts now check
+        WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
+        from the checking.
+
+        * DumpRenderTree/Scripts/check-xcfilelists.sh:
+        * WebKitTestRunner/Scripts/check-xcfilelists.sh:
+
 2019-02-06  David Kilzer  <ddkilzer@apple.com>
 
         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
index 8a08773..b18acb3 100755 (executable)
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
 [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
 [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
 
index 730145c..7e89950 100755 (executable)
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
 [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
 [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }