ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDest...
authordino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Oct 2018 21:17:19 +0000 (21:17 +0000)
committerdino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Oct 2018 21:17:19 +0000 (21:17 +0000)
https://bugs.webkit.org/show_bug.cgi?id=186946
<rdar://problem/41724248>

Reviewed by Antoine Quint.

If the incoming test has different enableWebAnimationsCSSIntegration options,
then we need to create a new WebView.

* DumpRenderTree/TestOptions.cpp:
(TestOptions::webViewIsCompatibleWithOptions const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/DumpRenderTree/TestOptions.cpp

index 5cc581b..15c0c31 100644 (file)
@@ -1,3 +1,17 @@
+2018-10-19  Dean Jackson  <dino@apple.com>
+
+        ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
+        https://bugs.webkit.org/show_bug.cgi?id=186946
+        <rdar://problem/41724248>
+
+        Reviewed by Antoine Quint.
+
+        If the incoming test has different enableWebAnimationsCSSIntegration options,
+        then we need to create a new WebView.
+
+        * DumpRenderTree/TestOptions.cpp:
+        (TestOptions::webViewIsCompatibleWithOptions const):
+
 2018-10-19  Charlie Turner  <cturner@igalia.com>
 
         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
index e4e0862..81b2487 100644 (file)
@@ -116,5 +116,6 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
 bool TestOptions::webViewIsCompatibleWithOptions(const TestOptions& other) const
 {
     return other.layerBackedWebView == layerBackedWebView
-        && other.jscOptions == jscOptions;
+        && other.jscOptions == jscOptions
+        && other.enableWebAnimationsCSSIntegration == enableWebAnimationsCSSIntegration;
 }