Unreviewed, rolling out r244495.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 22 Apr 2019 15:50:55 +0000 (15:50 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 22 Apr 2019 15:50:55 +0000 (15:50 +0000)
https://bugs.webkit.org/show_bug.cgi?id=197159

Causing build failures on OpenSource and Internal bots
(Requested by ShawnRoberts on #webkit).

Reverted changeset:

"WHLSLPrepare.cpp always recompiles, even if nothing was
changed"
https://bugs.webkit.org/show_bug.cgi?id=197151
https://trac.webkit.org/changeset/244495

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/DerivedSources-input.xcfilelist
Source/WebCore/DerivedSources-output.xcfilelist
Source/WebCore/DerivedSources.make

index b9ab67e..352dee0 100644 (file)
@@ -1,3 +1,18 @@
+2019-04-22  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244495.
+        https://bugs.webkit.org/show_bug.cgi?id=197159
+
+        Causing build failures on OpenSource and Internal bots
+        (Requested by ShawnRoberts on #webkit).
+
+        Reverted changeset:
+
+        "WHLSLPrepare.cpp always recompiles, even if nothing was
+        changed"
+        https://bugs.webkit.org/show_bug.cgi?id=197151
+        https://trac.webkit.org/changeset/244495
+
 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
index 766054f..6b24a94 100644 (file)
@@ -15,7 +15,6 @@ $(JAVASCRIPTCORE_PRIVATE_HEADERS_DIR)/generate-js-builtins.py
 $(JAVASCRIPTCORE_PRIVATE_HEADERS_DIR)/lazywriter.py
 $(JAVASCRIPTCORE_PRIVATE_HEADERS_DIR)/make-js-file-arrays.py
 $(JAVASCRIPTCORE_PRIVATE_HEADERS_DIR)/wkbuiltins.py
-$(JAVASCRIPTCORE_PRIVATE_HEADERS_DIR)/xxd.pl
 $(PROJECT_DIR)/Configurations/FeatureDefines.xcconfig
 $(PROJECT_DIR)/DerivedSources.make
 $(PROJECT_DIR)/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl
@@ -342,7 +341,6 @@ $(PROJECT_DIR)/Modules/webgpu/GPUTextureFormat.idl
 $(PROJECT_DIR)/Modules/webgpu/GPUTextureUsage.idl
 $(PROJECT_DIR)/Modules/webgpu/GPUVertexAttributeDescriptor.idl
 $(PROJECT_DIR)/Modules/webgpu/GPUVertexInputDescriptor.idl
-$(PROJECT_DIR)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
 $(PROJECT_DIR)/Modules/webgpu/WebGPU.idl
 $(PROJECT_DIR)/Modules/webgpu/WebGPUAdapter.idl
 $(PROJECT_DIR)/Modules/webgpu/WebGPUBindGroup.idl
index eaf7d2e..26b65ff 100644 (file)
@@ -2084,7 +2084,7 @@ $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/TouchList.idl
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/UserAgentScripts.h
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/UserAgentScriptsData.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/UserAgentStyleSheets.h
-$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WHLSLStandardLibrary.h
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WHLSLStandardLibrary.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCoreJSBuiltinInternals.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCoreJSBuiltinInternals.h
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCoreJSBuiltins.cpp
index 71afb6a..033e64b 100644 (file)
@@ -1633,10 +1633,10 @@ $(GENERATE_SETTINGS_PATTERNS) : $(WebCore)/Scripts/GenerateSettings.rb $(GENERAT
 
 # WHLSL Standard Library
 
-all : WHLSLStandardLibrary.h
+all : WHLSLStandardLibrary.cpp
 
-WHLSLStandardLibrary.h : $(JavaScriptCore_SCRIPTS_DIR)/xxd.pl $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
-       $(PERL) $(JavaScriptCore_SCRIPTS_DIR)/xxd.pl WHLSLStandardLibrary $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt $<
+WHLSLStandardLibrary.cpp : $(JavaScriptCore_SCRIPTS_DIR)/xxd.pl $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
+       $(PERL) $(JavaScriptCore_SCRIPTS_DIR)/xxd.pl WHLSLStandardLibrary $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt WHLSLStandardLibrary.h
 
 # --------