2011-04-06 Zan Dobersek <zandobersek@gmail.com>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Apr 2011 18:40:50 +0000 (18:40 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Apr 2011 18:40:50 +0000 (18:40 +0000)
        Reviewed by Eric Seidel.

        [Gtk] plugins/set-status.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57844

        Unskip a newly-passing test.

        * platform/gtk/Skipped:
2011-04-06  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [Gtk] plugins/set-status.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57844

        Allow an empty status text to be dumped.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewStatusBarTextChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/Skipped
Tools/ChangeLog
Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

index 0b3a8da..10aa599 100644 (file)
@@ -1,3 +1,14 @@
+2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
+
+        Reviewed by Eric Seidel.
+
+        [Gtk] plugins/set-status.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=57844
+
+        Unskip a newly-passing test.
+
+        * platform/gtk/Skipped:
+
 2011-04-06  David Hyatt  <hyatt@apple.com>
 
         Reviewed by Dan Bernstein.
index 7675451..51f204f 100644 (file)
@@ -709,9 +709,6 @@ fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
 # Fails on GTK release bots, see https://bugs.webkit.org/show_bug.cgi?id=51027
 plugins/refcount-leaks.html
 
-# Fails on GTK bots, see https://bugs.webkit.org/show_bug.cgi?id=35144
-plugins/set-status.html
-
 # Fails on 32bits Debug bot, see https://bugs.webkit.org/show_bug.cgi?id=35158
 fast/forms/restore-selection-after-layout.html
 
index 8182f4d..e9e9e5c 100644 (file)
@@ -1,3 +1,15 @@
+2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
+
+        Reviewed by Eric Seidel.
+
+        [Gtk] plugins/set-status.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=57844
+
+        Allow an empty status text to be dumped.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (webViewStatusBarTextChanged):
+
 2011-04-06  Chang Shu  <cshu@webkit.org>
 
         Reviewed by Darin Adler.
index 577c3f2..1eceb19 100644 (file)
@@ -941,10 +941,8 @@ static void webViewStatusBarTextChanged(WebKitWebView* view, const gchar* messag
 {
     // Are we doing anything wrong? One test that does not call
     // dumpStatusCallbacks gets true here
-    if (gLayoutTestController->dumpStatusCallbacks()) {
-        if (message && strcmp(message, ""))
-            printf("UI DELEGATE STATUS CALLBACK: setStatusText:%s\n", message);
-    }
+    if (gLayoutTestController->dumpStatusCallbacks())
+        printf("UI DELEGATE STATUS CALLBACK: setStatusText:%s\n", message);
 }
 
 static gboolean webViewClose(WebKitWebView* view)