Turn on img@sizes compile flag
authoryoav@yoav.ws <yoav@yoav.ws@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 7 Jul 2014 05:02:34 +0000 (05:02 +0000)
committeryoav@yoav.ws <yoav@yoav.ws@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 7 Jul 2014 05:02:34 +0000 (05:02 +0000)
https://bugs.webkit.org/show_bug.cgi?id=134634

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.

Source/WebCore:
* Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.

Source/WebKit:
* mac/Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.

Source/WebKit2:
* Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.

Source/WTF:
* wtf/FeatureDefines.h: Added compile flag definition.

Tools:
* Scripts/webkitperl/FeatureList.pm: Turn on the img@sizes feature.

WebKitLibraries:
* win/tools/vsprops/FeatureDefines.props: Added compile flag.

LayoutTests:
* TestExpectations: Turned on layout tests for the img@sizes feature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 files changed:
LayoutTests/ChangeLog
LayoutTests/TestExpectations
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Source/WTF/ChangeLog
Source/WTF/wtf/FeatureDefines.h
Source/WebCore/ChangeLog
Source/WebCore/Configurations/FeatureDefines.xcconfig
Source/WebKit/ChangeLog
Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
Source/WebKit2/ChangeLog
Source/WebKit2/Configurations/FeatureDefines.xcconfig
Source/cmake/OptionsEfl.cmake
Source/cmake/OptionsGTK.cmake
Tools/ChangeLog
Tools/Scripts/webkitperl/FeatureList.pm
WebKitLibraries/ChangeLog
WebKitLibraries/win/tools/vsprops/FeatureDefines.props

index 51438e1..98fafb2 100644 (file)
@@ -1,3 +1,12 @@
+2014-07-06  Yoav Weiss  <yoav@yoav.ws>
+
+        Turn on img@sizes compile flag
+        https://bugs.webkit.org/show_bug.cgi?id=134634
+
+        Reviewed by Benjamin Poulain.
+
+        * TestExpectations: Turned on layout tests for the img@sizes feature.
+
 2014-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 
         [EFL] Support Geolocation
index e8ac500..c797cf1 100644 (file)
@@ -126,7 +126,3 @@ webkit.org/b/132791 svg/as-object/sizing/svg-in-object-placeholder-height-percen
 webkit.org/b/132791 svg/as-object/sizing/svg-in-object-placeholder-height-auto.html [ Skip ]
 
 webkit.org/b/133057 fast/table/border-collapsing/collapsed-borders-adjoining-sections.html [ ImageOnlyFailure ]
-
-# Skip img@sizes tests since it is disabled by default.
-fast/dom/HTMLImageElement/sizes
-http/tests/loading/sizes
index d76256f..24f8ab6 100644 (file)
@@ -1,3 +1,12 @@
+2014-07-06  Yoav Weiss  <yoav@yoav.ws>
+
+        Turn on img@sizes compile flag
+        https://bugs.webkit.org/show_bug.cgi?id=134634
+
+        Reviewed by Benjamin Poulain.
+
+        * Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.
+
 2014-07-06  Daewoong Jang  <daewoong.jang@navercorp.com>
 
         Flags value of SourceCodeKey should be unique for each case.
index 416b9b3..b65ef63 100644 (file)
@@ -170,6 +170,7 @@ ENABLE_NOTIFICATIONS = $(ENABLE_NOTIFICATIONS_$(PLATFORM_NAME));
 ENABLE_NOTIFICATIONS_macosx = ENABLE_NOTIFICATIONS;
 ENABLE_PDFKIT_PLUGIN = $(ENABLE_PDFKIT_PLUGIN_$(PLATFORM_NAME));
 ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN;
+ENABLE_PICTURE_SIZES = ENABLE_PICTURE_SIZES;
 ENABLE_POINTER_LOCK = ;
 ENABLE_PROMISES = ENABLE_PROMISES;
 ENABLE_PROXIMITY_EVENTS = ;
@@ -228,7 +229,6 @@ ENABLE_WEB_REPLAY_macosx_Production = ;
 ENABLE_WEB_REPLAY_iphoneos = ;
 ENABLE_WEB_REPLAY_iphonesimulator = ;
 ENABLE_WEB_SOCKETS = ENABLE_WEB_SOCKETS;
-ENABLE_PICTURE_SIZES = ENABLE_PICTURE_SIZES;
 
 ENABLE_WEB_TIMING = $(ENABLE_WEB_TIMING_$(PLATFORM_NAME));
 ENABLE_WEB_TIMING_macosx = $(ENABLE_WEB_TIMING_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
index 321dd0f..02cd4c8 100644 (file)
@@ -1,3 +1,12 @@
+2014-07-06  Yoav Weiss  <yoav@yoav.ws>
+
+        Turn on img@sizes compile flag
+        https://bugs.webkit.org/show_bug.cgi?id=134634
+
+        Reviewed by Benjamin Poulain.
+
+        * wtf/FeatureDefines.h: Added compile flag definition.
+
 2014-07-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 
         Unreivewed, fix build break on EFL and GTK since r170767.
index 3b0ba88..cef7b6f 100644 (file)
 #define ENABLE_WEB_SOCKETS 1
 #endif
 
+#if !defined(ENABLE_PICTURE_SIZES)
+#define ENABLE_PICTURE_SIZES 1
+#endif
+
 #if !defined(ENABLE_WEB_TIMING)
 #define ENABLE_WEB_TIMING 0
 #endif
index 7d4e1f6..22c5242 100644 (file)
@@ -1,3 +1,12 @@
+2014-07-06  Yoav Weiss  <yoav@yoav.ws>
+
+        Turn on img@sizes compile flag
+        https://bugs.webkit.org/show_bug.cgi?id=134634
+
+        Reviewed by Benjamin Poulain.
+
+        * Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.
+
 2014-07-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 
         Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and generateTypeHelpers
index 416b9b3..b65ef63 100644 (file)
@@ -170,6 +170,7 @@ ENABLE_NOTIFICATIONS = $(ENABLE_NOTIFICATIONS_$(PLATFORM_NAME));
 ENABLE_NOTIFICATIONS_macosx = ENABLE_NOTIFICATIONS;
 ENABLE_PDFKIT_PLUGIN = $(ENABLE_PDFKIT_PLUGIN_$(PLATFORM_NAME));
 ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN;
+ENABLE_PICTURE_SIZES = ENABLE_PICTURE_SIZES;
 ENABLE_POINTER_LOCK = ;
 ENABLE_PROMISES = ENABLE_PROMISES;
 ENABLE_PROXIMITY_EVENTS = ;
@@ -228,7 +229,6 @@ ENABLE_WEB_REPLAY_macosx_Production = ;
 ENABLE_WEB_REPLAY_iphoneos = ;
 ENABLE_WEB_REPLAY_iphonesimulator = ;
 ENABLE_WEB_SOCKETS = ENABLE_WEB_SOCKETS;
-ENABLE_PICTURE_SIZES = ENABLE_PICTURE_SIZES;
 
 ENABLE_WEB_TIMING = $(ENABLE_WEB_TIMING_$(PLATFORM_NAME));
 ENABLE_WEB_TIMING_macosx = $(ENABLE_WEB_TIMING_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
index d61eb7b..656a8ff 100644 (file)
@@ -1,3 +1,12 @@
+2014-07-06  Yoav Weiss  <yoav@yoav.ws>
+
+        Turn on img@sizes compile flag
+        https://bugs.webkit.org/show_bug.cgi?id=134634
+
+        Reviewed by Benjamin Poulain.
+
+        * mac/Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.
+
 2014-07-01  Alex Christensen  <achristensen@webkit.org>
 
         [Win64] Unreviewed build fix.
index 416b9b3..b65ef63 100644 (file)
@@ -170,6 +170,7 @@ ENABLE_NOTIFICATIONS = $(ENABLE_NOTIFICATIONS_$(PLATFORM_NAME));
 ENABLE_NOTIFICATIONS_macosx = ENABLE_NOTIFICATIONS;
 ENABLE_PDFKIT_PLUGIN = $(ENABLE_PDFKIT_PLUGIN_$(PLATFORM_NAME));
 ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN;
+ENABLE_PICTURE_SIZES = ENABLE_PICTURE_SIZES;
 ENABLE_POINTER_LOCK = ;
 ENABLE_PROMISES = ENABLE_PROMISES;
 ENABLE_PROXIMITY_EVENTS = ;
@@ -228,7 +229,6 @@ ENABLE_WEB_REPLAY_macosx_Production = ;
 ENABLE_WEB_REPLAY_iphoneos = ;
 ENABLE_WEB_REPLAY_iphonesimulator = ;
 ENABLE_WEB_SOCKETS = ENABLE_WEB_SOCKETS;
-ENABLE_PICTURE_SIZES = ENABLE_PICTURE_SIZES;
 
 ENABLE_WEB_TIMING = $(ENABLE_WEB_TIMING_$(PLATFORM_NAME));
 ENABLE_WEB_TIMING_macosx = $(ENABLE_WEB_TIMING_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
index 2a71cf9..cfa8862 100644 (file)
@@ -1,3 +1,12 @@
+2014-07-06  Yoav Weiss  <yoav@yoav.ws>
+
+        Turn on img@sizes compile flag
+        https://bugs.webkit.org/show_bug.cgi?id=134634
+
+        Reviewed by Benjamin Poulain.
+
+        * Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.
+
 2014-07-06  Brady Eidson  <beidson@apple.com>
 
         Speculative fix for: NetworkProcess sometimes hangs under copyDefaultCredentialForProtectionSpace
index 416b9b3..b65ef63 100644 (file)
@@ -170,6 +170,7 @@ ENABLE_NOTIFICATIONS = $(ENABLE_NOTIFICATIONS_$(PLATFORM_NAME));
 ENABLE_NOTIFICATIONS_macosx = ENABLE_NOTIFICATIONS;
 ENABLE_PDFKIT_PLUGIN = $(ENABLE_PDFKIT_PLUGIN_$(PLATFORM_NAME));
 ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN;
+ENABLE_PICTURE_SIZES = ENABLE_PICTURE_SIZES;
 ENABLE_POINTER_LOCK = ;
 ENABLE_PROMISES = ENABLE_PROMISES;
 ENABLE_PROXIMITY_EVENTS = ;
@@ -228,7 +229,6 @@ ENABLE_WEB_REPLAY_macosx_Production = ;
 ENABLE_WEB_REPLAY_iphoneos = ;
 ENABLE_WEB_REPLAY_iphonesimulator = ;
 ENABLE_WEB_SOCKETS = ENABLE_WEB_SOCKETS;
-ENABLE_PICTURE_SIZES = ENABLE_PICTURE_SIZES;
 
 ENABLE_WEB_TIMING = $(ENABLE_WEB_TIMING_$(PLATFORM_NAME));
 ENABLE_WEB_TIMING_macosx = $(ENABLE_WEB_TIMING_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
index 4ae2daf..3842a78 100644 (file)
@@ -82,6 +82,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NAVIGATOR_HWCONCURRENCY ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETWORK_PROCESS ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NOSNIFF ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PICTURE_SIZES ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOLUTION_MEDIA_QUERY ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REQUEST_ANIMATION_FRAME ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SECCOMP_FILTERS OFF)
index abcc23c..8be2583 100644 (file)
@@ -80,6 +80,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MHTML ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NAVIGATOR_CONTENT_UTILS OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NAVIGATOR_HWCONCURRENCY ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PICTURE_SIZES ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_QUOTA OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOLUTION_MEDIA_QUERY OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REQUEST_ANIMATION_FRAME ON)
index 389db4d..1eaa336 100644 (file)
@@ -1,3 +1,12 @@
+2014-07-06  Yoav Weiss  <yoav@yoav.ws>
+
+        Turn on img@sizes compile flag
+        https://bugs.webkit.org/show_bug.cgi?id=134634
+
+        Reviewed by Benjamin Poulain.
+
+        * Scripts/webkitperl/FeatureList.pm: Turn on the img@sizes feature.
+
 2014-07-06  Hyowon Kim  <hw1008.kim@samsung.com>
 
         Unreviewed. Adding myself to committers.
index 1b482f0..d069e22 100644 (file)
@@ -347,7 +347,7 @@ my @features = (
       define => "ENABLE_PERFORMANCE_TIMELINE", default => isGtk(), value => \$performanceTimelineSupport },
 
     { option => "picture-sizes", desc => "Toggle sizes attribute support",
-      define => "ENABLE_PICTURE_SIZES", default => 0, value => \$pictureSizesSupport },
+      define => "ENABLE_PICTURE_SIZES", default => 1, value => \$pictureSizesSupport },
 
     { option => "promises", desc => "Toggle Promise support",
       define => "ENABLE_PROMISES", default => 1, value => \$promiseSupport },
index 46752a9..0748da3 100644 (file)
@@ -1,3 +1,12 @@
+2014-07-06  Yoav Weiss  <yoav@yoav.ws>
+
+        Turn on img@sizes compile flag
+        https://bugs.webkit.org/show_bug.cgi?id=134634
+
+        Reviewed by Benjamin Poulain.
+
+        * win/tools/vsprops/FeatureDefines.props: Added compile flag.
+
 2014-07-01  Pratik Solanki  <psolanki@apple.com>
 
         Encode/decode CFURLRequestRefs when USE(CFNETWORK) is enabled
index 217be64..1eea7a7 100644 (file)
@@ -60,6 +60,7 @@
     <ENABLE_PROXIMITY_EVENTS />
     <ENABLE_QUOTA />
     <ENABLE_NAVIGATOR_CONTENT_UTILS />
+    <ENABLE_PICTURE_SIZES>ENABLE_PICTURE_SIZES</ENABLE_PICTURE_SIZES>
     <ENABLE_PROMISES>ENABLE_PROMISES</ENABLE_PROMISES>
     <ENABLE_REQUEST_ANIMATION_FRAME>ENABLE_REQUEST_ANIMATION_FRAME</ENABLE_REQUEST_ANIMATION_FRAME>
     <ENABLE_SCRIPTED_SPEECH />