[Flatpak] Do not disable signals when running "usual" commands
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Nov 2018 12:53:39 +0000 (12:53 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Nov 2018 12:53:39 +0000 (12:53 +0000)
https://bugs.webkit.org/show_bug.cgi?id=190679

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-22
Reviewed by Philippe Normand.

Otherwise <ctr>c doesn't work while compiling. It is not the best fix
as there are cases we want to let only children receive signals, but
it is not clear how to determine when (when running gdb, we still
disable those).

* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/flatpak/flatpakutils.py

index 8332c09..e4512e9 100644 (file)
@@ -1,3 +1,18 @@
+2018-11-22  Thibault Saunier  <tsaunier@igalia.com>
+
+        [Flatpak] Do not disable signals when running "usual" commands
+        https://bugs.webkit.org/show_bug.cgi?id=190679
+
+        Reviewed by Philippe Normand.
+
+        Otherwise <ctr>c doesn't work while compiling. It is not the best fix
+        as there are cases we want to let only children receive signals, but
+        it is not clear how to determine when (when running gdb, we still
+        disable those).
+
+        * flatpak/flatpakutils.py:
+        (WebkitFlatpak.run_in_sandbox):
+
 2018-11-21  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         [Cocoa] [WebKit2] Add support for replacing find-in-page text matches
index 006193a..6a8ed54 100644 (file)
@@ -746,12 +746,11 @@ class WebkitFlatpak:
             _log.debug('Running in sandbox: "%s" %s\n' % ('" "'.join(flatpak_command), shell_string))
             flatpak_command.extend(['sh', "/run/host/" + tmpscript.name])
 
-            with disable_signals():
-                try:
-                    subprocess.check_call(flatpak_command, stdout=stdout)
-                except subprocess.CalledProcessError as e:
-                    sys.stderr.write(str(e) + "\n")
-                    return e.returncode
+            try:
+                subprocess.check_call(flatpak_command, stdout=stdout)
+            except subprocess.CalledProcessError as e:
+                sys.stderr.write(str(e) + "\n")
+                return e.returncode
 
         return 0