webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
authorjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Feb 2019 19:46:11 +0000 (19:46 +0000)
committerjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Feb 2019 19:46:11 +0000 (19:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=194418

Reviewed by Lucas Forschler.

Do not include errors trying when finding crashlogs at the end of
a run-webkit-tests run since we don't process those errors.

* Scripts/webkitpy/port/darwin.py:
(DarwinPort._look_for_all_crash_logs_in_log_dir):
* Scripts/webkitpy/port/ios_device.py:
(IOSDevicePort._look_for_all_crash_logs_in_log_dir):
* Scripts/webkitpy/port/watch_device.py:
(WatchDevicePort._look_for_all_crash_logs_in_log_dir):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/port/darwin.py
Tools/Scripts/webkitpy/port/ios_device.py
Tools/Scripts/webkitpy/port/watch_device.py

index 65f74df..03c4758 100644 (file)
@@ -1,3 +1,20 @@
+2019-02-08  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
+        https://bugs.webkit.org/show_bug.cgi?id=194418
+
+        Reviewed by Lucas Forschler.
+
+        Do not include errors trying when finding crashlogs at the end of
+        a run-webkit-tests run since we don't process those errors.
+
+        * Scripts/webkitpy/port/darwin.py:
+        (DarwinPort._look_for_all_crash_logs_in_log_dir):
+        * Scripts/webkitpy/port/ios_device.py:
+        (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
+        * Scripts/webkitpy/port/watch_device.py:
+        (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
+
 2019-02-08  Beth Dakin  <bdakin@apple.com>
 
         Add afterScreenUpdates to WKSnapshotConfiguration
index 5beb06b..e989465 100644 (file)
@@ -113,7 +113,7 @@ class DarwinPort(ApplePort):
 
     def _look_for_all_crash_logs_in_log_dir(self, newer_than):
         crash_log = CrashLogs(self.host, self.path_to_crash_logs(), crash_logs_to_skip=self._crash_logs_to_skip_for_host.get(self.host, []))
-        return crash_log.find_all_logs(include_errors=True, newer_than=newer_than)
+        return crash_log.find_all_logs(newer_than=newer_than)
 
     def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True, target_host=None):
         # Note that we do slow-spin here and wait, since it appears the time
index dc7b812..b3aca5d 100644 (file)
@@ -67,7 +67,7 @@ class IOSDevicePort(IOSPort):
         log_list = {}
         for device in self.devices():
             crash_log = CrashLogs(device, self.path_to_crash_logs(), crash_logs_to_skip=self._crash_logs_to_skip_for_host.get(device, []))
-            log_list.update(crash_log.find_all_logs(include_errors=True, newer_than=newer_than))
+            log_list.update(crash_log.find_all_logs(newer_than=newer_than))
         return log_list
 
     def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True, target_host=None):
index 36ef7e3..8f79fce 100644 (file)
@@ -65,7 +65,7 @@ class WatchDevicePort(WatchPort):
         log_list = {}
         for device in self.devices():
             crash_log = CrashLogs(device, self.path_to_crash_logs(), crash_logs_to_skip=self._crash_logs_to_skip_for_host.get(device, []))
-            log_list.update(crash_log.find_all_logs(include_errors=True, newer_than=newer_than))
+            log_list.update(crash_log.find_all_logs(newer_than=newer_than))
         return log_list
 
     def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True, target_host=None):