Remove unused AnalyzeWithLargeStack code from Windows build files
authorsfalken@apple.com <sfalken@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Apr 2011 20:27:08 +0000 (20:27 +0000)
committersfalken@apple.com <sfalken@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Apr 2011 20:27:08 +0000 (20:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=57771

Reviewed by Adam Roben.

This was used for us to build with prefast automatically,
but it is out-of-date and hasn't been used for some time.
Removing completely for now.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCorePreBuild.cmd:

Source/WebKit/win:

* WebKit.vcproj/WebKitLibPreBuild.cmd:

Source/WebKit2:

* win/WebKitPreBuild.cmd:

WebKitLibraries:

* win/tools/vsprops/common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/WebCore.vcproj/WebCore.vcproj
Source/WebCore/WebCore.vcproj/WebCorePreBuild.cmd
Source/WebKit/win/ChangeLog
Source/WebKit/win/WebKit.vcproj/WebKitLibPreBuild.cmd
Source/WebKit2/ChangeLog
Source/WebKit2/win/WebKitPreBuild.cmd
WebKitLibraries/ChangeLog
WebKitLibraries/win/tools/vsprops/common.vsprops

index 687ed6f..c094067 100644 (file)
@@ -1,3 +1,17 @@
+2011-04-04  Steve Falkenburg  <sfalken@apple.com>
+
+        Reviewed by Adam Roben.
+
+        Remove unused AnalyzeWithLargeStack code from Windows build files
+        https://bugs.webkit.org/show_bug.cgi?id=57771
+        
+        This was used for us to build with prefast automatically,
+        but it is out-of-date and hasn't been used for some time.
+        Removing completely for now.
+
+        * WebCore.vcproj/WebCore.vcproj:
+        * WebCore.vcproj/WebCorePreBuild.cmd:
+
 2011-04-01  Matthew Delaney  <mdelaney@apple.com>
 
         Reviewed by Simon Fraser.
index 37a52e3..75e1cfb 100755 (executable)
                                <File
                                        RelativePath="..\platform\graphics\Font.cpp"
                                        >
-                                       <FileConfiguration
-                                               Name="Debug|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
-                                       <FileConfiguration
-                                               Name="Release|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
-                                       <FileConfiguration
-                                               Name="Debug_Cairo_CFLite|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
-                                       <FileConfiguration
-                                               Name="Release_Cairo_CFLite|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
-                                       <FileConfiguration
-                                               Name="Debug_All|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
-                                       <FileConfiguration
-                                               Name="Production|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
                                </File>
                                <File
                                        RelativePath="..\platform\graphics\Font.h"
                                        <File
                                                RelativePath="..\platform\graphics\win\FontWin.cpp"
                                                >
-                                               <FileConfiguration
-                                                       Name="Debug|Win32"
-                                                       >
-                                                       <Tool
-                                                               Name="VCCLCompilerTool"
-                                                               AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                                       />
-                                               </FileConfiguration>
-                                               <FileConfiguration
-                                                       Name="Release|Win32"
-                                                       >
-                                                       <Tool
-                                                               Name="VCCLCompilerTool"
-                                                               AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                                       />
-                                               </FileConfiguration>
-                                               <FileConfiguration
-                                                       Name="Debug_Cairo_CFLite|Win32"
-                                                       >
-                                                       <Tool
-                                                               Name="VCCLCompilerTool"
-                                                               AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                                       />
-                                               </FileConfiguration>
-                                               <FileConfiguration
-                                                       Name="Release_Cairo_CFLite|Win32"
-                                                       >
-                                                       <Tool
-                                                               Name="VCCLCompilerTool"
-                                                               AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                                       />
-                                               </FileConfiguration>
-                                               <FileConfiguration
-                                                       Name="Debug_All|Win32"
-                                                       >
-                                                       <Tool
-                                                               Name="VCCLCompilerTool"
-                                                               AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                                       />
-                                               </FileConfiguration>
-                                               <FileConfiguration
-                                                       Name="Production|Win32"
-                                                       >
-                                                       <Tool
-                                                               Name="VCCLCompilerTool"
-                                                               AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                                       />
-                                               </FileConfiguration>
                                        </File>
                                        <File
                                                RelativePath="..\platform\graphics\win\GlyphPageTreeNodeCairoWin.cpp"
                                <File
                                        RelativePath="..\platform\text\TextCodecICU.cpp"
                                        >
-                                       <FileConfiguration
-                                               Name="Debug|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
-                                       <FileConfiguration
-                                               Name="Release|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
-                                       <FileConfiguration
-                                               Name="Debug_Cairo_CFLite|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
-                                       <FileConfiguration
-                                               Name="Release_Cairo_CFLite|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
-                                       <FileConfiguration
-                                               Name="Debug_All|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
-                                       <FileConfiguration
-                                               Name="Production|Win32"
-                                               >
-                                               <Tool
-                                                       Name="VCCLCompilerTool"
-                                                       AdditionalOptions="$(AnalyzeWithLargeStack)"
-                                               />
-                                       </FileConfiguration>
                                </File>
                                <File
                                        RelativePath="..\platform\text\TextCodecICU.h"
index 15f5324..7401678 100644 (file)
@@ -5,8 +5,4 @@ if exist "%CONFIGURATIONBUILDDIR%\buildfailed" grep XX%PROJECTNAME%XX "%CONFIGUR
 if errorlevel 1 exit 1
 echo XX%PROJECTNAME%XX > "%CONFIGURATIONBUILDDIR%\buildfailed"
 
-touch "%CONFIGURATIONBUILDDIR%\tmp.cpp"
-cl /analyze /nologo /c "%CONFIGURATIONBUILDDIR%\tmp.cpp" /Fo"%INTDIR%\tmp.obj" 2>&1 | findstr D9040
-if ERRORLEVEL 1 (set EnablePREfast="true") else (set EnablePREfast="false")
-if ERRORLEVEL 1 (set AnalyzeWithLargeStack="/analyze:65536") else (set AnalyzeWithLargeStack="")
 exit /b
index fd89e16..a8d8c98 100644 (file)
@@ -1,3 +1,16 @@
+2011-04-04  Steve Falkenburg  <sfalken@apple.com>
+
+        Reviewed by Adam Roben.
+
+        Remove unused AnalyzeWithLargeStack code from Windows build files
+        https://bugs.webkit.org/show_bug.cgi?id=57771
+        
+        This was used for us to build with prefast automatically,
+        but it is out-of-date and hasn't been used for some time.
+        Removing completely for now.
+
+        * WebKit.vcproj/WebKitLibPreBuild.cmd:
+
 2011-04-01  Adam Roben  <aroben@apple.com>
 
         Remove the WebView's "this" pointer from its HWND when WM_DESTROY is received
index b6f0bd4..82f02e9 100644 (file)
@@ -5,11 +5,6 @@ if exist "%CONFIGURATIONBUILDDIR%\buildfailed" grep XX%PROJECTNAME%XX "%CONFIGUR
 if errorlevel 1 exit 1
 echo XX%PROJECTNAME%XX > "%CONFIGURATIONBUILDDIR%\buildfailed"
 
-touch "%CONFIGURATIONBUILDDIR%\tmp.cpp"
-cl /analyze /nologo /c "%CONFIGURATIONBUILDDIR%\tmp.cpp" /Fo"%INTDIR%\tmp.obj" 2>&1 | findstr D9040
-if ERRORLEVEL 1 (set EnablePREfast="true") else (set EnablePREfast="false")
-if ERRORLEVEL 1 (set AnalyzeWithLargeStack="/analyze:65536") else (set AnalyzeWithLargeStack="")
-
 mkdir 2>NUL "%CONFIGURATIONBUILDDIR%\include\JavaScriptCore"
 xcopy /y /d "%WEBKITLIBRARIESDIR%\include\JavaScriptCore\*" "%CONFIGURATIONBUILDDIR%\include\JavaScriptCore"
 
index a4edc53..5fad09e 100644 (file)
@@ -1,3 +1,16 @@
+2011-04-04  Steve Falkenburg  <sfalken@apple.com>
+
+        Reviewed by Adam Roben.
+
+        Remove unused AnalyzeWithLargeStack code from Windows build files
+        https://bugs.webkit.org/show_bug.cgi?id=57771
+        
+        This was used for us to build with prefast automatically,
+        but it is out-of-date and hasn't been used for some time.
+        Removing completely for now.
+
+        * win/WebKitPreBuild.cmd:
+
 2011-04-04  Anders Carlsson  <andersca@apple.com>
 
         Attempt to fix the Windows build.
index b6f0bd4..82f02e9 100644 (file)
@@ -5,11 +5,6 @@ if exist "%CONFIGURATIONBUILDDIR%\buildfailed" grep XX%PROJECTNAME%XX "%CONFIGUR
 if errorlevel 1 exit 1
 echo XX%PROJECTNAME%XX > "%CONFIGURATIONBUILDDIR%\buildfailed"
 
-touch "%CONFIGURATIONBUILDDIR%\tmp.cpp"
-cl /analyze /nologo /c "%CONFIGURATIONBUILDDIR%\tmp.cpp" /Fo"%INTDIR%\tmp.obj" 2>&1 | findstr D9040
-if ERRORLEVEL 1 (set EnablePREfast="true") else (set EnablePREfast="false")
-if ERRORLEVEL 1 (set AnalyzeWithLargeStack="/analyze:65536") else (set AnalyzeWithLargeStack="")
-
 mkdir 2>NUL "%CONFIGURATIONBUILDDIR%\include\JavaScriptCore"
 xcopy /y /d "%WEBKITLIBRARIESDIR%\include\JavaScriptCore\*" "%CONFIGURATIONBUILDDIR%\include\JavaScriptCore"
 
index bd4b712..bc1e08d 100644 (file)
@@ -1,5 +1,18 @@
 2011-04-04  Steve Falkenburg  <sfalken@apple.com>
 
+        Reviewed by Adam Roben.
+
+        Remove unused AnalyzeWithLargeStack code from Windows build files
+        https://bugs.webkit.org/show_bug.cgi?id=57771
+        
+        This was used for us to build with prefast automatically,
+        but it is out-of-date and hasn't been used for some time.
+        Removing completely for now.
+
+        * win/tools/vsprops/common.vsprops:
+
+2011-04-04  Steve Falkenburg  <sfalken@apple.com>
+
         Reviewed by Brian Weinstein.
 
         Fix Windows build warning.
index 81d439a..c2c419c 100644 (file)
                Name="ConfigurationBuildDir"
                Value="$(WebKitOutputDir)\$(ConfigurationName)"
        />
-  <UserMacro
-               Name="AnalyzeWithLargeStack"
-               Value=""
-       />
        <UserMacro
                Name="ProductionBuild"
                Value="0"