REGRESSION (r205462): Lot of leaks
authorfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Sep 2016 22:01:37 +0000 (22:01 +0000)
committerfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Sep 2016 22:01:37 +0000 (22:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=161946

Reviewed by Saam Barati.

We were forgetting to delete LargeAllocations on VM exit!

* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::~MarkedSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@205998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/heap/MarkedSpace.cpp

index e50c4c6..bd98847 100644 (file)
@@ -1,3 +1,15 @@
+2016-09-15  Filip Pizlo  <fpizlo@apple.com>
+
+        REGRESSION (r205462): Lot of leaks
+        https://bugs.webkit.org/show_bug.cgi?id=161946
+
+        Reviewed by Saam Barati.
+        
+        We were forgetting to delete LargeAllocations on VM exit!
+
+        * heap/MarkedSpace.cpp:
+        (JSC::MarkedSpace::~MarkedSpace):
+
 2016-09-15  Keith Miller  <keith_miller@apple.com>
 
 
index fda4ede..65d46b4 100644 (file)
@@ -203,6 +203,8 @@ MarkedSpace::~MarkedSpace()
         [&] (MarkedBlock::Handle* block) {
             freeBlock(block);
         });
+    for (LargeAllocation* allocation : m_largeAllocations)
+        allocation->destroy();
     ASSERT(!m_blocks.set().size());
 }