Remote Web Inspector: Timeline UI not updating while recording
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Oct 2016 17:07:35 +0000 (17:07 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Oct 2016 17:07:35 +0000 (17:07 +0000)
https://bugs.webkit.org/show_bug.cgi?id=163582
<rdar://problem/28766837>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-10-18
Reviewed by Timothy Hatcher.

* WebProcess/WebPage/RemoteWebInspectorUI.cpp:
(WebKit::RemoteWebInspectorUI::frontendLoaded):
Local inspector windows keep the web view alive and toggle the
WebInspector.visible state depending on whether or not an inspector is
open. Remote Inspector windows go away when closed, so they can always
be marked as open. This matches earlier remote inspector behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@207466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebPage/RemoteWebInspectorUI.cpp

index d15d076..7a2354f 100644 (file)
@@ -1,3 +1,18 @@
+2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Remote Web Inspector: Timeline UI not updating while recording
+        https://bugs.webkit.org/show_bug.cgi?id=163582
+        <rdar://problem/28766837>
+
+        Reviewed by Timothy Hatcher.
+
+        * WebProcess/WebPage/RemoteWebInspectorUI.cpp:
+        (WebKit::RemoteWebInspectorUI::frontendLoaded):
+        Local inspector windows keep the web view alive and toggle the
+        WebInspector.visible state depending on whether or not an inspector is
+        open. Remote Inspector windows go away when closed, so they can always
+        be marked as open. This matches earlier remote inspector behavior.
+
 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
 
         [MediaStream] Resolve constraints and enumerate devices in the UI process
index 7ff20a6..5cbf2a2 100644 (file)
@@ -95,6 +95,8 @@ void RemoteWebInspectorUI::frontendLoaded()
 {
     m_frontendAPIDispatcher.frontendLoaded();
 
+    m_frontendAPIDispatcher.dispatchCommand(ASCIILiteral("setIsVisible"), true);
+
     bringToFront();
 }