Unreviewed, comment improvement over r238166.
authorjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Nov 2018 21:31:34 +0000 (21:31 +0000)
committerjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Nov 2018 21:31:34 +0000 (21:31 +0000)
* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):
* UIProcess/WebAuthentication/fido/CtapHidAuthenticator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidAuthenticator.h

index 9ed7d7c..858ec3b 100644 (file)
@@ -1,3 +1,11 @@
+2018-11-14  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Unreviewed, comment improvement over r238166.
+
+        * UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
+        (WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):
+        * UIProcess/WebAuthentication/fido/CtapHidAuthenticator.h:
+
 2018-11-15  Jiewen Tan  <jiewen_tan@apple.com>
 
         [WebAuthN] Use a real nonce for CTAPHID_INIT
index 1dd81ed..10577ee 100644 (file)
@@ -611,7 +611,6 @@ void WKWebsiteDataStoreSetWebAuthenticationMockConfiguration(WKWebsiteDataStoreR
         if (subStage == "msg")
             hid.subStage = MockWebAuthenticationConfiguration::Hid::SubStage::Msg;
 
-
         auto error = WebKit::toImpl(static_cast<WKStringRef>(WKDictionaryGetItemForKey(hidRef, adoptWK(WKStringCreateWithUTF8CString("Error")).get())))->string();
         if (error == "success")
             hid.error = MockWebAuthenticationConfiguration::Hid::Error::Success;
index 968ece2..fdf6279 100644 (file)
@@ -36,7 +36,6 @@ class CtapHidDriver;
 
 class CtapHidAuthenticator final : public Authenticator {
 public:
-    // FIXME(191526): Should store AuthenticatorSupportedOptions::UserVerificationAvailability.
     static Ref<CtapHidAuthenticator> create(std::unique_ptr<CtapHidDriver>&& driver, fido::AuthenticatorGetInfoResponse&& info)
     {
         return adoptRef(*new CtapHidAuthenticator(WTFMove(driver), WTFMove(info)));