garden-o-matic: bring back party time!
authortony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Nov 2011 22:01:07 +0000 (22:01 +0000)
committertony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Nov 2011 22:01:07 +0000 (22:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=71582

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif [moved from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif with 100% similarity]
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css
Tools/ChangeLog

index d066403..db10f11 100644 (file)
@@ -32,7 +32,7 @@ James, a web developer from Birmingham, UK.
                                          script-src 'self' file: https://ajax.googleapis.com;
                                          style-src 'self' 'unsafe-inline' file: https://ajax.googleapis.com http://fonts.googleapis.com;
                                          font-src http://themes.googleusercontent.com;
-                                         img-src https://ajax.googleapis.com http://build.chromium.org;
+                                         img-src https://ajax.googleapis.com http://build.chromium.org file:;
                                          frame-src http://build.chromium.org;
                                          connect-src http://trac.webkit.org http://build.chromium.org http://127.0.0.1:8127">
 <title>Garden-O-Matic</title>
index 7e85de8..0c99efb 100644 (file)
@@ -329,6 +329,10 @@ base.UpdateTracker.prototype = {
     {
         return this._items[key];
     },
+    length: function()
+    {
+        return Object.keys(this._items).length;
+    },
     /*
         Callback parameters are:
         - item
index 05dacdb..0e98a1d 100644 (file)
@@ -196,6 +196,10 @@ controllers.UnexpectedFailures = base.extends(FailureStreamController, {
         var failure = FailureStreamController.prototype.update.call(this, failureAnalysis);
         failure.updateBuilderResults(model.buildersInFlightForRevision(this._impliedFirstFailingRevision(failureAnalysis)));
     },
+    length: function()
+    {
+        return this._testFailures.length();
+    },
     onBlame: function(failure, commitData)
     {
         failure.pinToCommitData(commitData);
index 29cfb9d..e36fb1c 100644 (file)
@@ -51,6 +51,10 @@ function update()
             updating.update('Analyzing test failures ... ' + ++numberOfTestsAnalyzed + ' tests analyzed.');
             g_unexpectedFailuresController.update(failureAnalysis);
         }, function() {
+            if (!g_unexpectedFailuresController.length())
+                $('#onebar').addClass('partytime');
+            else
+                $('#onebar').removeClass('partytime');
             g_unexpectedFailuresController.purge();
             updating.dismiss();
         });
index 0505965..7f4a94c 100644 (file)
     border-left: none;
     border-radius: 0px;
 }
+
+#summary {
+    min-height: 360px;
+}
+
+#onebar.partytime #summary {
+    background: url(../images/partytime.gif) top center no-repeat;
+}
index 73d3d27..146cea5 100644 (file)
@@ -1,3 +1,17 @@
+2011-11-04  Tony Chang  <tony@chromium.org>
+
+        garden-o-matic: bring back party time!
+        https://bugs.webkit.org/show_bug.cgi?id=71582
+
+        Reviewed by Adam Barth.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
+
 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
 
         [EFL] DRT: Fix the order of the items in the dumped history list.