https://bugs.webkit.org/show_bug.cgi?id=191834
Reviewed by Myles C. Maxfield.
Source/WebCore:
Give defaultFixedFontSize a reasonable default value in Settings, so that clients
who omit to set it (like SVGImages) don't get broken rendering.
Test: svg/text/monospace-text-size-in-img.html
* page/Settings.yaml:
LayoutTests:
The test has an x offset in the text transform to work around a different bug
with text position (webkit.org/b/191871).
* svg/text/monospace-text-size-in-img-expected.html: Added.
* svg/text/monospace-text-size-in-img.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2018-11-22 Simon Fraser <simon.fraser@apple.com>
+
+ Extremely small monospace text size when SVG is included as an img
+ https://bugs.webkit.org/show_bug.cgi?id=191834
+
+ Reviewed by Myles C. Maxfield.
+
+ The test has an x offset in the text transform to work around a different bug
+ with text position (webkit.org/b/191871).
+
+ * svg/text/monospace-text-size-in-img-expected.html: Added.
+ * svg/text/monospace-text-size-in-img.html: Added.
+
2018-11-22 Javier Fernandez <jfernandez@igalia.com>
Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: baseline
--- /dev/null
+<!DOCTYPE html>
+<html>
+<head>
+ <style>
+ svg {
+ display: block;
+ margin: 10px;
+ border: 1px solid blue;
+ }
+ </style>
+</head>
+<body>
+ <svg xmlns:xlink="http://www.w3.org/1999/xlink" width="220" height="60" viewbox="0 0 200 60">
+ <text font-family="monospace" transform="translate(0, 50) scale(5)">ABC</text>
+ </svg>
+</body>
+</html>
--- /dev/null
+<!DOCTYPE html>
+<html>
+<head>
+ <style>
+ img {
+ display: block;
+ margin: 10px;
+ border: 1px solid blue;
+ }
+ </style>
+</head>
+<body>
+ <img src="data:image/svg+xml;charset=utf-8,%3Csvg xmlns:xlink='http://www.w3.org/1999/xlink' xmlns='http://www.w3.org/2000/svg' width='220' height='60' viewbox='0 0 200 60'%3E%3Ctext font-family='monospace' transform='translate(10, 50) scale(5)'%3EABC%3C/text%3E%3C/svg%3E" />
+</body>
+</html>
+2018-11-22 Simon Fraser <simon.fraser@apple.com>
+
+ Extremely small monospace text size when SVG is included as an img
+ https://bugs.webkit.org/show_bug.cgi?id=191834
+
+ Reviewed by Myles C. Maxfield.
+
+ Give defaultFixedFontSize a reasonable default value in Settings, so that clients
+ who omit to set it (like SVGImages) don't get broken rendering.
+
+ Test: svg/text/monospace-text-size-in-img.html
+
+ * page/Settings.yaml:
+
2018-11-22 Javier Fernandez <jfernandez@igalia.com>
Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: baseline
onChange: setNeedsRecalcStyleInAllFrames
defaultFixedFontSize:
type: int
- initial: 0
+ initial: 13
onChange: setNeedsRecalcStyleInAllFrames
editingBehaviorType:
git://git.webkit.org / WebKit-https.git / commitdiff