2009-04-21 Darin Adler <darin@apple.com>
authordarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 Apr 2009 19:38:01 +0000 (19:38 +0000)
committerdarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 Apr 2009 19:38:01 +0000 (19:38 +0000)
        Reviewed by Adele Peterson.

        Fix some tests that are depending on Mac vs. Windows selection quirks accidentally.
        Added failing tests to the skipped list for SnowLeopard.

        * editing/resources/select-all-iframe-src.html: Moved.
        * editing/selection/resources/select-all-iframe-src.html: Moved from
        editing/resources/select-all-iframe-src.html, since this is used by a test in the
        selection directory. Changed mouse coordinates to be farther to the right so we
        don't depend on the rule for what's selected when you click below text on the last line.
        * editing/selection/select-all-iframe.html: Updated for new location of file above.

        * fast/events/standalone-image-drag-to-editable.html: Changed mouse coordinates to be
        farther to the right so we don't depend on the rule for what's selected when you click
        below text on the last line.

        * platform/mac-snowleopard/Skipped: Added some tests to the Skipped list.

        * svg/custom/pointer-events-path.svg: Clear the selection at the end of the test so it's
        not in the test results. Also removed unneeded use of the layout test controller.

        * platform/mac/editing/selection/select-all-iframe-expected.checksum: Generated new results.
        * platform/mac/editing/selection/select-all-iframe-expected.png: Ditto.
        * platform/mac/editing/selection/select-all-iframe-expected.txt: Ditto.
        * platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Ditto.
        * platform/mac/fast/events/standalone-image-drag-to-editable-expected.png: Ditto.
        * platform/mac/fast/events/standalone-image-drag-to-editable-expected.txt: Ditto.
        * platform/mac/svg/custom/pointer-events-path-expected.checksum: Ditto.
        * platform/mac/svg/custom/pointer-events-path-expected.png: Ditto.
        * platform/mac/svg/custom/pointer-events-path-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/selection/resources/select-all-iframe-src.html [moved from LayoutTests/editing/resources/select-all-iframe-src.html with 80% similarity]
LayoutTests/editing/selection/select-all-iframe.html
LayoutTests/fast/events/standalone-image-drag-to-editable.html
LayoutTests/platform/mac-snowleopard/Skipped
LayoutTests/platform/mac/editing/selection/select-all-iframe-expected.checksum
LayoutTests/platform/mac/editing/selection/select-all-iframe-expected.png
LayoutTests/platform/mac/editing/selection/select-all-iframe-expected.txt
LayoutTests/platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum
LayoutTests/platform/mac/fast/events/standalone-image-drag-to-editable-expected.png
LayoutTests/platform/mac/fast/events/standalone-image-drag-to-editable-expected.txt
LayoutTests/platform/mac/svg/custom/pointer-events-path-expected.checksum
LayoutTests/platform/mac/svg/custom/pointer-events-path-expected.png
LayoutTests/platform/mac/svg/custom/pointer-events-path-expected.txt
LayoutTests/svg/custom/pointer-events-path.svg

index 1d41d35..c340e52 100644 (file)
@@ -1,3 +1,36 @@
+2009-04-21  Darin Adler  <darin@apple.com>
+
+        Reviewed by Adele Peterson.
+
+        Fix some tests that are depending on Mac vs. Windows selection quirks accidentally.
+        Added failing tests to the skipped list for SnowLeopard.
+
+        * editing/resources/select-all-iframe-src.html: Moved.
+        * editing/selection/resources/select-all-iframe-src.html: Moved from
+        editing/resources/select-all-iframe-src.html, since this is used by a test in the
+        selection directory. Changed mouse coordinates to be farther to the right so we
+        don't depend on the rule for what's selected when you click below text on the last line.
+        * editing/selection/select-all-iframe.html: Updated for new location of file above.
+
+        * fast/events/standalone-image-drag-to-editable.html: Changed mouse coordinates to be
+        farther to the right so we don't depend on the rule for what's selected when you click
+        below text on the last line.
+
+        * platform/mac-snowleopard/Skipped: Added some tests to the Skipped list.
+
+        * svg/custom/pointer-events-path.svg: Clear the selection at the end of the test so it's
+        not in the test results. Also removed unneeded use of the layout test controller.
+
+        * platform/mac/editing/selection/select-all-iframe-expected.checksum: Generated new results.
+        * platform/mac/editing/selection/select-all-iframe-expected.png: Ditto.
+        * platform/mac/editing/selection/select-all-iframe-expected.txt: Ditto.
+        * platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Ditto.
+        * platform/mac/fast/events/standalone-image-drag-to-editable-expected.png: Ditto.
+        * platform/mac/fast/events/standalone-image-drag-to-editable-expected.txt: Ditto.
+        * platform/mac/svg/custom/pointer-events-path-expected.checksum: Ditto.
+        * platform/mac/svg/custom/pointer-events-path-expected.png: Ditto.
+        * platform/mac/svg/custom/pointer-events-path-expected.txt: Ditto.
+
 2009-04-21  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by Darin Adler.
@@ -1,4 +1,4 @@
-<script src=../editing.js language="JavaScript" type="text/JavaScript"></script>
+<script src="../../editing.js" language="JavaScript" type="text/JavaScript"></script>
 <script>
 function editingTest() {
     if (!window.layoutTestController)
@@ -7,7 +7,7 @@ function editingTest() {
     window.layoutTestController.waitUntilDone();
     
     // Give focus to the subframe so that Select All will operate on it, and not the main frame.
-    eventSender.mouseMoveTo(50, 50);
+    eventSender.mouseMoveTo(100, 50);
     eventSender.mouseDown();
     eventSender.mouseUp();
     
@@ -24,4 +24,4 @@ function editingTest() {
 runEditingTest();
 </script>
 
-</body>
\ No newline at end of file
+</body>
index 18cd72e..310fb1a 100644 (file)
@@ -3,7 +3,7 @@ if (window.layoutTestController)
      layoutTestController.dumpEditingCallbacks();
 </script>
 
-<iframe id="iframe" src="../resources/select-all-iframe-src.html"></iframe><br><br>
+<iframe id="iframe" src="resources/select-all-iframe-src.html"></iframe><br><br>
 <p><b>This test uses the eventSender to do a mouse click to focus the subframe.  It won't run interactively.</b>  To run it manually, click on the iframe, Select All, then hit delete.</p>
 Selecting all the content in a contenteditable iframe should select the iframe itself (to help the user delete the iframe) only if the iframe is in an editable region.  This test loads ../resources/select-all-iframe-src.html into an iframe.  That file does a Select All + Delete.  Two things should happen:
 
index 752e831..31e5458 100644 (file)
@@ -8,7 +8,7 @@
       eventSender.mouseMoveTo(20, 120);
       eventSender.mouseDown();
       eventSender.leapForward(500);
-      eventSender.mouseMoveTo(20, 50);
+      eventSender.mouseMoveTo(200, 50);
       eventSender.mouseUp();
     }
     var numFramesLoaded = 0;
index 9ff27f4..071f7e1 100644 (file)
@@ -25,3 +25,19 @@ http/tests/ssl/verify-ssl-enabled.php
 
 # <rdar://problem/6778137> post-goback-repost-policy.html is failing
 http/tests/navigation/post-goback-repost-policy.html
+
+# Radar bugs needed for these
+fast/canvas/set-colors.html
+fast/dom/frame-loading-via-document-write.html
+platform/mac/fast/text/myanmar-shaping.html
+platform/mac/fast/text/thai-combining-mark-positioning.html
+svg/W3C-SVG-1.1/coords-viewattr-01-b.svg
+svg/W3C-SVG-1.1/coords-viewattr-02-b.svg
+svg/W3C-SVG-1.1/render-elems-03-t.svg
+svg/batik/paints/patternRegionA.svg
+svg/custom/path-bad-data.svg
+svg/custom/pattern-deep-referencing.svg
+svg/custom/preserve-aspect-ratio-syntax.svg
+svg/custom/stroke-width-click.svg
+svg/custom/viewbox-syntax.svg
+svg/hixie/perf/007.xml
index 6d18033..fc467df 100644 (file)
Binary files a/LayoutTests/platform/mac/editing/selection/select-all-iframe-expected.png and b/LayoutTests/platform/mac/editing/selection/select-all-iframe-expected.png differ
index b405deb..842c2a3 100644 (file)
@@ -1,9 +1,9 @@
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of BODY > HTML > #document to 4 of BODY > HTML > #document
 EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 11 of #text > DIV > BODY > HTML > #document to 11 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 11 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 11 of #text > DIV > BODY > HTML > #document to 11 of #text > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 11 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 11 of #text > DIV > BODY > HTML > #document
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
index 10b90fe..c96a8af 100644 (file)
Binary files a/LayoutTests/platform/mac/fast/events/standalone-image-drag-to-editable-expected.png and b/LayoutTests/platform/mac/fast/events/standalone-image-drag-to-editable-expected.png differ
index 9d2a7aa..08e76a2 100644 (file)
@@ -13,13 +13,10 @@ layer at (0,0) size 800x600
                 RenderText {#text} at (1,1) size 689x18
                   text run at (1,1) width 689: "This layout test is checks that we don't crash when a stand alone image is dragged into a content editable div. "
                 RenderBR {BR} at (690,15) size 0x0
-                RenderInline {A} at (0,0) size 174x18 [color=#0000EE]
-                  RenderText {#text} at (1,30) size 20x18
-                    text run at (1,30) width 20: "rda"
-                  RenderImage {IMG} at (21,19) size 25x25
-                  RenderText {#text} at (46,30) size 129x18
-                    text run at (46,30) width 129: "r://problem/5021127"
-                RenderText {#text} at (0,0) size 0x0
+                RenderInline {A} at (0,0) size 149x18 [color=#0000EE]
+                  RenderText {#text} at (1,30) size 149x18
+                    text run at (1,30) width 149: "rdar://problem/5021127"
+                RenderImage {IMG} at (150,19) size 25x25
       RenderFrame {FRAME} at (0,106) size 800x100
         layer at (0,0) size 800x100
           RenderView at (0,0) size 800x100
index 56d7433..2d03f80 100644 (file)
Binary files a/LayoutTests/platform/mac/svg/custom/pointer-events-path-expected.png and b/LayoutTests/platform/mac/svg/custom/pointer-events-path-expected.png differ
index b1ba003..1b711a3 100644 (file)
@@ -615,4 +615,3 @@ layer at (0,0) size 800x600
       RenderSVGText {text} at (504,583) size 28x18 contains 1 chunk(s)
         RenderSVGInlineText {#text} at (0,-14) size 28x18
           chunk 1 text run 1 at (504.00,583.00) startOffset 0 endOffset 4 width 28.00: "miss"
-caret: position 0 of child 0 {#text} of child 9 {text} of child 0 {svg} of document
index c768db0..81244cb 100644 (file)
@@ -7,10 +7,6 @@
   </style>
   <script type="text/javascript">
   <![CDATA[
-    
-    if (window.layoutTestController)
-        layoutTestController.waitUntilDone();
-  
     var visibleValues = [ 'visible', 'hidden' ];
     var fillValues = ['none', 'orange' ];
     var strokeValues = ['none', 'blue' ];
         xOffset = leftEdge;
         yOffset += rectSpacing;
       }
-      
-      if (window.layoutTestController)
-        layoutTestController.notifyDone();
+      getSelection().removeAllRanges();
     }
   ]]>
   </script>