Remove unused WKPageSetMemoryCacheClientCallsEnabled API.
authorakling@apple.com <akling@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 24 Apr 2014 03:56:09 +0000 (03:56 +0000)
committerakling@apple.com <akling@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 24 Apr 2014 03:56:09 +0000 (03:56 +0000)
<https://webkit.org/b/132098>

This API was added to WK2 back in 2011 but never actually used.

Reviewed by Anders Carlsson.

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageSetMemoryCacheClientCallsEnabled): Deleted.
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled): Deleted.
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setMemoryCacheMessagesEnabled): Deleted.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/Shared/WebPageCreationParameters.cpp
Source/WebKit2/Shared/WebPageCreationParameters.h
Source/WebKit2/UIProcess/API/C/WKPage.cpp
Source/WebKit2/UIProcess/API/C/WKPage.h
Source/WebKit2/UIProcess/WebPageProxy.cpp
Source/WebKit2/UIProcess/WebPageProxy.h
Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Source/WebKit2/WebProcess/WebPage/WebPage.h
Source/WebKit2/WebProcess/WebPage/WebPage.messages.in

index 1e682bd..3caf563 100644 (file)
@@ -1,3 +1,30 @@
+2014-04-23  Andreas Kling  <akling@apple.com>
+
+        Remove unused WKPageSetMemoryCacheClientCallsEnabled API.
+        <https://webkit.org/b/132098>
+
+        This API was added to WK2 back in 2011 but never actually used.
+
+        Reviewed by Anders Carlsson.
+
+        * Shared/WebPageCreationParameters.cpp:
+        (WebKit::WebPageCreationParameters::encode):
+        (WebKit::WebPageCreationParameters::decode):
+        * Shared/WebPageCreationParameters.h:
+        * UIProcess/API/C/WKPage.cpp:
+        (WKPageSetMemoryCacheClientCallsEnabled): Deleted.
+        * UIProcess/API/C/WKPage.h:
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::WebPageProxy):
+        (WebKit::WebPageProxy::creationParameters):
+        (WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled): Deleted.
+        * UIProcess/WebPageProxy.h:
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::WebPage):
+        (WebKit::WebPage::setMemoryCacheMessagesEnabled): Deleted.
+        * WebProcess/WebPage/WebPage.h:
+        * WebProcess/WebPage/WebPage.messages.in:
+
 2014-04-23  Simon Fraser  <simon.fraser@apple.com>
 
         [iOS WK2] Make -webkit-overflow-scrolling:touch work
index 4e3ceb4..163742b 100644 (file)
@@ -41,7 +41,6 @@ void WebPageCreationParameters::encode(IPC::ArgumentEncoder& encoder) const
     encoder << drawsBackground;
     encoder << drawsTransparentBackground;
     encoder << underlayColor;
-    encoder << areMemoryCacheClientCallsEnabled;
     encoder << useFixedLayout;
     encoder << fixedLayoutSize;
     encoder.encodeEnum(paginationMode);
@@ -95,8 +94,6 @@ bool WebPageCreationParameters::decode(IPC::ArgumentDecoder& decoder, WebPageCre
         return false;
     if (!decoder.decode(parameters.underlayColor))
         return false;
-    if (!decoder.decode(parameters.areMemoryCacheClientCallsEnabled))
-        return false;
     if (!decoder.decode(parameters.useFixedLayout))
         return false;
     if (!decoder.decode(parameters.fixedLayoutSize))
index 147c0f4..87dab3a 100644 (file)
@@ -69,8 +69,6 @@ struct WebPageCreationParameters {
 
     WebCore::Color underlayColor;
 
-    bool areMemoryCacheClientCallsEnabled;
-
     bool useFixedLayout;
     WebCore::IntSize fixedLayoutSize;
 
index 3ddb210..c840e82 100644 (file)
@@ -295,11 +295,6 @@ double WKPageGetEstimatedProgress(WKPageRef pageRef)
     return toImpl(pageRef)->estimatedProgress();
 }
 
-void WKPageSetMemoryCacheClientCallsEnabled(WKPageRef pageRef, bool memoryCacheClientCallsEnabled)
-{
-    toImpl(pageRef)->setMemoryCacheClientCallsEnabled(memoryCacheClientCallsEnabled);
-}
-
 WKStringRef WKPageCopyUserAgent(WKPageRef pageRef)
 {
     return toCopiedAPI(toImpl(pageRef)->userAgent());
index c205ec0..0c5cb8c 100644 (file)
@@ -108,8 +108,6 @@ WK_EXPORT double WKPageGetEstimatedProgress(WKPageRef page);
 
 WK_EXPORT uint64_t WKPageGetRenderTreeSize(WKPageRef page);
 
-WK_EXPORT void WKPageSetMemoryCacheClientCallsEnabled(WKPageRef page, bool memoryCacheClientCallsEnabled);
-
 WK_EXPORT WKInspectorRef WKPageGetInspector(WKPageRef page);
 
 WK_EXPORT WKVibrationRef WKPageGetVibration(WKPageRef page);
index 707a6f6..5b94730 100644 (file)
@@ -283,7 +283,6 @@ WebPageProxy::WebPageProxy(PageClient& pageClient, WebProcessProxy& process, uin
     , m_layerHostingMode(LayerHostingMode::InProcess)
     , m_drawsBackground(true)
     , m_drawsTransparentBackground(false)
-    , m_areMemoryCacheClientCallsEnabled(true)
     , m_useFixedLayout(false)
     , m_suppressScrollbarAnimations(false)
     , m_paginationMode(Pagination::Unpaginated)
@@ -2032,18 +2031,6 @@ void WebPageProxy::pageZoomFactorDidChange(double zoomFactor)
     m_pageZoomFactor = zoomFactor;
 }
 
-void WebPageProxy::setMemoryCacheClientCallsEnabled(bool memoryCacheClientCallsEnabled)
-{
-    if (!isValid())
-        return;
-
-    if (m_areMemoryCacheClientCallsEnabled == memoryCacheClientCallsEnabled)
-        return;
-
-    m_areMemoryCacheClientCallsEnabled = memoryCacheClientCallsEnabled;
-    m_process->send(Messages::WebPage::SetMemoryCacheMessagesEnabled(memoryCacheClientCallsEnabled), m_pageID);
-}
-
 void WebPageProxy::findStringMatches(const String& string, FindOptions options, unsigned maxMatchCount)
 {
     if (string.isEmpty()) {
@@ -4228,7 +4215,6 @@ WebPageCreationParameters WebPageProxy::creationParameters()
     parameters.drawsBackground = m_drawsBackground;
     parameters.drawsTransparentBackground = m_drawsTransparentBackground;
     parameters.underlayColor = m_underlayColor;
-    parameters.areMemoryCacheClientCallsEnabled = m_areMemoryCacheClientCallsEnabled;
     parameters.useFixedLayout = m_useFixedLayout;
     parameters.fixedLayoutSize = m_fixedLayoutSize;
     parameters.suppressScrollbarAnimations = m_suppressScrollbarAnimations;
index 55d4a05..354dfc9 100644 (file)
@@ -811,8 +811,6 @@ public:
     void pageScaleFactorDidChange(double);
     void pageZoomFactorDidChange(double);
 
-    void setMemoryCacheClientCallsEnabled(bool);
-
     // Find.
     void findString(const String&, FindOptions, unsigned maxMatchCount);
     void findStringMatches(const String&, FindOptions, unsigned maxMatchCount);
@@ -1521,8 +1519,6 @@ private:
     WebCore::Color m_underlayColor;
     WebCore::Color m_pageExtendedBackgroundColor;
 
-    bool m_areMemoryCacheClientCallsEnabled;
-
     bool m_useFixedLayout;
     WebCore::IntSize m_fixedLayoutSize;
 
index f5637f5..e3ad2e2 100644 (file)
@@ -390,8 +390,6 @@ WebPage::WebPage(uint64_t pageID, const WebPageCreationParameters& parameters)
     setPageLength(parameters.pageLength);
     setGapBetweenPages(parameters.gapBetweenPages);
 
-    setMemoryCacheMessagesEnabled(parameters.areMemoryCacheClientCallsEnabled);
-
     // If the page is created off-screen, its visibilityState should be prerender.
     m_page->setViewState(m_viewState);
     if (!isVisible())
@@ -3731,11 +3729,6 @@ void WebPage::runModal()
     ASSERT(!m_isRunningModal);
 }
 
-void WebPage::setMemoryCacheMessagesEnabled(bool memoryCacheMessagesEnabled)
-{
-    m_page->setMemoryCacheClientCallsEnabled(memoryCacheMessagesEnabled);
-}
-
 bool WebPage::canHandleRequest(const WebCore::ResourceRequest& request)
 {
     if (SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument(request.url().protocol()))
index e5cbb74..4442fe7 100644 (file)
@@ -668,8 +668,6 @@ public:
     void setDeviceScaleFactor(float);
     float deviceScaleFactor() const;
 
-    void setMemoryCacheMessagesEnabled(bool);
-
     void forceRepaintWithoutCallback();
 
     void unmarkAllMisspellings();
index dd34a68..bc3488e 100644 (file)
@@ -271,8 +271,6 @@ messages -> WebPage LegacyReceiver {
     SetMediaVolume(float volume)
     SetMayStartMediaWhenInWindow(bool mayStartMedia)
 
-    SetMemoryCacheMessagesEnabled(bool memoryCacheMessagesEnabled)
-
     // FIXME: This a dummy message, to avoid breaking the build for platforms that don't require
     // any synchronous messages, and should be removed when <rdar://problem/8775115> is fixed.
     Dummy() -> (bool dummyReturn)