Unreviewed, fix unused variable warnings in release builds
authormcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 May 2019 15:39:31 +0000 (15:39 +0000)
committermcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 May 2019 15:39:31 +0000 (15:39 +0000)
Source/WebKit:

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::clearWebProcessHasUploads):

Source/WTF:

* wtf/URLHelpers.cpp:
(WTF::URLHelpers::escapeUnsafeCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WTF/ChangeLog
Source/WTF/wtf/URLHelpers.cpp
Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebProcessPool.cpp

index 3742b18..f409f05 100644 (file)
@@ -1,3 +1,10 @@
+2019-05-13  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed, fix unused variable warnings in release builds
+
+        * wtf/URLHelpers.cpp:
+        (WTF::URLHelpers::escapeUnsafeCharacters):
+
 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
 
         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
index 2961a48..f186267 100644 (file)
@@ -770,8 +770,8 @@ static String escapeUnsafeCharacters(const String& sourceBuffer)
             uint8_t utf8Buffer[4];
             size_t offset = 0;
             UBool failure = false;
-            U8_APPEND(utf8Buffer, offset, 4, c, failure)
-            ASSERT(!failure);
+            U8_APPEND(utf8Buffer, offset, 4, c, failure);
+            ASSERT_UNUSED(failure, !failure);
 
             for (size_t j = 0; j < offset; ++j) {
                 outBuffer.append('%');
index 244ae3d..c2913ae 100644 (file)
@@ -1,3 +1,10 @@
+2019-05-13  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed, fix unused variable warnings in release builds
+
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::clearWebProcessHasUploads):
+
 2019-05-12  Takashi Komori  <Takashi.Komori@sony.com>
 
         [Curl] Suppress extra didReceiveAuthenticationChallenge call when accessing a server which checks basic auth.
index 9376da5..0c6d1a8 100644 (file)
@@ -2555,7 +2555,7 @@ void WebProcessPool::clearWebProcessHasUploads(ProcessIdentifier processID)
     ASSERT_UNUSED(result, result);
 
     auto* process = WebProcessProxy::processForIdentifier(processID);
-    ASSERT(process);
+    ASSERT_UNUSED(process, process);
     RELEASE_LOG(ProcessSuspension, "Web process pid %u no longer has uploads in progress", (unsigned)process->processIdentifier());
 
     if (m_processesWithUploads.isEmpty()) {