Enable CANVAS_PATH flag
authorkrit@webkit.org <krit@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Feb 2013 22:14:04 +0000 (22:14 +0000)
committerkrit@webkit.org <krit@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Feb 2013 22:14:04 +0000 (22:14 +0000)
https://bugs.webkit.org/show_bug.cgi?id=108508

Reviewed by Simon Fraser.

Enable CANVAS_PATH flag on trunk.

.:

Existing tests cover the feature.

* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Existing tests cover the feature.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Existing tests cover the feature.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Existing tests cover the feature.

* fast/canvas/canvas-path-object-expected.txt:
* inspector/profiler/canvas2d/canvas2d-api-changes.html:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

22 files changed:
ChangeLog
LayoutTests/ChangeLog
LayoutTests/fast/canvas/canvas-path-object-expected.txt
LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes.html
LayoutTests/platform/chromium/TestExpectations
LayoutTests/platform/efl/TestExpectations
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/mac/TestExpectations
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Source/WTF/wtf/FeatureDefines.h
Source/WebCore/ChangeLog
Source/WebCore/Configurations/FeatureDefines.xcconfig
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/features.gypi
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
Source/WebKit2/ChangeLog
Source/WebKit2/Configurations/FeatureDefines.xcconfig
Source/cmake/WebKitFeatures.cmake
Tools/ChangeLog
Tools/Scripts/webkitperl/FeatureList.pm

index 0bcd068..6f3111d 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2013-02-20  Dirk Schulze  <krit@webkit.org>
+
+        Enable CANVAS_PATH flag
+        https://bugs.webkit.org/show_bug.cgi?id=108508
+
+        Reviewed by Simon Fraser.
+
+        Enable CANVAS_PATH flag on trunk.
+
+        Existing tests cover the feature.
+
+        * Source/cmake/WebKitFeatures.cmake:
+
 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
 
         Unreviewed build fix.
index adafeb2..91c7189 100644 (file)
@@ -1,3 +1,21 @@
+2013-02-20  Dirk Schulze  <krit@webkit.org>
+
+        Enable CANVAS_PATH flag
+        https://bugs.webkit.org/show_bug.cgi?id=108508
+
+        Reviewed by Simon Fraser.
+
+        Enable CANVAS_PATH flag on trunk.
+
+        Existing tests cover the feature.
+
+        * fast/canvas/canvas-path-object-expected.txt:
+        * inspector/profiler/canvas2d/canvas2d-api-changes.html:
+        * platform/chromium/TestExpectations:
+        * platform/efl/TestExpectations:
+        * platform/gtk/TestExpectations:
+        * platform/mac/TestExpectations:
+
 2013-02-20  Ian Vollick <vollick@chromium.org>
 
         [chromium] Unreviewed gardening.
index d868764..5de22bc 100644 (file)
@@ -1,11 +1,19 @@
-CONSOLE MESSAGE: line 5: ReferenceError: Can't find variable: Path
 Ensure that the constructor for Path object and dependent functions exist.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
 PASS typeof document.getElementById is "function"
-FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined).
+PASS path is an instance of Path
+PASS typeof path.closePath is "function"
+PASS typeof path.moveTo is "function"
+PASS typeof path.lineTo is "function"
+PASS typeof path.quadraticCurveTo is "function"
+PASS typeof path.bezierCurveTo is "function"
+PASS typeof path.arcTo is "function"
+PASS typeof path.arc is "function"
+PASS typeof path.rect is "function"
+PASS successfullyParsed is true
 
 TEST COMPLETE
 
index 5920d8a..61f746e 100644 (file)
@@ -10,6 +10,7 @@ var CanvasRenderingContext2DResource = {};
  * @type {Array.<string>}
  */
 CanvasRenderingContext2DResource.AttributeProperties = [
+    "currentPath",
     "strokeStyle",
     "fillStyle",
     "globalAlpha",
index 032aa68..067a697 100644 (file)
@@ -4321,12 +4321,6 @@ webkit.org/b/109136 platform/chromium/fast/forms/calendar-picker/calendar-picker
 webkit.org/b/109136 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html [ ImageOnlyFailure Pass ] 
 webkit.org/b/109158 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html [ ImageOnlyFailure Pass ] 
 
-# Rebaseline after currentPath
-webkit.org/b/108246 fast/canvas/canvas-currentPath.html [ Failure ]
-webkit.org/b/108246 platform/chromium/virtual/gpu/fast/canvas/canvas-currentPath.html [ Failure ]
-webkit.org/b/108246 fast/canvas/canvas-currentPath-crash.html [ Failure ]
-webkit.org/b/108246 platform/chromium/virtual/gpu/fast/canvas/canvas-currentPath-crash.html [ Failure ]
-
 # Broken by Skia flag changes in r139445
 crbug.com/169550 [ Debug ] fast/lists/big-list-marker.html [ Crash ]
 crbug.com/169550 [ Debug ] platform/chromium/virtual/deferred/fast/images/icon-decoding.html [ Crash ]
@@ -4348,14 +4342,6 @@ webkit.org/b/106858 [ Linux Win Debug ] scrollingcoordinator/non-fast-scrollable
 webkit.org/b/106858 [ Mac Debug ] scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ ImageOnlyFailure ]
 webkit.org/b/106858 [ Linux Win Debug ] scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ ImageOnlyFailure Pass ]
 
-
-# Needs rebaseline after enabling CANVAS_PATH.
-webkit.org/b/108508 fast/canvas/canvas-path-constructors.html [ Failure ]
-webkit.org/b/108508 platform/chromium/virtual/gpu/fast/canvas/canvas-path-constructors.html [ Failure ]
-webkit.org/b/108508 fast/canvas/canvas-path-object.html [ Failure ]
-webkit.org/b/108508 platform/chromium/virtual/gpu/fast/canvas/canvas-path-object.html [ Failure ]
-webkit.org/b/108508 inspector/profiler/canvas2d/canvas2d-api-changes.html [ Failure ]
-
 # This is won't fix, as the debug and release versions differ.
 
 webkit.org/b/107204 fast/events/touch/multi-touch-inside-iframes.html [ Pass Failure ]
index 1ca81fd..8902815 100644 (file)
@@ -1797,10 +1797,6 @@ inspector/editor/text-editor-word-jumps.html
 inspector/editor/text-editor-home-button.html
 inspector/editor/text-editor-smart-braces.html
 
-# Remove from list after enabling CANVAS_PATH
-webkit.org/b/108508 fast/canvas/canvas-path-constructors.html [ Failure ]
-webkit.org/b/108508 fast/canvas/canvas-currentPath.html [ Failure ]
-
 # Test fails on JSC platforms due to GC timing problems
 webkit.org/b/106957 svg/dom/SVGViewSpec-invalid-ref-crash.html [ Failure ]
 
index 79298de..1117b84 100644 (file)
@@ -1382,10 +1382,6 @@ webkit.org/b/102776 media/track/track-cue-rendering-vertical.html [ Failure ]
 
 webkit.org/b/103740 editing/selection/caret-alignment-for-vertical-text.html [ Failure ]
 
-# Remove from list after enabling CANVAS_PATH
-webkit.org/b/108508 fast/canvas/canvas-currentPath.html [ Failure ]
-webkit.org/b/108508 fast/canvas/canvas-path-constructors.html [ Failure ]
-
 webkit.org/b/104054 svg/custom/use-href-update-crash.svg [ Failure ]
 
 webkit.org/b/104680 http/tests/security/xss-DENIED-xml-external-entity.xhtml [ Failure ]
index e1bb109..2266df2 100644 (file)
@@ -144,11 +144,6 @@ http/tests/security/cross-origin-worker-indexeddb-allowed.html
 http/tests/security/cross-origin-worker-indexeddb.html
 http/tests/security/no-indexeddb-from-sandbox.html
 
-# Remove from list after enabling CANVAS_PATH
-fast/canvas/canvas-currentPath.html
-fast/canvas/canvas-path-constructors.html
-fast/canvas/canvas-currentPath-crash.html
-
 # This port doesn't support DeviceMotion or DeviceOrientation.
 fast/dom/DeviceMotion
 fast/dom/DeviceOrientation
index 4185d07..ed591ed 100644 (file)
@@ -1,3 +1,16 @@
+2013-02-20  Dirk Schulze  <krit@webkit.org>
+
+        Enable CANVAS_PATH flag
+        https://bugs.webkit.org/show_bug.cgi?id=108508
+
+        Reviewed by Simon Fraser.
+
+        Enable CANVAS_PATH flag on trunk.
+
+        Existing tests cover the feature.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2013-02-19  Mark Rowe  <mrowe@apple.com>
 
         Unreviewed, uninteresting change to test a theory about bad dependency handling.
index 8b53087..004847f 100644 (file)
@@ -34,7 +34,7 @@
 ENABLE_3D_RENDERING = ENABLE_3D_RENDERING;
 ENABLE_ACCELERATED_2D_CANVAS = ;
 ENABLE_BLOB = ENABLE_BLOB;
-ENABLE_CANVAS_PATH = ;
+ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
 ENABLE_CANVAS_PROXY = ;
 ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
 ENABLE_CSP_NEXT = ;
index 516da5f..53f6166 100644 (file)
 #endif
 
 #if !defined(ENABLE_CANVAS_PATH)
-#define ENABLE_CANVAS_PATH 0
+#define ENABLE_CANVAS_PATH 1
 #endif
 
 #if !defined(ENABLE_CANVAS_PROXY)
index 500ba58..28e6dea 100644 (file)
@@ -1,3 +1,16 @@
+2013-02-20  Dirk Schulze  <krit@webkit.org>
+
+        Enable CANVAS_PATH flag
+        https://bugs.webkit.org/show_bug.cgi?id=108508
+
+        Reviewed by Simon Fraser.
+
+        Enable CANVAS_PATH flag on trunk.
+
+        Existing tests cover the feature.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2013-02-20  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed, rolling out r143441.
index 62219e1..518e11f 100644 (file)
@@ -34,7 +34,7 @@
 ENABLE_3D_RENDERING = ENABLE_3D_RENDERING;
 ENABLE_ACCELERATED_2D_CANVAS = ;
 ENABLE_BLOB = ENABLE_BLOB;
-ENABLE_CANVAS_PATH = ;
+ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
 ENABLE_CANVAS_PROXY = ;
 ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
 ENABLE_CSP_NEXT = ;
index 1399912..03c5127 100644 (file)
@@ -1,3 +1,14 @@
+2013-02-20  Dirk Schulze  <krit@webkit.org>
+
+        Enable CANVAS_PATH flag
+        https://bugs.webkit.org/show_bug.cgi?id=108508
+
+        Reviewed by Simon Fraser.
+
+        Enable CANVAS_PATH flag on trunk.
+
+        * features.gypi:
+
 2013-02-15  Dirk Schulze  <krit@webkit.org>
 
         [Chromium] Add runtime flag for CanvasPath
index f2e0a41..bd6a2ad 100644 (file)
@@ -36,7 +36,7 @@
       'ENABLE_BATTERY_STATUS=0',
       'ENABLE_BLOB=1',
       'ENABLE_BLOB_SLICE=1',
-      'ENABLE_CANVAS_PATH=0',
+      'ENABLE_CANVAS_PATH=1',
       'ENABLE_CANVAS_PROXY=1',
       'ENABLE_CHANNEL_MESSAGING=1',
       'ENABLE_CSP_NEXT=1',
index 02c8374..6259c37 100644 (file)
@@ -1,3 +1,14 @@
+2013-02-20  Dirk Schulze  <krit@webkit.org>
+
+        Enable CANVAS_PATH flag
+        https://bugs.webkit.org/show_bug.cgi?id=108508
+
+        Reviewed by Simon Fraser.
+
+        Enable CANVAS_PATH flag on trunk.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2013-02-19  Tim Horton  <timothy_horton@apple.com>
 
         Clarify isInWindow vs. isVisible path through to RenderLayerCompositor
index 36e4b26..4cef706 100644 (file)
@@ -34,7 +34,7 @@
 ENABLE_3D_RENDERING = ENABLE_3D_RENDERING;
 ENABLE_ACCELERATED_2D_CANVAS = ;
 ENABLE_BLOB = ENABLE_BLOB;
-ENABLE_CANVAS_PATH = ;
+ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
 ENABLE_CANVAS_PROXY = ;
 ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
 ENABLE_CSP_NEXT = ;
index 9d4f629..a8763e3 100644 (file)
@@ -1,3 +1,14 @@
+2013-02-20  Dirk Schulze  <krit@webkit.org>
+
+        Enable CANVAS_PATH flag
+        https://bugs.webkit.org/show_bug.cgi?id=108508
+
+        Reviewed by Simon Fraser.
+
+        Enable CANVAS_PATH flag on trunk.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2013-02-20  Laszlo Gombos  <l.gombos@samsung.com>
 
         Remove unnecessary includes for Platform.h from headers
index 36e4b26..4cef706 100644 (file)
@@ -34,7 +34,7 @@
 ENABLE_3D_RENDERING = ENABLE_3D_RENDERING;
 ENABLE_ACCELERATED_2D_CANVAS = ;
 ENABLE_BLOB = ENABLE_BLOB;
-ENABLE_CANVAS_PATH = ;
+ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
 ENABLE_CANVAS_PROXY = ;
 ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
 ENABLE_CSP_NEXT = ;
index 7cd67fb..d9b891b 100644 (file)
@@ -18,7 +18,7 @@ macro(WEBKIT_OPTION_BEGIN)
     WEBKIT_OPTION_DEFINE(ENABLE_ASSEMBLER_WX_EXCLUSIVE "Toggel Assembler WX Exclusive support" OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_BATTERY_STATUS "Toggle battery status API support" OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_BLOB "Toggle Blob support" OFF)
-    WEBKIT_OPTION_DEFINE(ENABLE_CANVAS_PATH "Toggle Canvas Path support" OFF)
+    WEBKIT_OPTION_DEFINE(ENABLE_CANVAS_PATH "Toggle Canvas Path support" ON)
     WEBKIT_OPTION_DEFINE(ENABLE_CANVAS_PROXY "Toggle CanvasProxy support" OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_CHANNEL_MESSAGING "Toggle MessageChannel and MessagePort support" ON)
     WEBKIT_OPTION_DEFINE(ENABLE_CSP_NEXT "Toggle Content Security Policy 1.1 support" OFF)
index 1441b2f..05a3ea0 100644 (file)
@@ -1,3 +1,14 @@
+2013-02-20  Dirk Schulze  <krit@webkit.org>
+
+        Enable CANVAS_PATH flag
+        https://bugs.webkit.org/show_bug.cgi?id=108508
+
+        Reviewed by Simon Fraser.
+
+        Enable CANVAS_PATH flag on trunk.
+
+        * Scripts/webkitperl/FeatureList.pm:
+
 2013-02-20  Tony Chang  <tony@chromium.org>
 
         Parse author names with commas in ChangeLogs
index 0d1c032..2c06b9f 100644 (file)
@@ -165,7 +165,7 @@ my @features = (
       define => "ENABLE_BLOB", default => (isAppleMacWebKit() || isGtk() || isChromium() || isBlackBerry() || isEfl()), value => \$blobSupport },
 
     { option => "canvas-path", desc => "Toggle Canvas Path support",
-      define => "ENABLE_CANVAS_PATH", default => 0, value => \$canvasPathSupport },
+      define => "ENABLE_CANVAS_PATH", default => 1, value => \$canvasPathSupport },
 
     { option => "canvas-proxy", desc => "Toggle CanvasProxy support",
       define => "ENABLE_CANVAS_PROXY", default => 0, value => \$canvasProxySupport },