[InexedDB] Interfaces inheriting from EventTarget should generate JSC (un)wrapping...
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 1 Oct 2013 08:12:57 +0000 (08:12 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 1 Oct 2013 08:12:57 +0000 (08:12 +0000)
https://bugs.webkit.org/show_bug.cgi?id=122114

Reviewed by Darin Adler.

After r156590, four IndexedDB interfaces are inheriting from the EventTarget interface. Because of that,
they're now required to have interface-specific JSC wrapping and unwrapping functions generated since the
JSC wrapping and unwrapping functions for the EventTarget interface delegate these operations to these
interface-specific functions. If the functions are not generated and accessible, the EventTarget functions
end up recursively calling themselves.

* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBOpenDBRequest.idl:
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/indexeddb/IDBDatabase.idl
Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.idl
Source/WebCore/Modules/indexeddb/IDBRequest.idl
Source/WebCore/Modules/indexeddb/IDBTransaction.idl

index 115b225..02cea52 100644 (file)
@@ -1,3 +1,21 @@
+2013-10-01  Zan Dobersek  <zdobersek@igalia.com>
+
+        [InexedDB] Interfaces inheriting from EventTarget should generate JSC (un)wrapping functions
+        https://bugs.webkit.org/show_bug.cgi?id=122114
+
+        Reviewed by Darin Adler.
+
+        After r156590, four IndexedDB interfaces are inheriting from the EventTarget interface. Because of that,
+        they're now required to have interface-specific JSC wrapping and unwrapping functions generated since the
+        JSC wrapping and unwrapping functions for the EventTarget interface delegate these operations to these
+        interface-specific functions. If the functions are not generated and accessible, the EventTarget functions
+        end up recursively calling themselves.
+
+        * Modules/indexeddb/IDBDatabase.idl:
+        * Modules/indexeddb/IDBOpenDBRequest.idl:
+        * Modules/indexeddb/IDBRequest.idl:
+        * Modules/indexeddb/IDBTransaction.idl:
+
 2013-09-30  Ryuan Choi  <ryuan.choi@samsung.com>
 
         Build fix for EFL, Qt, Gtk port after r156688
index d6038f2..123dbfa 100644 (file)
@@ -28,7 +28,9 @@
     Conditional=INDEXED_DATABASE,
     ActiveDOMObject,
     EventTarget,
-    JSNoStaticTables
+    JSNoStaticTables,
+    JSGenerateToJSObject,
+    JSGenerateToNativeObject
 ] interface IDBDatabase : EventTarget {
     readonly attribute DOMString name;
     readonly attribute unsigned long long version;
index 97e242a..e5479cc 100644 (file)
@@ -27,7 +27,8 @@
     Conditional=INDEXED_DATABASE,
     EventTarget,
     JSNoStaticTables,
-    JSGenerateToJSObject
+    JSGenerateToJSObject,
+    JSGenerateToNativeObject
 ] interface IDBOpenDBRequest : IDBRequest {
     attribute EventListener onblocked;
     attribute EventListener onupgradeneeded;
index 1575b66..c2c7e52 100644 (file)
@@ -31,7 +31,9 @@
     Conditional=INDEXED_DATABASE,
     ActiveDOMObject,
     EventTarget,
-    JSNoStaticTables
+    JSNoStaticTables,
+    JSGenerateToJSObject,
+    JSGenerateToNativeObject
 ] interface IDBRequest : EventTarget {
     [GetterRaisesException] readonly attribute IDBAny result;
     [GetterRaisesException] readonly attribute DOMError error;
index 8eac9aa..e464342 100644 (file)
@@ -28,7 +28,9 @@
     Conditional=INDEXED_DATABASE,
     ActiveDOMObject,
     EventTarget,
-    JSNoStaticTables
+    JSNoStaticTables,
+    JSGenerateToJSObject,
+    JSGenerateToNativeObject
 ] interface IDBTransaction : EventTarget {
     readonly attribute DOMString mode;
     readonly attribute IDBDatabase db;