2006-03-30 Eric Seidel <eseidel@apple.com>
authoreseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Mar 2006 22:16:41 +0000 (22:16 +0000)
committereseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Mar 2006 22:16:41 +0000 (22:16 +0000)
        Reviewed by ggaren.

        Remove WebFrame::viewImpl(), setMainFrame on page.

        * Spinneret/Spinneret/WebFrame.cpp:
        (WebKit::WebFrame::WebFrame):
        * Spinneret/Spinneret/WebFrame.h:
        * Spinneret/Spinneret/WebView.cpp:
        (WebKit::WebView::mouseMoved):
        (WebKit::WebView::mouseDown):
        (WebKit::WebView::mouseUp):
        (WebKit::WebView::mouseDoubleClick):
        (WebKit::WebViewWndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/Spinneret/Spinneret/WebFrame.cpp
WebKitTools/Spinneret/Spinneret/WebFrame.h
WebKitTools/Spinneret/Spinneret/WebView.cpp

index 5a6e077..cb24836 100644 (file)
@@ -1,5 +1,21 @@
 2006-03-30  Eric Seidel  <eseidel@apple.com>
 
+        Reviewed by ggaren.
+
+        Remove WebFrame::viewImpl(), setMainFrame on page.
+
+        * Spinneret/Spinneret/WebFrame.cpp:
+        (WebKit::WebFrame::WebFrame):
+        * Spinneret/Spinneret/WebFrame.h:
+        * Spinneret/Spinneret/WebView.cpp:
+        (WebKit::WebView::mouseMoved):
+        (WebKit::WebView::mouseDown):
+        (WebKit::WebView::mouseUp):
+        (WebKit::WebView::mouseDoubleClick):
+        (WebKit::WebViewWndProc):
+
+2006-03-30  Eric Seidel  <eseidel@apple.com>
+
         Reviewed by hyatt.
 
         Fix html editing input & basic form submission.
index b2f93d5..cc41034 100755 (executable)
@@ -64,6 +64,7 @@ WebFrame::WebFrame(char* name, WebView* view)
     d->webView = view;
     Page *page = new Page();
     d->frame = new FrameWin(page, 0, this);
+    page->setMainFrame(d->frame);
     d->frameView = new FrameView(d->frame);
     d->frame->setView(d->frameView);
     d->frameView->setWindowHandle(view->windowHandle());
@@ -184,10 +185,5 @@ WebCore::Frame* WebFrame::impl()
     return d->frame;
 }
 
-WebCore::FrameView* WebFrame::viewImpl()
-{
-    return d->frameView;
-}
-
 }
 
index 4945419..ad4de76 100755 (executable)
@@ -59,7 +59,6 @@ namespace WebKit {
     void paint();
 
     WebCore::Frame* impl();
-    WebCore::FrameView* viewImpl();
 
     private:
         class WebFramePrivate;
index 902a9ea..b36becc 100755 (executable)
@@ -129,25 +129,25 @@ WebFrame* WebView::mainFrame()
 void WebView::mouseMoved(WPARAM wParam, LPARAM lParam)
 {
     PlatformMouseEvent mouseEvent(windowHandle(), wParam, lParam, 0);
-    d->mainFrame->viewImpl()->handleMouseMoveEvent(mouseEvent);
+    d->mainFrame->impl()->view()->handleMouseMoveEvent(mouseEvent);
 }
 
 void WebView::mouseDown(WPARAM wParam, LPARAM lParam)
 {
     PlatformMouseEvent mouseEvent(windowHandle(), wParam, lParam, 1);
-    d->mainFrame->viewImpl()->handleMousePressEvent(mouseEvent);
+    d->mainFrame->impl()->view()->handleMousePressEvent(mouseEvent);
 }
 
 void WebView::mouseUp(WPARAM wParam, LPARAM lParam)
 {
     PlatformMouseEvent mouseEvent(windowHandle(), wParam, lParam, 1);
-    d->mainFrame->viewImpl()->handleMouseReleaseEvent(mouseEvent);
+    d->mainFrame->impl()->view()->handleMouseReleaseEvent(mouseEvent);
 }
 
 void WebView::mouseDoubleClick(WPARAM wParam, LPARAM lParam)
 {
     PlatformMouseEvent mouseEvent(windowHandle(), wParam, lParam, 2);
-    d->mainFrame->viewImpl()->handleMouseReleaseEvent(mouseEvent);
+    d->mainFrame->impl()->view()->handleMouseReleaseEvent(mouseEvent);
 }
 
 bool WebView::keyPress(WPARAM wParam, LPARAM lParam)
@@ -264,13 +264,13 @@ LRESULT CALLBACK WebViewWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM l
         webview->mouseDoubleClick(wParam, lParam);
         break;
     case WM_HSCROLL: {
-        ScrollView* view = webview->mainFrame()->viewImpl();
+        ScrollView* view = webview->mainFrame()->impl()->view();
         view->scrollBy(calculateScrollDelta(wParam, view->contentsX(), view->visibleWidth()), 0);
         webview->mainFrame()->impl()->sendScrollEvent();
         break;
     }
     case WM_VSCROLL: {
-        ScrollView* view = webview->mainFrame()->viewImpl();
+        ScrollView* view = webview->mainFrame()->impl()->view();
         view->scrollBy(0, calculateScrollDelta(wParam, view->contentsY(), view->visibleHeight()));
         webview->mainFrame()->impl()->sendScrollEvent();
         break;