[ews-build] Do not display unnecessary steps in the Buildbot build page UI
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Jun 2019 21:27:07 +0000 (21:27 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Jun 2019 21:27:07 +0000 (21:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=198218
<rdar://problem/51104544>

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/ews-build/steps.py
Tools/ChangeLog

index 2d6b634..f2b74f3 100644 (file)
@@ -139,6 +139,9 @@ class ApplyPatch(shell.ShellCommand, CompositeStepMixin):
         d = self.downloadFileContentToWorker('.buildbot-diff', patch)
         d.addCallback(lambda res: shell.ShellCommand.start(self))
 
+    def hideStepIf(self, results, step):
+        return results == SUCCESS and self.getProperty('validated', '') == False
+
     def getResultSummary(self):
         if self.results != SUCCESS:
             return {u'step': u'Patch does not apply'}
@@ -368,6 +371,7 @@ class ValidatePatch(buildstep.BuildStep):
 
         if obsolete == -1 or review_denied == -1 or bug_closed == -1:
             self.finished(WARNINGS)
+            self.setProperty('validated', False)
             return None
 
         self._addToLog('stdio', 'Bug is open.\nPatch is not obsolete.\nPatch is not marked r-.\n')
@@ -809,6 +813,9 @@ class TransferToS3(master.MasterShellCommand):
 
         return super(TransferToS3, self).finished(results)
 
+    def hideStepIf(self, results, step):
+        return results == SUCCESS and self.getProperty('validated', '') == False
+
     def getResultSummary(self):
         if self.results != SUCCESS:
             return {u'step': u'Failed to transfer archive to S3'}
index e86c9fb..a17c6f1 100644 (file)
@@ -1,3 +1,13 @@
+2019-06-04  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Do not display unnecessary steps in the Buildbot build page UI
+        https://bugs.webkit.org/show_bug.cgi?id=198218
+        <rdar://problem/51104544>
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+
 2019-06-04  Sihui Liu  <sihui_liu@apple.com>
 
         WKWebsiteDataStore API fails to fetch web storage data for non-persistent data store