<ruby><div><p><rp> parses incorrectly
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Dec 2011 01:19:44 +0000 (01:19 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Dec 2011 01:19:44 +0000 (01:19 +0000)
https://bugs.webkit.org/show_bug.cgi?id=74668

Reviewed by Darin Adler.

Source/WebCore:

This patch updates our implementation to match a change to the HTML5
specification regarding how <ruby> elements parse.  Previously, <rp>
and similar tags used to pop the stack up to the <ruby> element.  Now
the popping does not occur.

Tests: html5lib/runner.html

* html/parser/HTMLTreeBuilder.cpp:

LayoutTests:

Update test results to show progression.

* html5lib/runner-expected.txt:
* platform/chromium/html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/html5lib/runner-expected.txt
LayoutTests/platform/chromium/html5lib/runner-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/html/parser/HTMLTreeBuilder.cpp

index 40bae38..48d7b5b 100644 (file)
@@ -1,5 +1,17 @@
 2011-12-15  Adam Barth  <abarth@webkit.org>
 
+        <ruby><div><p><rp> parses incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=74668
+
+        Reviewed by Darin Adler.
+
+        Update test results to show progression.
+
+        * html5lib/runner-expected.txt:
+        * platform/chromium/html5lib/runner-expected.txt:
+
+2011-12-15  Adam Barth  <abarth@webkit.org>
+
         <!DOCTYPE html><pre>&#x0a;&#x0a;A</pre> doesn't parse correctly
         https://bugs.webkit.org/show_bug.cgi?id=74658
 
index e063f43..e964ad5 100644 (file)
Binary files a/LayoutTests/html5lib/runner-expected.txt and b/LayoutTests/html5lib/runner-expected.txt differ
index 3da11d3..155fa72 100644 (file)
Binary files a/LayoutTests/platform/chromium/html5lib/runner-expected.txt and b/LayoutTests/platform/chromium/html5lib/runner-expected.txt differ
index 28cd472..0a8e8e8 100644 (file)
@@ -1,3 +1,19 @@
+2011-12-15  Adam Barth  <abarth@webkit.org>
+
+        <ruby><div><p><rp> parses incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=74668
+
+        Reviewed by Darin Adler.
+
+        This patch updates our implementation to match a change to the HTML5
+        specification regarding how <ruby> elements parse.  Previously, <rp>
+        and similar tags used to pop the stack up to the <ruby> element.  Now
+        the popping does not occur.
+
+        Tests: html5lib/runner.html
+
+        * html/parser/HTMLTreeBuilder.cpp:
+
 2011-12-15  Daniel Sievers  <sievers@chromium.org>
 
         [Chromium] Avoid strdup() for extra argument when tracing is disabled.
index 90cb2b0..4872a7e 100644 (file)
@@ -1000,10 +1000,8 @@ void HTMLTreeBuilder::processStartTagForInBody(AtomicHTMLToken& token)
     if (token.name() == rpTag || token.name() == rtTag) {
         if (m_tree.openElements()->inScope(rubyTag.localName())) {
             m_tree.generateImpliedEndTags();
-            if (!m_tree.currentNode()->hasTagName(rubyTag)) {
+            if (!m_tree.currentNode()->hasTagName(rubyTag))
                 parseError(token);
-                m_tree.openElements()->popUntil(rubyTag.localName());
-            }
         }
         m_tree.insertHTMLElement(token);
         return;