Fix touch event sending crash in WebKitTestRunner
authorwenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 Nov 2015 21:40:20 +0000 (21:40 +0000)
committerwenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 Nov 2015 21:40:20 +0000 (21:40 +0000)
https://bugs.webkit.org/show_bug.cgi?id=150848
<rdar://problem/23360841>

Reviewed by Simon Fraser.

Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.

* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/WebKitTestRunner/ios/HIDEventGenerator.mm

index 3592d59..95aa105 100644 (file)
@@ -1,3 +1,16 @@
+2015-11-03  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Fix touch event sending crash in WebKitTestRunner
+        https://bugs.webkit.org/show_bug.cgi?id=150848
+        <rdar://problem/23360841>
+
+        Reviewed by Simon Fraser.
+
+        Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.
+
+        * WebKitTestRunner/ios/HIDEventGenerator.mm:
+        (-[HIDEventGenerator _createIOHIDEventType:]): Deleted.
+
 2015-11-03  Brent Fulgham  <bfulgham@apple.com>
 
         [Win] Unreviewed build fix after r191958.
index 620f078..dbb828d 100644 (file)
@@ -205,18 +205,6 @@ static void delayBetweenMove(int eventIndex, double elapsed)
         IOHIDEventAppendEvent(eventRef.get(), subEvent.get(), 0);
     }
 
-    if (_activePointCount) {
-        IOHIDFloat progress = _activePoints[0].pathPressure;
-        RetainPtr<IOHIDEventRef> forceEvent = adoptCF(IOHIDEventCreateForceEvent(kCFAllocatorDefault,
-            machTime,
-            0,
-            progress,
-            0,
-            0.0,
-            kIOHIDEventOptionNone));
-        IOHIDEventAppendEvent(eventRef.get(), forceEvent.get(), 0);
-    }
-
     return eventRef.leakRef();
 }