Re-enable configuration.HTTPCookieStorage on session without credentials
authorwilander@apple.com <wilander@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 22 Sep 2017 23:37:23 +0000 (23:37 +0000)
committerwilander@apple.com <wilander@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 22 Sep 2017 23:37:23 +0000 (23:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=177393

This patch rolls back the crucial change to the network session
without credentials that landed in r221632:
<http://trac.webkit.org/changeset/221632>

Reviewed by Brent Fulgham.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
    Commented out the disabled cookie jar and added a FIXME
    referring to https://bugs.webkit.org/show_bug.cgi?id=177394.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

index b19e0c7..5fb3533 100644 (file)
@@ -1,3 +1,19 @@
+2017-09-22  John Wilander  <wilander@apple.com>
+
+        Re-enable configuration.HTTPCookieStorage on session without credentials
+        https://bugs.webkit.org/show_bug.cgi?id=177393
+
+        This patch rolls back the crucial change to the network session
+        without credentials that landed in r221632:
+        <http://trac.webkit.org/changeset/221632>
+
+        Reviewed by Brent Fulgham.
+
+        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+        (WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+            Commented out the disabled cookie jar and added a FIXME
+            referring to https://bugs.webkit.org/show_bug.cgi?id=177394.
+
 2017-09-22  Chris Dumez  <cdumez@apple.com>
 
         Enable File and Directory Entries API at runtime
index 9d02ee5..f283acb 100644 (file)
@@ -601,8 +601,9 @@ NetworkSessionCocoa::NetworkSessionCocoa(PAL::SessionID sessionID, LegacyCustomP
 
     configuration.URLCredentialStorage = nil;
     configuration._shouldSkipPreferredClientCertificateLookup = YES;
-    configuration.HTTPCookieStorage = nil;
-    configuration.HTTPCookieAcceptPolicy = NSHTTPCookieAcceptPolicyNever;
+    // FIXME: https://bugs.webkit.org/show_bug.cgi?id=177394
+    // configuration.HTTPCookieStorage = nil;
+    // configuration.HTTPCookieAcceptPolicy = NSHTTPCookieAcceptPolicyNever;
 
     m_statelessSessionDelegate = adoptNS([[WKNetworkSessionDelegate alloc] initWithNetworkSession:*this withCredentials:false]);
     m_statelessSession = [NSURLSession sessionWithConfiguration:configuration delegate:static_cast<id>(m_statelessSessionDelegate.get()) delegateQueue:[NSOperationQueue mainQueue]];