Passing a 32-bit depth X pixmap to NPAPI windowless plugins is too inefficient.
authorgirish@forwardbias.in <girish@forwardbias.in@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Sep 2010 09:50:27 +0000 (09:50 +0000)
committergirish@forwardbias.in <girish@forwardbias.in@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Sep 2010 09:50:27 +0000 (09:50 +0000)
Instead, pass a X Pixmap that has same depth as the screen depth since graphics
operations are optimized for this depth.

https://bugs.webkit.org/show_bug.cgi?id=45167

Reviewed by Simon Hausmann.

* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/plugins/PluginPackage.cpp

index 9c232ba..9b5b54f 100644 (file)
@@ -1,3 +1,16 @@
+2010-09-03  Girish Ramakrishnan  <girish@forwardbias.in>
+
+        Reviewed-by Simon Hausmann.
+
+        Passing a 32-bit depth X pixmap to NPAPI windowless plugins is too inefficient. 
+        Instead, pass a X Pixmap that has same depth as the screen depth since graphics 
+        operations are optimized for this depth.
+
+        https://bugs.webkit.org/show_bug.cgi?id=45167
+
+        * plugins/PluginPackage.cpp:
+        (WebCore::PluginPackage::determineQuirks):
+
 2010-09-02  Kwang Yul Seo  <skyul@company100.net>
 
         Reviewed by Kent Tamura.
index 5f358b1..99445e7 100644 (file)
@@ -215,6 +215,13 @@ void PluginPackage::determineQuirks(const String& mimeType)
         m_quirks.add(PluginQuirkThrottleWMUserPlusOneMessages);
         m_quirks.add(PluginQuirkFlashURLNotifyBug);
     }
+
+#if defined(Q_WS_MAEMO_5) || defined(Q_WS_MAEMO_6)
+    // Passing a 32-bit depth pixmap to NPAPI plugins is too inefficient. Instead, pass a X Pixmap
+    // that has same depth as the screen depth since graphics operations are optimized
+    // for this depth.
+    m_quirks.add(PluginQuirkRequiresDefaultScreenDepth);
+#endif
 }
 #endif