lldbwebkittester: Conform with testing binary format
authorjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 16 Dec 2019 22:24:54 +0000 (22:24 +0000)
committerjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 16 Dec 2019 22:24:54 +0000 (22:24 +0000)
https://bugs.webkit.org/show_bug.cgi?id=205271

Reviewed by Alexey Proskuryakov.

lldbwebkittester should be built the same way ImageDiff, TestWebKitAPI and WebKitTestRunner are.
This also paves the way for adding lldb tests against WebCore and WebKit, since lldbwebkittestrunner
is now packaged with the rest of WebKit's testing binaries.

* Scripts/build-lldbwebkittester:
* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/build-lldbwebkittester
Tools/Scripts/build-webkit

index 0ebf25f..1d73ca1 100644 (file)
@@ -1,3 +1,17 @@
+2019-12-16  Jonathan Bedard  <jbedard@apple.com>
+
+        lldbwebkittester: Conform with testing binary format
+        https://bugs.webkit.org/show_bug.cgi?id=205271
+
+        Reviewed by Alexey Proskuryakov.
+
+        lldbwebkittester should be built the same way ImageDiff, TestWebKitAPI and WebKitTestRunner are.
+        This also paves the way for adding lldb tests against WebCore and WebKit, since lldbwebkittestrunner
+        is now packaged with the rest of WebKit's testing binaries.
+
+        * Scripts/build-lldbwebkittester:
+        * Scripts/build-webkit:
+
 2019-12-16  Yusuke Suzuki  <ysuzuki@apple.com>
 
         [JSC] Remove ArrayBufferNeuteringWatchpointSet
index 3b15c4d..f341efb 100755 (executable)
@@ -67,8 +67,6 @@ chdirWebKit();
 
 my @xcodeOptions = XcodeOptions();
 
-buildProjectOrDie("Source/bmalloc", "bmalloc");
-buildProjectOrDie("Source/WTF", "WTF");
 buildProjectOrDie("Tools/lldb/lldbWebKitTester", "lldbWebKitTester");
 
 sub buildProjectOrDie($$)
index d195da9..d96a01b 100755 (executable)
@@ -262,6 +262,10 @@ if (isAppleCocoaWebKit()) {
         (system(@copyLibrariesArgs) == 0) or die;
     }
 
+    if (isAppleMacWebKit()) {
+        push @projects, ("Tools/lldb/lldbWebKitTester");
+    }
+
     # Build Tools needed for Apple ports
     push @projects, ("Tools/DumpRenderTree", "Tools/WebKitTestRunner", "Source/ThirdParty/gtest", "Tools/TestWebKitAPI");