[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 5 Oct 2012 06:22:19 +0000 (06:22 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 5 Oct 2012 06:22:19 +0000 (06:22 +0000)
https://bugs.webkit.org/show_bug.cgi?id=98256

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement UIClient's focus callbacks in WebKitTestRunner.

* WebKitTestRunner/TestController.cpp:
(WTR::focus):
(WTR::TestController::initialize):

LayoutTests:

Unskip fast/dom/Window/mozilla-focus-blur.html now that
WebKitTestRunner implements UIClient's focus callbacks.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/efl-wk2/TestExpectations
Tools/ChangeLog
Tools/WebKitTestRunner/TestController.cpp

index b2e27d6..b206592 100644 (file)
@@ -1,3 +1,15 @@
+2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
+        https://bugs.webkit.org/show_bug.cgi?id=98256
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Unskip fast/dom/Window/mozilla-focus-blur.html now that
+        WebKitTestRunner implements UIClient's focus callbacks.
+
+        * platform/efl-wk2/TestExpectations:
+
 2012-10-04  Rik Cabanier  <cabanier@adobe.com>
 
         Turn Compositing on by default in WebKit build
index 92663ec..2eb1efe 100644 (file)
@@ -198,7 +198,6 @@ webkit.org/b/93980 http/tests/appcache/load-from-appcache-defer-resume-crash.htm
 webkit.org/b/93982 storage/domstorage/storage-close-database-on-idle.html [ Failure ]
 
 # Unclassified failures
-Bug(EFL) fast/dom/Window/mozilla-focus-blur.html [ Failure ]
 Bug(EFL) http/tests/inspector/network/network-sidebar-width.html [ Failure ]
 
 # Fails after r128056.
index a5264c3..9e9a5b9 100644 (file)
@@ -1,3 +1,16 @@
+2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
+        https://bugs.webkit.org/show_bug.cgi?id=98256
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Implement UIClient's focus callbacks in WebKitTestRunner.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::focus):
+        (WTR::TestController::initialize):
+
 2012-10-04  Rik Cabanier  <cabanier@adobe.com>
 
         Turn Compositing on by default in WebKit build
index a4a00ed..3f6f9f1 100644 (file)
@@ -163,6 +163,7 @@ static void closeOtherPage(WKPageRef page, const void* clientInfo)
 static void focus(WKPageRef page, const void* clientInfo)
 {
     PlatformWebView* view = static_cast<PlatformWebView*>(const_cast<void*>(clientInfo));
+    view->focus();
     view->setWindowIsKey(true);
 }
 
@@ -362,8 +363,8 @@ void TestController::initialize(int argc, const char* argv[])
         0, // showPage
         0, // close
         0, // takeFocus
-        0, // focus
-        0, // unfocus
+        focus,
+        unfocus,
         0, // runJavaScriptAlert
         0, // runJavaScriptConfirm
         0, // runJavaScriptPrompt