Import FeedbackServer only if "-f/--feedback-in-browser" option is enabled.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Dec 2018 23:01:44 +0000 (23:01 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Dec 2018 23:01:44 +0000 (23:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=192378

Patch by Suresh Koppisetty <skoppisetty@apple.com> on 2018-12-17
Reviewed by Ryosuke Niwa.

FeedbackServer currently depends on Tornado-5.1, which further adds
dependency of "singledispatch", "backports-abc" and "futures" python libraries.
Importing FeedbackServer only if "-f/--feedback-in-browser" option is enabled
will let us run the benchmark scripts without installing any new python libraries.

* LaunchTime/launch_time.py:
* LaunchTime/new_tab.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

PerformanceTests/ChangeLog
PerformanceTests/LaunchTime/launch_time.py
PerformanceTests/LaunchTime/new_tab.py

index c59f3f6..c264aef 100644 (file)
@@ -1,3 +1,18 @@
+2018-12-17  Suresh Koppisetty  <skoppisetty@apple.com>
+
+        Import FeedbackServer only if "-f/--feedback-in-browser" option is enabled.
+        https://bugs.webkit.org/show_bug.cgi?id=192378
+
+        Reviewed by Ryosuke Niwa.
+
+        FeedbackServer currently depends on Tornado-5.1, which further adds
+        dependency of "singledispatch", "backports-abc" and "futures" python libraries.
+        Importing FeedbackServer only if "-f/--feedback-in-browser" option is enabled
+        will let us run the benchmark scripts without installing any new python libraries.
+
+        * LaunchTime/launch_time.py:
+        * LaunchTime/new_tab.py:
+
 2018-12-13  Caio Lima  <ticaiolima@gmail.com>
 
         [BigInt] Add ValueDiv into DFG
 2018-12-13  Caio Lima  <ticaiolima@gmail.com>
 
         [BigInt] Add ValueDiv into DFG
index 53a5a3b..be84678 100644 (file)
@@ -10,7 +10,6 @@ import sys
 import threading
 import time
 
 import threading
 import time
 
-from feedback_server import FeedbackServer
 
 
 # Supress logs from feedback server
 
 
 # Supress logs from feedback server
@@ -146,6 +145,7 @@ class LaunchTimeBenchmark:
         self._server_ready.acquire()
 
         if self._feedback_in_browser:
         self._server_ready.acquire()
 
         if self._feedback_in_browser:
+            from feedback_server import FeedbackServer
             self._feedback_server = FeedbackServer()
             self._feedback_port = self._feedback_server.start()
 
             self._feedback_server = FeedbackServer()
             self._feedback_port = self._feedback_server.start()
 
index d5c5d19..161b665 100755 (executable)
@@ -4,8 +4,6 @@ import time
 from threading import Event
 
 from launch_time import LaunchTimeBenchmark, DefaultLaunchTimeHandler
 from threading import Event
 
 from launch_time import LaunchTimeBenchmark, DefaultLaunchTimeHandler
-import feedback_server
-
 
 class NewTabBenchmark(LaunchTimeBenchmark):
     def _parse_wait_time(self, string):
 
 class NewTabBenchmark(LaunchTimeBenchmark):
     def _parse_wait_time(self, string):