Add iOS WebKit1 TestExpectation file
authordbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Jan 2015 23:29:50 +0000 (23:29 +0000)
committerdbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Jan 2015 23:29:50 +0000 (23:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=140739

Reviewed by David Kilzer.

Tools:

Teach run-webkit-tests to look for iOS WebKit1-specific test results and
expectations in directory LayoutTests/platform/ios-simulator-wk1.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_baseline_search_path):

LayoutTests:

iOS WebKit1 is different enough from iOS WebKit2 that it would benefit from having its
own TestExpectation file. We can work to reduce such differences over time.

* platform/ios-simulator-wk1/TestExpectations: Added.
* platform/ios-simulator/TestExpectations: Move iOS WebKit1-specific test expectation from here
to file LayoutTests/platform/ios-simulator-wk1/TestExpectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@178867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/ios-simulator-wk1/TestExpectations [new file with mode: 0644]
LayoutTests/platform/ios-simulator/TestExpectations
Tools/ChangeLog
Tools/Scripts/webkitpy/port/ios.py

index b6105a7..56cba72 100644 (file)
@@ -1,3 +1,17 @@
+2015-01-21  Daniel Bates  <dabates@apple.com>
+
+        Add iOS WebKit1 TestExpectation file
+        https://bugs.webkit.org/show_bug.cgi?id=140739
+
+        Reviewed by David Kilzer.
+
+        iOS WebKit1 is different enough from iOS WebKit2 that it would benefit from having its
+        own TestExpectation file. We can work to reduce such differences over time.
+
+        * platform/ios-simulator-wk1/TestExpectations: Added.
+        * platform/ios-simulator/TestExpectations: Move iOS WebKit1-specific test expectation from here
+        to file LayoutTests/platform/ios-simulator-wk1/TestExpectations.
+
 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
 
         [Win] Unreviewed gardening based on TestBot runs.
diff --git a/LayoutTests/platform/ios-simulator-wk1/TestExpectations b/LayoutTests/platform/ios-simulator-wk1/TestExpectations
new file mode 100644 (file)
index 0000000..0d61eb0
--- /dev/null
@@ -0,0 +1,31 @@
+# These are the layout test expectations for Apple's iOS port of WebKit1.
+#
+# See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
+
+# LayoutTests/fast tests that fail:
+fast/borders/bidi-002.html [ Failure ]
+fast/dom/HTMLLinkElement/prefetch-beforeload.html [ Failure ]
+fast/events/touch/gesture/gesture-scrollbar.html [ Failure ]
+fast/flexbox/clear-overflow-before-scroll-update.html [ Failure ]
+
+# LayoutTests/fast test that time out:
+fast/block/positioning/vertical-rl/001.html
+fast/body-propagation/background-color/001-xhtml.xhtml
+fast/body-propagation/background-image/001-xhtml.xhtml
+fast/body-propagation/overflow/001-xhtml.xhtml
+fast/borders/0px-borders-no-line-height.html
+fast/box-decoration-break/box-decoration-break-parsing.html
+fast/box-shadow/basic-shadows.html
+fast/css/reload-non-styled-element-crash.html
+fast/dom/HTMLLinkElement/prefetch.html
+fast/dom/Window/window-postmessage-clone-frames.html
+fast/dom/Window/window-postmessage-clone.html
+fast/dom/Window/window-resize-contents.html
+fast/events/clipboard-dataTransferItemList.html
+fast/forms/interactive-validation-crash-by-style-override.html
+fast/forms/interactive-validation-select-crash.html
+fast/forms/select-empty-optgroup.html
+fast/forms/validation-message-in-relative-body.html
+fast/frames/lots-of-iframes.html
+fast/frames/lots-of-objects.html
+fast/images/animated-gif-webkit-transform.html
index 5c8f6fd..e3ac87f 100644 (file)
@@ -1,4 +1,4 @@
-# These are the layout test expectations for Apple's iOS port of WebKit.
+# These are the layout test expectations for Apple's iOS port of WebKit (both WebKit1 and WebKit2).
 #
 # See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
 
@@ -2359,36 +2359,6 @@ fast/events/keydown-keypress-preventDefault.html [ Failure ]
 fast/events/media-element-focus-tab.html [ Failure ]
 fast/writing-mode/flipped-blocks-hit-test-line-edges.html [ Failure ]
 
-# LayoutTests/fast tests that fail in WebKit1:
-# FIXME: We should move these to a WebKit1-specific TestExpectation file.
-fast/borders/bidi-002.html [ Failure ]
-fast/dom/HTMLLinkElement/prefetch-beforeload.html [ Failure ]
-fast/events/touch/gesture/gesture-scrollbar.html [ Failure ]
-fast/flexbox/clear-overflow-before-scroll-update.html [ Failure ]
-
-# LayoutTests/fast test that time out in WebKit1:
-# FIXME: We should move these to a WebKit1-specific TestExpectation file.
-fast/block/positioning/vertical-rl/001.html
-fast/body-propagation/background-color/001-xhtml.xhtml
-fast/body-propagation/background-image/001-xhtml.xhtml
-fast/body-propagation/overflow/001-xhtml.xhtml
-fast/borders/0px-borders-no-line-height.html
-fast/box-decoration-break/box-decoration-break-parsing.html
-fast/box-shadow/basic-shadows.html
-fast/css/reload-non-styled-element-crash.html
-fast/dom/HTMLLinkElement/prefetch.html
-fast/dom/Window/window-postmessage-clone-frames.html
-fast/dom/Window/window-postmessage-clone.html
-fast/dom/Window/window-resize-contents.html
-fast/events/clipboard-dataTransferItemList.html
-fast/forms/interactive-validation-crash-by-style-override.html
-fast/forms/interactive-validation-select-crash.html
-fast/forms/select-empty-optgroup.html
-fast/forms/validation-message-in-relative-body.html
-fast/frames/lots-of-iframes.html
-fast/frames/lots-of-objects.html
-fast/images/animated-gif-webkit-transform.html
-
 # LayoutTests/fast tests that time out:
 fast/events/reveal-link-when-focused.html
 fast/dynamic/window-resize-scrollbars-test.html # Need to remove existing result
index 7b1f2e4..9416075 100644 (file)
@@ -1,3 +1,16 @@
+2015-01-21  Daniel Bates  <dabates@apple.com>
+
+        Add iOS WebKit1 TestExpectation file
+        https://bugs.webkit.org/show_bug.cgi?id=140739
+
+        Reviewed by David Kilzer.
+
+        Teach run-webkit-tests to look for iOS WebKit1-specific test results and
+        expectations in directory LayoutTests/platform/ios-simulator-wk1.
+
+        * Scripts/webkitpy/port/ios.py:
+        (IOSSimulatorPort.default_baseline_search_path):
+
 2015-01-21  David Kilzer  <ddkilzer@apple.com>
 
         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
index dc4076d..5fd9794 100644 (file)
@@ -174,7 +174,7 @@ class IOSSimulatorPort(Port):
         if self.get_option('webkit_test_runner'):
             fallback_names = [self.port_name + '-wk2'] + [self.port_name]
         else:
-            fallback_names = [self.port_name]
+            fallback_names = [self.port_name + '-wk1'] + [self.port_name]
 
         return map(self._webkit_baseline_path, fallback_names)