Flaky Test: fast/history/history-subframe-with-name.html
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Sep 2013 22:09:19 +0000 (22:09 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Sep 2013 22:09:19 +0000 (22:09 +0000)
https://bugs.webkit.org/show_bug.cgi?id=51039

Reviewed by Anders Carlsson.

Speculative fix, I could not reproduce locally.

* fast/history/resources/history-subframe-with-name-container.html: Added a check
that onunload trick worked.

* fast/history/resources/history-subframe-with-name-2.html: Starting the navigation
used to race with loading another iframe in the parent. Wait until the parent loads.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/history/resources/history-subframe-with-name-2.html
LayoutTests/fast/history/resources/history-subframe-with-name-container.html

index c282deb..7ae7a65 100644 (file)
@@ -1,3 +1,18 @@
+2013-09-24  Alexey Proskuryakov  <ap@apple.com>
+
+        Flaky Test: fast/history/history-subframe-with-name.html
+        https://bugs.webkit.org/show_bug.cgi?id=51039
+
+        Reviewed by Anders Carlsson.
+
+        Speculative fix, I could not reproduce locally.
+
+        * fast/history/resources/history-subframe-with-name-container.html: Added a check
+        that onunload trick worked. 
+
+        * fast/history/resources/history-subframe-with-name-2.html: Starting the navigation
+        used to race with loading another iframe in the parent. Wait until the parent loads.
+
 2013-09-24  Dean Jackson  <dino@apple.com>
 
         webgl/conformance/extensions/oes-element-index-uint.html failing after r156351 or 156352
index 4cd6587..99643b3 100644 (file)
@@ -2,6 +2,11 @@
 <script> 
   function runTest()
   {
+      // The parent has two frames. Do not run the test until both finished loading.
+      if (parent.document.readyState != "complete") {
+          setTimeout(runTest, 0);
+          return;
+      }
       parent.opener.onFrameLoaded(2);
       // Make sure we generate a history entry
       setTimeout(function() {location.href = 'history-subframe-with-name-3.html';}, 0);
index 3ab8db8..4c30cb9 100644 (file)
@@ -1,6 +1,7 @@
 <script>
 // Disable the page cache when running inside of Safari
-onunload = function() {};
+onunload = function() { }
+onpageshow = function() { if (event.persisted) alert("FAIL: Could not disable page cache"); }
 </script>
 <iframe src="history-subframe-with-name-2.html"></iframe>
 <iframe src="data:text/html,<script>window.name='foo';</script>window that changes its name"></iframe>