2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
authorkbalazs@webkit.org <kbalazs@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Sep 2010 08:55:17 +0000 (08:55 +0000)
committerkbalazs@webkit.org <kbalazs@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Sep 2010 08:55:17 +0000 (08:55 +0000)
        Reviewed by Darin Adler.

        check-webkit-style and the coding style guidelines page are inconsistent
        https://bugs.webkit.org/show_bug.cgi?id=46099

        * coding/coding-style.html:
        Making clear that includes of system headers must come after includes of other headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitSite/ChangeLog
WebKitSite/coding/coding-style.html

index 629d2a4..b499018 100644 (file)
@@ -1,3 +1,13 @@
+2010-09-22  Balazs Kelemen  <kb@inf.u-szeged.hu>
+
+        Reviewed by Darin Adler.
+
+        check-webkit-style and the coding style guidelines page are inconsistent
+        https://bugs.webkit.org/show_bug.cgi?id=46099
+
+        * coding/coding-style.html:
+        Making clear that includes of system headers must come after includes of other headers.
+
 2010-09-16  Tony Gentilcore  <tonyg@chromium.org>
 
         Reviewed by Adam Barth.
index 10527f2..86d5158 100644 (file)
@@ -755,6 +755,33 @@ Don't bother to organize them in a logical order.
 #include "QualifiedName.h"
 #include "Attribute.h"
 </pre>
+
+<li>Includes of system headers must come after includes of other headers.
+
+<h4 class="right">Right:</h4>
+<pre class="code">
+// ConnectionQt.cpp
+#include "ArgumentEncoder.h"
+#include "ProcessLauncher.h"
+#include "WebPageProxyMessageKinds.h"
+#include "WorkItem.h"
+#include &ltQApplication&gt
+#include &ltQLocalServer&gt
+#include &ltQLocalSocket&gt
+</pre>
+
+<h4 class="wrong">Wrong:</h4>
+<pre class="code">
+// ConnectionQt.cpp
+#include "ArgumentEncoder.h"
+#include "ProcessLauncher.h"
+#include &ltQApplication&gt
+#include &ltQLocalServer&gt
+#include &ltQLocalSocket&gt
+#include "WebPageProxyMessageKinds.h"
+#include "WorkItem.h"
+</pre>
+</li>
 </ol>
 
 <h3>"using" Statements</h3>