REGRESSION(r236365): [GTK] Many form-related tests are failing
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 9 Nov 2018 16:15:04 +0000 (16:15 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 9 Nov 2018 16:15:04 +0000 (16:15 +0000)
https://bugs.webkit.org/show_bug.cgi?id=189993

Reviewed by Michael Catanzaro.

Source/WebCore:

Only the first form data element is added to the message body due to a return added by mistake in r236365.

* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessageBody const): Remove return.

LayoutTests:

Remove expectations for tests that are passing now.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp

index 20af5eb..662822d 100644 (file)
@@ -1,3 +1,14 @@
+2018-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r236365): [GTK] Many form-related tests are failing
+        https://bugs.webkit.org/show_bug.cgi?id=189993
+
+        Reviewed by Michael Catanzaro.
+
+        Remove expectations for tests that are passing now.
+
+        * platform/gtk/TestExpectations:
+
 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
 
         Adopt Reveal Framework to replace Lookup
index 4144713..266a4d8 100644 (file)
@@ -3531,11 +3531,6 @@ webkit.org/b/189739 svg/gradients/spreadMethodClose2.svg [ ImageOnlyFailure ]
 webkit.org/b/189739 svg/gradients/spreadMethodDiagonal3.svg [ ImageOnlyFailure ]
 webkit.org/b/189739 svg/gradients/spreadMethodDiagonal4.svg [ ImageOnlyFailure ]
 
-webkit.org/b/189993 http/tests/fileapi/xhr-send-form-data-filename-escaping.html [ Failure ]
-webkit.org/b/189993 http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html [ Failure ]
-webkit.org/b/189993 http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html [ Failure ]
-webkit.org/b/189993 http/tests/misc/form-blob-challenge.html [ Failure ]
-
 webkit.org/b/189994 fast/files/xhr-response-blob.html [ Failure ]
 
 webkit.org/b/189995 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html [ Failure ]
index 709aa91..2320bf4 100644 (file)
@@ -1,3 +1,15 @@
+2018-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r236365): [GTK] Many form-related tests are failing
+        https://bugs.webkit.org/show_bug.cgi?id=189993
+
+        Reviewed by Michael Catanzaro.
+
+        Only the first form data element is added to the message body due to a return added by mistake in r236365.
+
+        * platform/network/soup/ResourceRequestSoup.cpp:
+        (WebCore::ResourceRequest::updateSoupMessageBody const): Remove return.
+
 2018-11-09  Zalan Bujtas  <zalan@apple.com>
 
         [LFC][IFC] Move some code from InlineFormattingContext::Line to InlineFormattingContext/Geometry
index 58cfa77..090dc7f 100644 (file)
@@ -74,7 +74,7 @@ void ResourceRequest::updateSoupMessageBody(SoupMessage* soupMessage) const
     soup_message_body_set_accumulate(soupMessage->request_body, FALSE);
     uint64_t bodySize = 0;
     for (const auto& element : formData->elements()) {
-        return switchOn(element.data,
+        switchOn(element.data,
             [&] (const Vector<char>& bytes) {
                 bodySize += bytes.size();
                 soup_message_body_append(soupMessage->request_body, SOUP_MEMORY_TEMPORARY, bytes.data(), bytes.size());