2008-03-02 Brent Fulgham <bfulgham@gmail.com>
authoralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 3 Mar 2008 05:10:18 +0000 (05:10 +0000)
committeralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 3 Mar 2008 05:10:18 +0000 (05:10 +0000)
        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=17415
        GTK Build (using autotools) on Mac OS (DarwinPorts) Fails

        Add -lstdc++ to link flags for minidom program.  This corrects
        a build error for the GTK+ on Mac OS.

        Add ICU_CPPFLAGS earlier in include path for WebCore
        so that we find $(icu_cppflags)/unicode/utf8.h, rather than
        the wtf/unicode/UTF8.h on case-insensitive file systems.

        Remove some needless LIBS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
GNUmakefile.am
JavaScriptCore/ChangeLog
JavaScriptCore/GNUmakefile.am
WebKitTools/ChangeLog
WebKitTools/GNUmakefile.am

index c711b18..36124f7 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
+
+        Reviewed by Alp Toker.
+
+        Add ICU_CPPFLAGS earlier in include path for WebCore
+        so that we find $(icu_cppflags)/unicode/utf8.h, rather than
+        the wtf/unicode/UTF8.h on case-insensitive file systems.
+
+        * GNUmakefile.am:
+
 2008-03-02  Alp Toker  <alp@atoker.com>
 
         Reviewed by Mark Rowe.
index 64c836a..977770a 100644 (file)
@@ -175,10 +175,10 @@ libWebCore_la_CFLAGS = \
        $(HILDON_CFLAGS)
 
 libWebCore_la_CPPFLAGS = \
+       $(ICU_CPPFLAGS) \
        $(global_cppflags) \
        $(webcore_cppflags) \
-       $(webkitgtk_cppflags) \
-       $(ICU_CPPFLAGS)
+       $(webkitgtk_cppflags)
 
 libWebCore_la_LIBADD = \
        libJavaScriptCore.la \
index a764a7b..b4663b7 100644 (file)
@@ -1,3 +1,15 @@
+2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
+
+        Reviewed by Alp Toker.
+
+        http://bugs.webkit.org/show_bug.cgi?id=17415
+        GTK Build (using autotools) on Mac OS (DarwinPorts) Fails
+
+        Add -lstdc++ to link flags for minidom program.  This corrects
+        a build error for the GTK+ on Mac OS.
+
+        * GNUmakefile.am:
+
 2008-03-01  Mark Rowe  <mrowe@apple.com>
 
         Reviewed by Tim Hatcher.
index 63e604c..9fac10d 100644 (file)
@@ -159,8 +159,7 @@ Programs_minidom_CXXFLAGS = \
        $(GLOBALDEPS_CFLAGS)
 Programs_minidom_LDADD = \
         libJavaScriptCore.la \
-       $(GLOBALDEPS_LIBS) \
-       $(ICU_LIBS)
+        -lstdc++
 Programs_minidom_LDFLAGS = -rpath $(CURDIR)/.libs
 
 # testkjs
@@ -171,9 +170,7 @@ Programs_testkjs_CXXFLAGS = \
        $(global_cflags) \
        $(GLOBALDEPS_CFLAGS)
 Programs_testkjs_LDADD = \
-       libJavaScriptCore.la \
-       $(GLOBALDEPS_LIBS) \
-       $(ICU_LIBS)
+       libJavaScriptCore.la
 Programs_testkjs_LDFLAGS = -rpath $(CURDIR)/.libs
 
 # Clean rules for JavaScriptCore
index 5d6d819..45bc2c2 100644 (file)
@@ -1,3 +1,11 @@
+2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
+
+        Reviewed by Alp Toker.
+
+        Remove some needless LIBS.
+
+        * GNUmakefile.am:
+
 2008-03-02  Alp Toker  <alp@atoker.com>
 
         Reviewed by Mark Rowe.
index ad229c2..26758b5 100644 (file)
@@ -16,8 +16,6 @@ Programs_GtkLauncher_CFLAGS = \
        $(global_cflags)
 
 Programs_GtkLauncher_LDADD = \
-       $(GLOBALDEPS_LIBS) \
-       $(WEBKITDEPS_LIBS) \
        libwebkit-1.0.la
 
 Programs_GtkLauncher_LDFLAGS = -rpath $(CURDIR)/.libs
@@ -45,8 +43,6 @@ Programs_DumpRenderTree_CXXFLAGS = \
        $(global_cflags)
 
 Programs_DumpRenderTree_LDADD = \
-       $(GLOBALDEPS_LIBS) \
-       $(WEBKITDEPS_LIBS) \
        libwebkit-1.0.la
 
 Programs_DumpRenderTree_LDFLAGS = -rpath $(CURDIR)/.libs