XMLHttpRequest should not be exposed to service workers
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Dec 2017 22:46:08 +0000 (22:46 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Dec 2017 22:46:08 +0000 (22:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=180446

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test that has one more check passing.

* web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:

Source/WebCore:

Stop exposing XMLHttpRequest to service workers, as per:
- https://xhr.spec.whatwg.org/#interface-xmlhttprequest

* xml/XMLHttpRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/xml/XMLHttpRequest.idl

index 73b8527..73f8588 100644 (file)
@@ -1,3 +1,14 @@
+2017-12-05  Chris Dumez  <cdumez@apple.com>
+
+        XMLHttpRequest should not be exposed to service workers
+        https://bugs.webkit.org/show_bug.cgi?id=180446
+
+        Reviewed by Youenn Fablet.
+
+        Rebaseline WPT test that has one more check passing.
+
+        * web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:
+
 2017-12-05  Youenn Fablet  <youenn@apple.com>
 
         Implement https://w3c.github.io/ServiceWorker/#clients-claim
index 9c3f54a..f3bdc3d 100644 (file)
@@ -4,7 +4,7 @@ Harness Error (TIMEOUT), message = null
 PASS Interfaces and attributes in ServiceWorkerGlobalScope 
 TIMEOUT test setup (cache creation) Test timed out
 FAIL Event constructors assert_equals: Default FetchEvent.clientId should be null expected (object) null but got (string) ""
-FAIL xhr is not exposed assert_false: expected false got true
+PASS xhr is not exposed 
 PASS ServiceWorkerGlobalScope interface: existence and properties of interface object 
 PASS ServiceWorkerGlobalScope interface object length 
 PASS ServiceWorkerGlobalScope interface object name 
index b3289b7..56b11bc 100644 (file)
@@ -1,3 +1,15 @@
+2017-12-05  Chris Dumez  <cdumez@apple.com>
+
+        XMLHttpRequest should not be exposed to service workers
+        https://bugs.webkit.org/show_bug.cgi?id=180446
+
+        Reviewed by Youenn Fablet.
+
+        Stop exposing XMLHttpRequest to service workers, as per:
+        - https://xhr.spec.whatwg.org/#interface-xmlhttprequest
+
+        * xml/XMLHttpRequest.idl:
+
 2017-12-05  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: content views for resources loaded through XHR do not reflect declared mime-type
index 8c860b9..3b1a776 100644 (file)
@@ -43,7 +43,7 @@ enum XMLHttpRequestResponseType {
     Constructor,
     ConstructorCallWith=ScriptExecutionContext,
     ExportMacro=WEBCORE_EXPORT,
-    Exposed=(Window,Worker),
+    Exposed=(Window,DedicatedWorker),
     JSCustomMarkFunction,
     JSGenerateToJSObject,
     JSGenerateToNativeObject,