Web Inspector: REGRESSION(r259101): items in the contextmenu of the tab bar don't...
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 31 Mar 2020 02:41:13 +0000 (02:41 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 31 Mar 2020 02:41:13 +0000 (02:41 +0000)
https://bugs.webkit.org/show_bug.cgi?id=209793

Reviewed by Timothy Hatcher.

Fix a few places that weren't changed to use `displayName` instead of `title`.

* UserInterface/Base/Main.js:
(WI._tabBrowserSelectedTabContentViewDidChange):
* UserInterface/Views/TabBar.js:
(WI.TabBar.prototype._handleTabContainerMouseDown):
(WI.TabBar.prototype._handleTabContainerContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Base/Main.js
Source/WebInspectorUI/UserInterface/Views/TabBar.js

index 728a9b2..787fe19 100644 (file)
@@ -1,5 +1,20 @@
 2020-03-30  Devin Rousso  <drousso@apple.com>
 
+        Web Inspector: REGRESSION(r259101): items in the contextmenu of the tab bar don't have any text
+        https://bugs.webkit.org/show_bug.cgi?id=209793
+
+        Reviewed by Timothy Hatcher.
+
+        Fix a few places that weren't changed to use `displayName` instead of `title`.
+
+        * UserInterface/Base/Main.js:
+        (WI._tabBrowserSelectedTabContentViewDidChange):
+        * UserInterface/Views/TabBar.js:
+        (WI.TabBar.prototype._handleTabContainerMouseDown):
+        (WI.TabBar.prototype._handleTabContainerContextMenu):
+
+2020-03-30  Devin Rousso  <drousso@apple.com>
+
         Web Inspector: provide a way to log messages from the network process
         https://bugs.webkit.org/show_bug.cgi?id=204775
 
index 97263bf..b6ee80e 100644 (file)
@@ -1945,7 +1945,7 @@ WI._tabBrowserSelectedTabContentViewDidChange = function(event)
 {
     let selectedTabBarItem = WI.tabBar.selectedTabBarItem;
     if (selectedTabBarItem) {
-        WI._contentElement.ariaLabel = selectedTabBarItem.title || "";
+        WI._contentElement.ariaLabel = selectedTabBarItem.displayName || "";
 
         if (selectedTabBarItem.representedObject.constructor.shouldSaveTab())
             WI._selectedTabIndexSetting.value = WI.tabBar.tabBarItems.indexOf(selectedTabBarItem);
index 1eb24af..2464f9a 100644 (file)
@@ -705,7 +705,7 @@ WI.TabBar = class TabBar extends WI.View
             });
 
             for (let item of this._hiddenTabBarItems) {
-                contextMenu.appendItem(item.title, () => {
+                contextMenu.appendItem(item.displayName, () => {
                     this.selectTabBarItem(item, {
                         initiator: WI.TabBrowser.TabNavigationInitiator.ContextMenu
                     });
@@ -952,7 +952,7 @@ WI.TabBar = class TabBar extends WI.View
 
             let checked = !!openTabBarItem;
             let disabled = checked && this.normalTabCount === 1;
-            contextMenu.appendCheckboxItem(tabClass.tabInfo().title, () => {
+            contextMenu.appendCheckboxItem(tabClass.tabInfo().displayName, () => {
                 if (openTabBarItem)
                     this.removeTabBarItem(openTabBarItem);
                 else