2009-02-20 Avi Drissman <avi@chromium.org>
authordarin@chromium.org <darin@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Feb 2009 15:34:42 +0000 (15:34 +0000)
committerdarin@chromium.org <darin@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Feb 2009 15:34:42 +0000 (15:34 +0000)
        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24036
        Keyboard events need disambiguation on the Linux platform too.

        * platform/chromium/PlatformKeyboardEventChromium.cpp:
        (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/platform/chromium/PlatformKeyboardEventChromium.cpp

index 8e7f98e..c164d7d 100644 (file)
@@ -1,3 +1,13 @@
+2009-02-20  Avi Drissman  <avi@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=24036
+        Keyboard events need disambiguation on the Linux platform too.
+
+        * platform/chromium/PlatformKeyboardEventChromium.cpp:
+        (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
+
 2009-02-19  Darin Fisher  <darin@chromium.org>
 
         Reviewed by Eric Seidel.
index 6840bdf..ae55afe 100644 (file)
@@ -42,7 +42,7 @@ void PlatformKeyboardEvent::disambiguateKeyDownEvent(Type type, bool backwardCom
 #if PLATFORM(WIN_OS)
     // No KeyDown events on Windows to disambiguate.
     ASSERT_NOT_REACHED();
-#elif PLATFORM(DARWIN)
+#else
     // Can only change type from KeyDown to RawKeyDown or Char, as we lack information for other conversions.
     ASSERT(m_type == KeyDown);
     ASSERT(type == RawKeyDown || type == Char);
@@ -56,6 +56,7 @@ void PlatformKeyboardEvent::disambiguateKeyDownEvent(Type type, bool backwardCom
     } else {
         m_keyIdentifier = String();
         m_windowsVirtualKeyCode = 0;
+#if PLATFORM(DARWIN)
         if (m_text.length() == 1 && (m_text[0U] >= 0xF700 && m_text[0U] <= 0xF7FF)) {
             // According to NSEvents.h, OpenStep reserves the range 0xF700-0xF8FF for function keys. However, some actual private use characters
             // happen to be in this range, e.g. the Apple logo (Option+Shift+K).
@@ -63,6 +64,7 @@ void PlatformKeyboardEvent::disambiguateKeyDownEvent(Type type, bool backwardCom
             m_text = String();
             m_unmodifiedText = String();
         }
+#endif
     }
 #endif
 }